RFR: 8176573: Do not use FLAG_SET_ERGO to update MaxRAM for emulated client

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8176573: Do not use FLAG_SET_ERGO to update MaxRAM for emulated client

Jamsheed C m
Hi,

Request for review for a small change:

Issue: setting MaxRAM using FLAG_SET_ERGO doesn't work well with
set_heap_size based on available physical memory[1]

Fix: use FLAG_SET_DEFAULT to update MaxRAM.

bug: https://bugs.openjdk.java.net/browse/JDK-8176573

webrev: http://cr.openjdk.java.net/~jcm/8176573/webrev.00/

testing: jprt

Best Regards,

Jamsheed

[1]

void Arguments::set_heap_size() {
   julong phys_mem =
     FLAG_IS_DEFAULT(MaxRAM) ? MIN2(os::physical_memory(), (julong)MaxRAM)
                             : (julong)MaxRAM;


Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8176573: Do not use FLAG_SET_ERGO to update MaxRAM for emulated client

Vladimir Kozlov
Good.

Thanks,
Vladimir

On 3/13/17 11:16 AM, Jamsheed C m wrote:

> Hi,
>
> Request for review for a small change:
>
> Issue: setting MaxRAM using FLAG_SET_ERGO doesn't work well with set_heap_size based on available physical memory[1]
>
> Fix: use FLAG_SET_DEFAULT to update MaxRAM.
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8176573
>
> webrev: http://cr.openjdk.java.net/~jcm/8176573/webrev.00/
>
> testing: jprt
>
> Best Regards,
>
> Jamsheed
>
> [1]
>
> void Arguments::set_heap_size() {
>   julong phys_mem =
>     FLAG_IS_DEFAULT(MaxRAM) ? MIN2(os::physical_memory(), (julong)MaxRAM)
>                             : (julong)MaxRAM;
>
>
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8176573: Do not use FLAG_SET_ERGO to update MaxRAM for emulated client

Jamsheed C m
Thank you, Vladimir

Best Regards,

Jamsheed


On 3/14/2017 7:11 AM, Vladimir Kozlov wrote:

> Good.
>
> Thanks,
> Vladimir
>
> On 3/13/17 11:16 AM, Jamsheed C m wrote:
>> Hi,
>>
>> Request for review for a small change:
>>
>> Issue: setting MaxRAM using FLAG_SET_ERGO doesn't work well with
>> set_heap_size based on available physical memory[1]
>>
>> Fix: use FLAG_SET_DEFAULT to update MaxRAM.
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8176573
>>
>> webrev: http://cr.openjdk.java.net/~jcm/8176573/webrev.00/
>>
>> testing: jprt
>>
>> Best Regards,
>>
>> Jamsheed
>>
>> [1]
>>
>> void Arguments::set_heap_size() {
>>   julong phys_mem =
>>     FLAG_IS_DEFAULT(MaxRAM) ? MIN2(os::physical_memory(),
>> (julong)MaxRAM)
>>                             : (julong)MaxRAM;
>>
>>