RFR 8176715: sun/security/krb5/auto/HttpNegotiateServer.java does not compile

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RFR 8176715: sun/security/krb5/auto/HttpNegotiateServer.java does not compile

Weijun Wang
Please review the patch below:

diff --git a/test/sun/security/krb5/auto/HttpNegotiateServer.java
b/test/sun/security/krb5/auto/HttpNegotiateServer.java
--- a/test/sun/security/krb5/auto/HttpNegotiateServer.java
+++ b/test/sun/security/krb5/auto/HttpNegotiateServer.java
@@ -28,6 +28,7 @@
   *          java.security.jgss/sun.security.krb5.internal:+open
   *          java.security.jgss/sun.security.jgss
   *          java.security.jgss/sun.security.krb5:+open
+ *          java.security.jgss/sun.security.krb5.internal.ccache
   *          java.security.jgss/sun.security.krb5.internal.crypto
   *          java.security.jgss/sun.security.krb5.internal.ktab
   *          jdk.security.auth

This test uses KDC.java which references a class inside
sun.security.krb5.internal.ccache. Other tests in the same directory do
have this package in their @modules tag (in fact, they share the same in
TEST.properties) so if any of them is executed earlier, KDC.class will
be generated and this test can use it. However, if this test is executed
first, the compile will fail.

Thanks
Max
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR 8176715: sun/security/krb5/auto/HttpNegotiateServer.java does not compile

Amy Lu-2
Looks good.

(I'm not a reviewer)

Thanks,
Amy

On 3/14/17 11:38 AM, Weijun Wang wrote:

> Please review the patch below:
>
> diff --git a/test/sun/security/krb5/auto/HttpNegotiateServer.java
> b/test/sun/security/krb5/auto/HttpNegotiateServer.java
> --- a/test/sun/security/krb5/auto/HttpNegotiateServer.java
> +++ b/test/sun/security/krb5/auto/HttpNegotiateServer.java
> @@ -28,6 +28,7 @@
>   *          java.security.jgss/sun.security.krb5.internal:+open
>   *          java.security.jgss/sun.security.jgss
>   *          java.security.jgss/sun.security.krb5:+open
> + *          java.security.jgss/sun.security.krb5.internal.ccache
>   *          java.security.jgss/sun.security.krb5.internal.crypto
>   *          java.security.jgss/sun.security.krb5.internal.ktab
>   *          jdk.security.auth
>
> This test uses KDC.java which references a class inside
> sun.security.krb5.internal.ccache. Other tests in the same directory
> do have this package in their @modules tag (in fact, they share the
> same in TEST.properties) so if any of them is executed earlier,
> KDC.class will be generated and this test can use it. However, if this
> test is executed first, the compile will fail.
>
> Thanks
> Max

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR 8176715: sun/security/krb5/auto/HttpNegotiateServer.java does not compile

Sean Mullan
In reply to this post by Weijun Wang
Looks good.

--Sean

On 3/13/17 11:38 PM, Weijun Wang wrote:

> Please review the patch below:
>
> diff --git a/test/sun/security/krb5/auto/HttpNegotiateServer.java
> b/test/sun/security/krb5/auto/HttpNegotiateServer.java
> --- a/test/sun/security/krb5/auto/HttpNegotiateServer.java
> +++ b/test/sun/security/krb5/auto/HttpNegotiateServer.java
> @@ -28,6 +28,7 @@
>   *          java.security.jgss/sun.security.krb5.internal:+open
>   *          java.security.jgss/sun.security.jgss
>   *          java.security.jgss/sun.security.krb5:+open
> + *          java.security.jgss/sun.security.krb5.internal.ccache
>   *          java.security.jgss/sun.security.krb5.internal.crypto
>   *          java.security.jgss/sun.security.krb5.internal.ktab
>   *          jdk.security.auth
>
> This test uses KDC.java which references a class inside
> sun.security.krb5.internal.ccache. Other tests in the same directory do
> have this package in their @modules tag (in fact, they share the same in
> TEST.properties) so if any of them is executed earlier, KDC.class will
> be generated and this test can use it. However, if this test is executed
> first, the compile will fail.
>
> Thanks
> Max
Loading...