RFR 8177741: Fix hotspot tests to use --patch-module instead of -Xmodule

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RFR 8177741: Fix hotspot tests to use --patch-module instead of -Xmodule

harold seigel
Hi,

Please review this JDK-10 change to replace "-Xmodule" with
"--patch-module" in the
test/lib/jdk/test/lib/compiler/InMemoryJavaCompiler class and in
affected tests.  The option name "-Xmodule" was used briefly for java
and javac during JDK-9 development but was eventually replaced with
"--patch-module".  However, InMemoryJavaCompiler did not get updated to
use "--patch-module".

Open Webrevs:

    http://cr.openjdk.java.net/~hseigel/bug_8177741.test/webrev/

    http://cr.openjdk.java.net/~hseigel/bug_8177741.hs/webrev/

JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8177741

The change was tested with the JCK Lang and VM tests, the JTreg hotspot,
java/io, java/lang, java/util and other tests, the co-located NSK tests,
and with JPRT.

Thanks, Harold

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR 8177741: Fix hotspot tests to use --patch-module instead of -Xmodule

coleen.phillimore
This looks good.
Coleen

On 8/9/17 10:01 AM, harold seigel wrote:

> Hi,
>
> Please review this JDK-10 change to replace "-Xmodule" with
> "--patch-module" in the
> test/lib/jdk/test/lib/compiler/InMemoryJavaCompiler class and in
> affected tests.  The option name "-Xmodule" was used briefly for java
> and javac during JDK-9 development but was eventually replaced with
> "--patch-module".  However, InMemoryJavaCompiler did not get updated
> to use "--patch-module".
>
> Open Webrevs:
>
>    http://cr.openjdk.java.net/~hseigel/bug_8177741.test/webrev/
>
>    http://cr.openjdk.java.net/~hseigel/bug_8177741.hs/webrev/
>
> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8177741
>
> The change was tested with the JCK Lang and VM tests, the JTreg
> hotspot, java/io, java/lang, java/util and other tests, the co-located
> NSK tests, and with JPRT.
>
> Thanks, Harold
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR 8177741: Fix hotspot tests to use --patch-module instead of -Xmodule

harold seigel
Thanks Coleen!

Harold


On 8/10/2017 10:43 AM, [hidden email] wrote:

> This looks good.
> Coleen
>
> On 8/9/17 10:01 AM, harold seigel wrote:
>> Hi,
>>
>> Please review this JDK-10 change to replace "-Xmodule" with
>> "--patch-module" in the
>> test/lib/jdk/test/lib/compiler/InMemoryJavaCompiler class and in
>> affected tests.  The option name "-Xmodule" was used briefly for java
>> and javac during JDK-9 development but was eventually replaced with
>> "--patch-module".  However, InMemoryJavaCompiler did not get updated
>> to use "--patch-module".
>>
>> Open Webrevs:
>>
>>    http://cr.openjdk.java.net/~hseigel/bug_8177741.test/webrev/
>>
>>    http://cr.openjdk.java.net/~hseigel/bug_8177741.hs/webrev/
>>
>> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8177741
>>
>> The change was tested with the JCK Lang and VM tests, the JTreg
>> hotspot, java/io, java/lang, java/util and other tests, the
>> co-located NSK tests, and with JPRT.
>>
>> Thanks, Harold
>>
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR 8177741: Fix hotspot tests to use --patch-module instead of -Xmodule

George Triantafillou
In reply to this post by harold seigel
Hi Harold,

This looks good.

-George

On 8/9/2017 10:01 AM, harold seigel wrote:

> Hi,
>
> Please review this JDK-10 change to replace "-Xmodule" with
> "--patch-module" in the
> test/lib/jdk/test/lib/compiler/InMemoryJavaCompiler class and in
> affected tests.  The option name "-Xmodule" was used briefly for java
> and javac during JDK-9 development but was eventually replaced with
> "--patch-module".  However, InMemoryJavaCompiler did not get updated
> to use "--patch-module".
>
> Open Webrevs:
>
>    http://cr.openjdk.java.net/~hseigel/bug_8177741.test/webrev/
>
>    http://cr.openjdk.java.net/~hseigel/bug_8177741.hs/webrev/
>
> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8177741
>
> The change was tested with the JCK Lang and VM tests, the JTreg
> hotspot, java/io, java/lang, java/util and other tests, the co-located
> NSK tests, and with JPRT.
>
> Thanks, Harold
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR 8177741: Fix hotspot tests to use --patch-module instead of -Xmodule

harold seigel
Thanks George!

Harold


On 8/10/2017 10:48 AM, George Triantafillou wrote:

> Hi Harold,
>
> This looks good.
>
> -George
>
> On 8/9/2017 10:01 AM, harold seigel wrote:
>> Hi,
>>
>> Please review this JDK-10 change to replace "-Xmodule" with
>> "--patch-module" in the
>> test/lib/jdk/test/lib/compiler/InMemoryJavaCompiler class and in
>> affected tests.  The option name "-Xmodule" was used briefly for java
>> and javac during JDK-9 development but was eventually replaced with
>> "--patch-module".  However, InMemoryJavaCompiler did not get updated
>> to use "--patch-module".
>>
>> Open Webrevs:
>>
>>    http://cr.openjdk.java.net/~hseigel/bug_8177741.test/webrev/
>>
>>    http://cr.openjdk.java.net/~hseigel/bug_8177741.hs/webrev/
>>
>> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8177741
>>
>> The change was tested with the JCK Lang and VM tests, the JTreg
>> hotspot, java/io, java/lang, java/util and other tests, the
>> co-located NSK tests, and with JPRT.
>>
>> Thanks, Harold
>>
>

Loading...