RFR: 8177953: Rename TestGCBasher.run to TestGCBasher.main

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RFR: 8177953: Rename TestGCBasher.run to TestGCBasher.main

Erik Helin-2
Hi all,

when I added the GCBasher test I named then main method 'run' instead of
'main'. This small patch corrects that mistake.

Bug:
https://bugs.openjdk.java.net/browse/JDK-8177953

Patch:
http://cr.openjdk.java.net/~ehelin/8177953/00/

Testing:
- make run-test TEST=hotspot/test/gc/stress/gcbasher

Thanks,
Erik
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR: 8177953: Rename TestGCBasher.run to TestGCBasher.main

Per Liden
Hi Erik,

On 2017-04-03 11:54, Erik Helin wrote:

> Hi all,
>
> when I added the GCBasher test I named then main method 'run' instead of
> 'main'. This small patch corrects that mistake.
>
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8177953
>
> Patch:
> http://cr.openjdk.java.net/~ehelin/8177953/00/

Looks good!

/Per

>
> Testing:
> - make run-test TEST=hotspot/test/gc/stress/gcbasher
>
> Thanks,
> Erik
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR: 8177953: Rename TestGCBasher.run to TestGCBasher.main

Thomas Schatzl
In reply to this post by Erik Helin-2
Hi,

On Mon, 2017-04-03 at 11:54 +0200, Erik Helin wrote:

> Hi all,
>
> when I added the GCBasher test I named then main method 'run' instead
> of 
> 'main'. This small patch corrects that mistake.
>
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8177953
>
> Patch:
> http://cr.openjdk.java.net/~ehelin/8177953/00/
>
> Testing:
> - make run-test TEST=hotspot/test/gc/stress/gcbasher

  looks good.

Thomas

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR: 8177953: Rename TestGCBasher.run to TestGCBasher.main

Erik Helin-2
In reply to this post by Per Liden
On 04/03/2017 12:00 PM, Per Liden wrote:

> Hi Erik,
>
> On 2017-04-03 11:54, Erik Helin wrote:
>> Hi all,
>>
>> when I added the GCBasher test I named then main method 'run' instead of
>> 'main'. This small patch corrects that mistake.
>>
>> Bug:
>> https://bugs.openjdk.java.net/browse/JDK-8177953
>>
>> Patch:
>> http://cr.openjdk.java.net/~ehelin/8177953/00/
>
> Looks good!

Thanks for the quick review Per!
Erik

> /Per
>
>>
>> Testing:
>> - make run-test TEST=hotspot/test/gc/stress/gcbasher
>>
>> Thanks,
>> Erik
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR: 8177953: Rename TestGCBasher.run to TestGCBasher.main

Erik Helin-2
In reply to this post by Thomas Schatzl
On 04/03/2017 12:16 PM, Thomas Schatzl wrote:

> Hi,
>
> On Mon, 2017-04-03 at 11:54 +0200, Erik Helin wrote:
>> Hi all,
>>
>> when I added the GCBasher test I named then main method 'run' instead
>> of
>> 'main'. This small patch corrects that mistake.
>>
>> Bug:
>> https://bugs.openjdk.java.net/browse/JDK-8177953
>>
>> Patch:
>> http://cr.openjdk.java.net/~ehelin/8177953/00/
>>
>> Testing:
>> - make run-test TEST=hotspot/test/gc/stress/gcbasher
>
>   looks good.

Thanks Thomas for having a look!
Erik

> Thomas
>
Loading...