RFR: 8178048: [JVMCI] improve HotSpotResolvedJavaFieldImpl.hashCode()

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8178048: [JVMCI] improve HotSpotResolvedJavaFieldImpl.hashCode()

Christian Haeubl
Hi,

Please review this small JVMCI change that decreases the probability of hashcode collisions.

 
https://bugs.openjdk.java.net/browse/JDK-8178048
http://cr.openjdk.java.net/~chaeubl/8178048/webrev.001/
 
- Christian

Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8178048: [JVMCI] improve HotSpotResolvedJavaFieldImpl.hashCode()

Vladimir Kozlov
Looks good. What testing was done?

Thanks,
Vladimir

On 11/7/17 5:08 AM, Christian Haeubl wrote:

> |Hi,
>
> Please review this small JVMCI change that decreases the probability of hashcode collisions.|
> ||
> |https://bugs.openjdk.java.net/browse/JDK-8178048|
> |http://cr.openjdk.java.net/~chaeubl/8178048/webrev.001/|
> ||
> |- Christian
>
> |
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8178048: [JVMCI] improve HotSpotResolvedJavaFieldImpl.hashCode()

Christian Haeubl
Graal unit tests & Graal bootstrapping. Besides that, the same code
change is also already active for a few month in the JDK 8 that is the
foundation for GraalVM.

- Christian


Am 07.11.2017 um 19:49 schrieb Vladimir Kozlov:

> Looks good. What testing was done?
>
> Thanks,
> Vladimir
>
> On 11/7/17 5:08 AM, Christian Haeubl wrote:
>> |Hi,
>>
>> Please review this small JVMCI change that decreases the probability
>> of hashcode collisions.|
>> ||
>> |https://bugs.openjdk.java.net/browse/JDK-8178048|
>> |http://cr.openjdk.java.net/~chaeubl/8178048/webrev.001/|
>> ||
>> |- Christian
>>
>> |

Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8178048: [JVMCI] improve HotSpotResolvedJavaFieldImpl.hashCode()

Vladimir Kozlov
Good. Thank you.

Vladimir

On 11/8/17 1:17 AM, Christian Haeubl wrote:

> Graal unit tests & Graal bootstrapping. Besides that, the same code change is also already active for a few month in the
> JDK 8 that is the foundation for GraalVM.
>
> - Christian
>
>
> Am 07.11.2017 um 19:49 schrieb Vladimir Kozlov:
>> Looks good. What testing was done?
>>
>> Thanks,
>> Vladimir
>>
>> On 11/7/17 5:08 AM, Christian Haeubl wrote:
>>> |Hi,
>>>
>>> Please review this small JVMCI change that decreases the probability of hashcode collisions.|
>>> ||
>>> |https://bugs.openjdk.java.net/browse/JDK-8178048|
>>> |http://cr.openjdk.java.net/~chaeubl/8178048/webrev.001/|
>>> ||
>>> |- Christian
>>>
>>> |
>