RFR 8178795: krb5 Basic.java test should be basic

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RFR 8178795: krb5 Basic.java test should be basic

Weijun Wang
Please take a review at

    http://cr.openjdk.java.net/~weijun/8178795/webrev.00/

Basic.java was reverted to what it was 5 years ago and an extra test
ModuleName.java is created to cover what Basic.java does now, but
simplified because it does not need any real communication between
client/server/backend.

After this change Basic.java becomes basic again so it's easy to create
new tests based on it.

Thanks
Max
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR 8178795: krb5 Basic.java test should be basic

Xuelei Fan-2
Looks fine to me.

Xuelei

On 4/13/2017 11:51 PM, Weijun Wang wrote:

> Please take a review at
>
>    http://cr.openjdk.java.net/~weijun/8178795/webrev.00/
>
> Basic.java was reverted to what it was 5 years ago and an extra test
> ModuleName.java is created to cover what Basic.java does now, but
> simplified because it does not need any real communication between
> client/server/backend.
>
> After this change Basic.java becomes basic again so it's easy to create
> new tests based on it.
>
> Thanks
> Max
Loading...