RFR 8178915: Minor update to the PooledConnection javadoc

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR 8178915: Minor update to the PooledConnection javadoc

Lance Andersen
Hi all,

This RFR makes a minor update to the PooledConnection javadoc.  The CCC has been approved.  

Here is the diff:

———————
$ hg diff
diff -r 9ba6760481a8 src/java.sql/share/classes/javax/sql/PooledConnection.java
--- a/src/java.sql/share/classes/javax/sql/PooledConnection.java Sat Apr 15 16:54:33 2017 -0400
+++ b/src/java.sql/share/classes/javax/sql/PooledConnection.java Tue Apr 18 14:50:44 2017 -0400
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2000, 2015, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2000, 2017, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -69,8 +69,9 @@
  * <p>
  * If the connection pool manager wraps or provides a proxy to the logical
  * handle returned from a call to {@code PoolConnection.getConnection}, the pool
- * manager must do
- * one of the following when the application calls {@code Connection.close}:
+ * manager must do one of the following when the connection pool manager
+ * closes or returns the {@code PooledConnection} to the pool in response to
+ * the application calling {@code Connection.close}:
  * <ul>
  * <li>call {@code endRequest} on the logical {@code Connection} handle
  * <li>call {@code close} on the logical {@code Connection} handle
ljanders-mac:src ljanders$
——————————

Best
Lance
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
[hidden email] <mailto:[hidden email]>



Reply | Threaded
Open this post in threaded view
|

Re: RFR 8178915: Minor update to the PooledConnection javadoc

huizhe wang
Hi Lance,

The changes look good to me.

-Joe

On 4/20/2017 6:40 AM, Lance Andersen wrote:

> Hi all,
>
> This RFR makes a minor update to the PooledConnection javadoc.  The CCC has been approved.
>
> Here is the diff:
>
> ———————
> $ hg diff
> diff -r 9ba6760481a8 src/java.sql/share/classes/javax/sql/PooledConnection.java
> --- a/src/java.sql/share/classes/javax/sql/PooledConnection.java Sat Apr 15 16:54:33 2017 -0400
> +++ b/src/java.sql/share/classes/javax/sql/PooledConnection.java Tue Apr 18 14:50:44 2017 -0400
> @@ -1,5 +1,5 @@
>   /*
> - * Copyright (c) 2000, 2015, Oracle and/or its affiliates. All rights reserved.
> + * Copyright (c) 2000, 2017, Oracle and/or its affiliates. All rights reserved.
>    * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>    *
>    * This code is free software; you can redistribute it and/or modify it
> @@ -69,8 +69,9 @@
>    * <p>
>    * If the connection pool manager wraps or provides a proxy to the logical
>    * handle returned from a call to {@code PoolConnection.getConnection}, the pool
> - * manager must do
> - * one of the following when the application calls {@code Connection.close}:
> + * manager must do one of the following when the connection pool manager
> + * closes or returns the {@code PooledConnection} to the pool in response to
> + * the application calling {@code Connection.close}:
>    * <ul>
>    * <li>call {@code endRequest} on the logical {@code Connection} handle
>    * <li>call {@code close} on the logical {@code Connection} handle
> ljanders-mac:src ljanders$
> ——————————
>
> Best
> Lance
>   <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>   <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>   <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> [hidden email] <mailto:[hidden email]>
>
>
>