RFR: 8180768: Deprecate -XX:+/-MonitorInUseLists option

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RFR: 8180768: Deprecate -XX:+/-MonitorInUseLists option

Roman Kennke-6
Hi all,

please review this trivial change to deprecate MonitorInUseLists (as
discussed earlier here on this list).

http://cr.openjdk.java.net/~rkennke/8180768/webrev.00/
<http://cr.openjdk.java.net/%7Erkennke/8180768/webrev.00/>

Bug entry:

https://bugs.openjdk.java.net/browse/JDK-8180768

CSR:

https://bugs.openjdk.java.net/browse/JDK-8180929

Thanks,
Roman

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR: 8180768: Deprecate -XX:+/-MonitorInUseLists option

Zhengyu Gu-2
Looks good.

-Zhengyu

On 07/25/2017 06:10 AM, Roman Kennke wrote:

> Hi all,
>
> please review this trivial change to deprecate MonitorInUseLists (as
> discussed earlier here on this list).
>
> http://cr.openjdk.java.net/~rkennke/8180768/webrev.00/
> <http://cr.openjdk.java.net/%7Erkennke/8180768/webrev.00/>
>
> Bug entry:
>
> https://bugs.openjdk.java.net/browse/JDK-8180768
>
> CSR:
>
> https://bugs.openjdk.java.net/browse/JDK-8180929
>
> Thanks,
> Roman
>
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR: 8180768: Deprecate -XX:+/-MonitorInUseLists option

coleen.phillimore
In reply to this post by Roman Kennke-6

This looks good.  I can sponsor this for you.
Coleen

On 7/25/17 6:10 AM, Roman Kennke wrote:

> Hi all,
>
> please review this trivial change to deprecate MonitorInUseLists (as
> discussed earlier here on this list).
>
> http://cr.openjdk.java.net/~rkennke/8180768/webrev.00/
> <http://cr.openjdk.java.net/%7Erkennke/8180768/webrev.00/>
>
> Bug entry:
>
> https://bugs.openjdk.java.net/browse/JDK-8180768
>
> CSR:
>
> https://bugs.openjdk.java.net/browse/JDK-8180929
>
> Thanks,
> Roman
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR: 8180768: Deprecate -XX:+/-MonitorInUseLists option

Daniel D. Daugherty
In reply to this post by Roman Kennke-6
On 7/25/17 4:10 AM, Roman Kennke wrote:
> Hi all,
>
> please review this trivial change to deprecate MonitorInUseLists (as
> discussed earlier here on this list).
>
> http://cr.openjdk.java.net/~rkennke/8180768/webrev.00/
> <http://cr.openjdk.java.net/%7Erkennke/8180768/webrev.00/>

src/share/vm/runtime/arguments.cpp
     No comments.

Thumbs up! This change qualifies for the HotSpot Trivial Change
rule. There are already plenty of reviewers, but there's no need
to wait 24 hours.

Dan


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR: 8180768: Deprecate -XX:+/-MonitorInUseLists option

coleen.phillimore
In reply to this post by coleen.phillimore
This is already checked in but the bug is still open.   Was this a raw push?

Coleen

On 7/25/17 10:55 AM, [hidden email] wrote:

>
> This looks good.  I can sponsor this for you.
> Coleen
>
> On 7/25/17 6:10 AM, Roman Kennke wrote:
>> Hi all,
>>
>> please review this trivial change to deprecate MonitorInUseLists (as
>> discussed earlier here on this list).
>>
>> http://cr.openjdk.java.net/~rkennke/8180768/webrev.00/
>> <http://cr.openjdk.java.net/%7Erkennke/8180768/webrev.00/>
>>
>> Bug entry:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8180768
>>
>> CSR:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8180929
>>
>> Thanks,
>> Roman
>>
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR: 8180768: Deprecate -XX:+/-MonitorInUseLists option

Roman Kennke-6
I think I made a mistake. I put the CSR ID in the commit msg instead of
the bug.

Roman

Am 14.08.2017 um 17:13 schrieb [hidden email]:

> This is already checked in but the bug is still open.   Was this a raw
> push?
>
> Coleen
>
> On 7/25/17 10:55 AM, [hidden email] wrote:
>>
>> This looks good.  I can sponsor this for you.
>> Coleen
>>
>> On 7/25/17 6:10 AM, Roman Kennke wrote:
>>> Hi all,
>>>
>>> please review this trivial change to deprecate MonitorInUseLists (as
>>> discussed earlier here on this list).
>>>
>>> http://cr.openjdk.java.net/~rkennke/8180768/webrev.00/
>>> <http://cr.openjdk.java.net/%7Erkennke/8180768/webrev.00/>
>>>
>>> Bug entry:
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8180768
>>>
>>> CSR:
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8180929
>>>
>>> Thanks,
>>> Roman
>>>
>>
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR: 8180768: Deprecate -XX:+/-MonitorInUseLists option

coleen.phillimore


On 8/14/17 11:17 AM, Roman Kennke wrote:
> I think I made a mistake. I put the CSR ID in the commit msg instead of
> the bug.

Ah, ok.  I marked it as closed.  I guess JPRT doesn't put the changeset
in the CSR issue.

Coleen

>
> Roman
>
> Am 14.08.2017 um 17:13 schrieb [hidden email]:
>> This is already checked in but the bug is still open.   Was this a raw
>> push?
>>
>> Coleen
>>
>> On 7/25/17 10:55 AM, [hidden email] wrote:
>>> This looks good.  I can sponsor this for you.
>>> Coleen
>>>
>>> On 7/25/17 6:10 AM, Roman Kennke wrote:
>>>> Hi all,
>>>>
>>>> please review this trivial change to deprecate MonitorInUseLists (as
>>>> discussed earlier here on this list).
>>>>
>>>> http://cr.openjdk.java.net/~rkennke/8180768/webrev.00/
>>>> <http://cr.openjdk.java.net/%7Erkennke/8180768/webrev.00/>
>>>>
>>>> Bug entry:
>>>>
>>>> https://bugs.openjdk.java.net/browse/JDK-8180768
>>>>
>>>> CSR:
>>>>
>>>> https://bugs.openjdk.java.net/browse/JDK-8180929
>>>>
>>>> Thanks,
>>>> Roman
>>>>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR: 8180768: Deprecate -XX:+/-MonitorInUseLists option

Daniel D. Daugherty
I've updated the bug to show it is fixed in "team". I've also
fabricated an entry that looks like what "HG Updates" would
add for those bug parser scripts...

I'll try to keep an eye on this one when it hits JDK10/jdk10.
It will need another manual update...

Dan


On 8/14/17 9:30 AM, [hidden email] wrote:

>
>
> On 8/14/17 11:17 AM, Roman Kennke wrote:
>> I think I made a mistake. I put the CSR ID in the commit msg instead of
>> the bug.
>
> Ah, ok.  I marked it as closed.  I guess JPRT doesn't put the
> changeset in the CSR issue.
>
> Coleen
>
>>
>> Roman
>>
>> Am 14.08.2017 um 17:13 schrieb [hidden email]:
>>> This is already checked in but the bug is still open.   Was this a raw
>>> push?
>>>
>>> Coleen
>>>
>>> On 7/25/17 10:55 AM, [hidden email] wrote:
>>>> This looks good.  I can sponsor this for you.
>>>> Coleen
>>>>
>>>> On 7/25/17 6:10 AM, Roman Kennke wrote:
>>>>> Hi all,
>>>>>
>>>>> please review this trivial change to deprecate MonitorInUseLists (as
>>>>> discussed earlier here on this list).
>>>>>
>>>>> http://cr.openjdk.java.net/~rkennke/8180768/webrev.00/
>>>>> <http://cr.openjdk.java.net/%7Erkennke/8180768/webrev.00/>
>>>>>
>>>>> Bug entry:
>>>>>
>>>>> https://bugs.openjdk.java.net/browse/JDK-8180768
>>>>>
>>>>> CSR:
>>>>>
>>>>> https://bugs.openjdk.java.net/browse/JDK-8180929
>>>>>
>>>>> Thanks,
>>>>> Roman
>>>>>
>
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR: 8180768: Deprecate -XX:+/-MonitorInUseLists option

coleen.phillimore


On 8/14/17 12:01 PM, Daniel D. Daugherty wrote:
> I've updated the bug to show it is fixed in "team". I've also
> fabricated an entry that looks like what "HG Updates" would
> add for those bug parser scripts...
>
> I'll try to keep an eye on this one when it hits JDK10/jdk10.
> It will need another manual update...

Thanks, Dan!
Coleen

>
> Dan
>
>
> On 8/14/17 9:30 AM, [hidden email] wrote:
>>
>>
>> On 8/14/17 11:17 AM, Roman Kennke wrote:
>>> I think I made a mistake. I put the CSR ID in the commit msg instead of
>>> the bug.
>>
>> Ah, ok.  I marked it as closed.  I guess JPRT doesn't put the
>> changeset in the CSR issue.
>>
>> Coleen
>>
>>>
>>> Roman
>>>
>>> Am 14.08.2017 um 17:13 schrieb [hidden email]:
>>>> This is already checked in but the bug is still open.   Was this a raw
>>>> push?
>>>>
>>>> Coleen
>>>>
>>>> On 7/25/17 10:55 AM, [hidden email] wrote:
>>>>> This looks good.  I can sponsor this for you.
>>>>> Coleen
>>>>>
>>>>> On 7/25/17 6:10 AM, Roman Kennke wrote:
>>>>>> Hi all,
>>>>>>
>>>>>> please review this trivial change to deprecate MonitorInUseLists (as
>>>>>> discussed earlier here on this list).
>>>>>>
>>>>>> http://cr.openjdk.java.net/~rkennke/8180768/webrev.00/
>>>>>> <http://cr.openjdk.java.net/%7Erkennke/8180768/webrev.00/>
>>>>>>
>>>>>> Bug entry:
>>>>>>
>>>>>> https://bugs.openjdk.java.net/browse/JDK-8180768
>>>>>>
>>>>>> CSR:
>>>>>>
>>>>>> https://bugs.openjdk.java.net/browse/JDK-8180929
>>>>>>
>>>>>> Thanks,
>>>>>> Roman
>>>>>>
>>
>>
>

Loading...