RFR 8185806: Quarantine test JdbExprTest.sh on 32-bit Windows

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RFR 8185806: Quarantine test JdbExprTest.sh on 32-bit Windows

harold seigel
Hi,

Please review this small change to quarantine test
jdk/test/com/sun/jdi/JdbExprTest.sh on 32-bit Windows systems.

Open Webrev:
http://cr.openjdk.java.net/~hseigel/bug_8185806/webrev/index.html

JBS Bug Sub-task: https://bugs.openjdk.java.net/browse/JDK-8185806

Thanks, Harold

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR 8185806: Quarantine test JdbExprTest.sh on 32-bit Windows

coleen.phillimore
Looks good.  I think this should be a trivial change.
Coleen

On 8/3/17 3:03 PM, harold seigel wrote:

> Hi,
>
> Please review this small change to quarantine test
> jdk/test/com/sun/jdi/JdbExprTest.sh on 32-bit Windows systems.
>
> Open Webrev:
> http://cr.openjdk.java.net/~hseigel/bug_8185806/webrev/index.html
>
> JBS Bug Sub-task: https://bugs.openjdk.java.net/browse/JDK-8185806
>
> Thanks, Harold
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR 8185806: Quarantine test JdbExprTest.sh on 32-bit Windows

harold seigel
Thanks Coleen!

Harold


On 8/3/2017 3:04 PM, [hidden email] wrote:

> Looks good.  I think this should be a trivial change.
> Coleen
>
> On 8/3/17 3:03 PM, harold seigel wrote:
>> Hi,
>>
>> Please review this small change to quarantine test
>> jdk/test/com/sun/jdi/JdbExprTest.sh on 32-bit Windows systems.
>>
>> Open Webrev:
>> http://cr.openjdk.java.net/~hseigel/bug_8185806/webrev/index.html
>>
>> JBS Bug Sub-task: https://bugs.openjdk.java.net/browse/JDK-8185806
>>
>> Thanks, Harold
>>
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR 8185806: Quarantine test JdbExprTest.sh on 32-bit Windows

harold seigel
In reply to this post by harold seigel
Hi Serguei,

Dan pointed out that the test failed on both 64-bit and 32-bit Windows
platforms so I'll be sending out a new webrev without a
"(sun.arch.data.model != "32")" clause in the @requires statement.

Thanks, Harold


On 8/3/2017 3:15 PM, [hidden email] wrote:

> Hi Harold,
>
> +# @requires (sun.arch.data.model != "32") & (os.family != "windows")
> Should the '&' be replaced with '|' ?
>
> Thanks,
> Serguei
>
>
> On 8/3/17 12:03, harold seigel wrote:
>> Hi,
>>
>> Please review this small change to quarantine test
>> jdk/test/com/sun/jdi/JdbExprTest.sh on 32-bit Windows systems.
>>
>> Open Webrev:
>> http://cr.openjdk.java.net/~hseigel/bug_8185806/webrev/index.html
>>
>> JBS Bug Sub-task: https://bugs.openjdk.java.net/browse/JDK-8185806
>>
>> Thanks, Harold
>>
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR 8185806: Quarantine test JdbExprTest.sh on 32-bit Windows

coleen.phillimore


On 8/3/17 3:45 PM, harold seigel wrote:
> Hi Serguei,
>
> Dan pointed out that the test failed on both 64-bit and 32-bit Windows
> platforms so I'll be sending out a new webrev without a
> "(sun.arch.data.model != "32")" clause in the @requires statement.

Even better.  Sorry for the cursory review last time.
Coleen

>
> Thanks, Harold
>
>
> On 8/3/2017 3:15 PM, [hidden email] wrote:
>> Hi Harold,
>>
>> +# @requires (sun.arch.data.model != "32") & (os.family != "windows")
>> Should the '&' be replaced with '|' ?
>>
>> Thanks,
>> Serguei
>>
>>
>> On 8/3/17 12:03, harold seigel wrote:
>>> Hi,
>>>
>>> Please review this small change to quarantine test
>>> jdk/test/com/sun/jdi/JdbExprTest.sh on 32-bit Windows systems.
>>>
>>> Open Webrev:
>>> http://cr.openjdk.java.net/~hseigel/bug_8185806/webrev/index.html
>>>
>>> JBS Bug Sub-task: https://bugs.openjdk.java.net/browse/JDK-8185806
>>>
>>> Thanks, Harold
>>>
>>
>

Loading...