RFR: 8186306: Remove pisces from Java2D sources + build.

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8186306: Remove pisces from Java2D sources + build.

Phil Race
bug: https://bugs.openjdk.java.net/browse/JDK-8186306
webrev: http://cr.openjdk.java.net/~prr/8186306/

This fix removes the pisces rasterizer code since it is superseded by
marlin.

In addition it removes the (always) un-used Jules code from the Xrender
pipe-line.

This code has never been enabled as it relied on a special version of Cairo.

It could have been kept by making MarlinRenderingEngine non-final and
extending that instead, but after discussion with Clemens (author of the
xrender pipeline) it is decided to remove it too.

I have built on all platforms and tested on Linux with Xrender to make sure
there was no breakage from this removal.

Additionally I have re-moved "pisces" directories from the test hierarchy
and moved the tests there under the marlin  directory as seemed appropriate.
These tests are all valid as tests for marlin too.

One test had a system property to invoke pisces removed.

-phil
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8186306: Remove pisces from Java2D sources + build.

Mario Torre-6
On Wed, Nov 8, 2017 at 12:08 AM, Philip Race <[hidden email]> wrote:

> bug: https://bugs.openjdk.java.net/browse/JDK-8186306
> webrev: http://cr.openjdk.java.net/~prr/8186306/
>
> This fix removes the pisces rasterizer code since it is superseded by
> marlin.
>
> In addition it removes the (always) un-used Jules code from the Xrender
> pipe-line.
>
> This code has never been enabled as it relied on a special version of Cairo.
>
> It could have been kept by making MarlinRenderingEngine non-final and
> extending that instead, but after discussion with Clemens (author of the
> xrender pipeline) it is decided to remove it too.
>
> I have built on all platforms and tested on Linux with Xrender to make sure
> there was no breakage from this removal.
>
> Additionally I have re-moved "pisces" directories from the test hierarchy
> and moved the tests there under the marlin  directory as seemed appropriate.
> These tests are all valid as tests for marlin too.
>
> One test had a system property to invoke pisces removed.

Hi Phil,

I'm not an official reviewer (maybe I should be at some point).

The patch looks fine, I tested it locally too and everything seems
fine, at least I could not spot any issues, everything compiles and
appear to work without breakages.

Cheers,
Mario
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8186306: Remove pisces from Java2D sources + build.

Sergey Bylokhov
In reply to this post by Phil Race
Looks fine.
I guess we should do same cleanup in the closed repo as well.

On 07/11/2017 15:08, Philip Race wrote:

> bug: https://bugs.openjdk.java.net/browse/JDK-8186306
> webrev: http://cr.openjdk.java.net/~prr/8186306/
>
> This fix removes the pisces rasterizer code since it is superseded by
> marlin.
>
> In addition it removes the (always) un-used Jules code from the Xrender
> pipe-line.
>
> This code has never been enabled as it relied on a special version of
> Cairo.
>
> It could have been kept by making MarlinRenderingEngine non-final and
> extending that instead, but after discussion with Clemens (author of the
> xrender pipeline) it is decided to remove it too.
>
> I have built on all platforms and tested on Linux with Xrender to make sure
> there was no breakage from this removal.
>
> Additionally I have re-moved "pisces" directories from the test hierarchy
> and moved the tests there under the marlinĀ  directory as seemed
> appropriate.
> These tests are all valid as tests for marlin too.
>
> One test had a system property to invoke pisces removed.
>
> -phil


--
Best regards, Sergey.