RFR: 8187402: UnknownOopException is occurred on Stack Memory window in HSDB

classic Classic list List threaded Threaded
13 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8187402: UnknownOopException is occurred on Stack Memory window in HSDB

Yasumasa Suenaga-4
Hi all,

This review request is a part of [1].


JBS:
  https://bugs.openjdk.java.net/browse/JDK-8187402

webrev:
  http://cr.openjdk.java.net/~ysuenaga/JDK-8187402/webrev.00/


I cannot access JPRT. So I need a sponsor.


Thanks,

Yasumasa


[1] http://mail.openjdk.java.net/pipermail/serviceability-dev/2017-September/021821.html
Reply | Threaded
Open this post in threaded view
|

PING: RFR: 8187402: UnknownOopException is occurred on Stack Memory window in HSDB

Yasumasa Suenaga-4
PING:

Have you checked this issue?

>    http://cr.openjdk.java.net/~ysuenaga/JDK-8187402/webrev.00/


Yasumasa


On 2017/09/11 11:17, Yasumasa Suenaga wrote:

> Hi all,
>
> This review request is a part of [1].
>
>
> JBS:
>    https://bugs.openjdk.java.net/browse/JDK-8187402
>
> webrev:
>    http://cr.openjdk.java.net/~ysuenaga/JDK-8187402/webrev.00/
>
>
> I cannot access JPRT. So I need a sponsor.
>
>
> Thanks,
>
> Yasumasa
>
>
> [1] http://mail.openjdk.java.net/pipermail/serviceability-dev/2017-September/021821.html
>
Reply | Threaded
Open this post in threaded view
|

RFR: 8187402: UnknownOopException is occurred on Stack Memory window in HSDB

Yasumasa Suenaga-4
Hi all,

I uploaded new webrev to be adapted to jdk10/hs:

   http://cr.openjdk.java.net/~ysuenaga/JDK-8187402/webrev.01/


Thanks,

Yasumasa


On 2017/09/21 7:47, Yasumasa Suenaga wrote:

> PING:
>
> Have you checked this issue?
>
>>    http://cr.openjdk.java.net/~ysuenaga/JDK-8187402/webrev.00/
>
>
> Yasumasa
>
>
> On 2017/09/11 11:17, Yasumasa Suenaga wrote:
>> Hi all,
>>
>> This review request is a part of [1].
>>
>>
>> JBS:
>>    https://bugs.openjdk.java.net/browse/JDK-8187402
>>
>> webrev:
>>    http://cr.openjdk.java.net/~ysuenaga/JDK-8187402/webrev.00/
>>
>>
>> I cannot access JPRT. So I need a sponsor.
>>
>>
>> Thanks,
>>
>> Yasumasa
>>
>>
>> [1] http://mail.openjdk.java.net/pipermail/serviceability-dev/2017-September/021821.html
>>
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8187402: UnknownOopException is occurred on Stack Memory window in HSDB

Jini George
Hi Yasumasa,

The changes look fine, but please do include the test case also for
this. In general, it would be great if you could provide test cases also
along with the code changes while sending for review.

Thank you,
Jini.

On 9/26/2017 8:19 PM, Yasumasa Suenaga wrote:

> Hi all,
>
> I uploaded new webrev to be adapted to jdk10/hs:
>
>    http://cr.openjdk.java.net/~ysuenaga/JDK-8187402/webrev.01/
>
>
> Thanks,
>
> Yasumasa
>
>
> On 2017/09/21 7:47, Yasumasa Suenaga wrote:
>> PING:
>>
>> Have you checked this issue?
>>
>>>    http://cr.openjdk.java.net/~ysuenaga/JDK-8187402/webrev.00/
>>
>>
>> Yasumasa
>>
>>
>> On 2017/09/11 11:17, Yasumasa Suenaga wrote:
>>> Hi all,
>>>
>>> This review request is a part of [1].
>>>
>>>
>>> JBS:
>>>    https://bugs.openjdk.java.net/browse/JDK-8187402
>>>
>>> webrev:
>>>    http://cr.openjdk.java.net/~ysuenaga/JDK-8187402/webrev.00/
>>>
>>>
>>> I cannot access JPRT. So I need a sponsor.
>>>
>>>
>>> Thanks,
>>>
>>> Yasumasa
>>>
>>>
>>> [1]
>>> http://mail.openjdk.java.net/pipermail/serviceability-dev/2017-September/021821.html 
>>>
>>>
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8187402: UnknownOopException is occurred on Stack Memory window in HSDB

Yasumasa Suenaga-4
Hi Jini,

IMHO this issue (JDK-8187402) and JDK-8187403 are too difficult to crate test cases because they are problems in Stack Memory window in HSDB.
Can we add noreg-hard label to JBS?


Thanks,

Yasumasa


On 2017/09/27 2:36, Jini George wrote:

> Hi Yasumasa,
>
> The changes look fine, but please do include the test case also for
> this. In general, it would be great if you could provide test cases also
> along with the code changes while sending for review.
>
> Thank you,
> Jini.
>
> On 9/26/2017 8:19 PM, Yasumasa Suenaga wrote:
>> Hi all,
>>
>> I uploaded new webrev to be adapted to jdk10/hs:
>>
>>  ? http://cr.openjdk.java.net/~ysuenaga/JDK-8187402/webrev.01/
>>
>>
>> Thanks,
>>
>> Yasumasa
>>
>>
>> On 2017/09/21 7:47, Yasumasa Suenaga wrote:
>>> PING:
>>>
>>> Have you checked this issue?
>>>
>>>> ?? http://cr.openjdk.java.net/~ysuenaga/JDK-8187402/webrev.00/
>>>
>>>
>>> Yasumasa
>>>
>>>
>>> On 2017/09/11 11:17, Yasumasa Suenaga wrote:
>>>> Hi all,
>>>>
>>>> This review request is a part of [1].
>>>>
>>>>
>>>> JBS:
>>>> ?? https://bugs.openjdk.java.net/browse/JDK-8187402
>>>>
>>>> webrev:
>>>> ?? http://cr.openjdk.java.net/~ysuenaga/JDK-8187402/webrev.00/
>>>>
>>>>
>>>> I cannot access JPRT. So I need a sponsor.
>>>>
>>>>
>>>> Thanks,
>>>>
>>>> Yasumasa
>>>>
>>>>
>>>> [1]
>>>> http://mail.openjdk.java.net/pipermail/serviceability-dev/2017-September/021821.html
>>>>
>>>>
>
Reply | Threaded
Open this post in threaded view
|

Re: PING: RFR: 8187402: UnknownOopException is occurred on Stack Memory window in HSDB

serguei.spitsyn@oracle.com
In reply to this post by Yasumasa Suenaga-4
Hi Yasumasa,

The fix looks Ok to me.
Could you, please, add the noreg-hard label and a good description how
to run the hsdb and reproduce it?

Thanks,
Serguei


On 9/20/17 15:47, Yasumasa Suenaga wrote:

> PING:
>
> Have you checked this issue?
>
>> http://cr.openjdk.java.net/~ysuenaga/JDK-8187402/webrev.00/
>
>
> Yasumasa
>
>
> On 2017/09/11 11:17, Yasumasa Suenaga wrote:
>> Hi all,
>>
>> This review request is a part of [1].
>>
>>
>> JBS:
>>    https://bugs.openjdk.java.net/browse/JDK-8187402
>>
>> webrev:
>>    http://cr.openjdk.java.net/~ysuenaga/JDK-8187402/webrev.00/
>>
>>
>> I cannot access JPRT. So I need a sponsor.
>>
>>
>> Thanks,
>>
>> Yasumasa
>>
>>
>> [1]
>> http://mail.openjdk.java.net/pipermail/serviceability-dev/2017-September/021821.html
>>

Reply | Threaded
Open this post in threaded view
|

Re: PING: RFR: 8187402: UnknownOopException is occurred on Stack Memory window in HSDB

Yasumasa Suenaga-4
Hi Serguei,

I added noreg-hard label and details how to reproduce to JBS.

  https://bugs.openjdk.java.net/browse/JDK-8187402


Thanks,

Yasumasa



2017-09-27 8:31 GMT+09:00 [hidden email]
<[hidden email]>:

> Hi Yasumasa,
>
> The fix looks Ok to me.
> Could you, please, add the noreg-hard label and a good description how to
> run the hsdb and reproduce it?
>
> Thanks,
> Serguei
>
>
>
> On 9/20/17 15:47, Yasumasa Suenaga wrote:
>>
>> PING:
>>
>> Have you checked this issue?
>>
>>> http://cr.openjdk.java.net/~ysuenaga/JDK-8187402/webrev.00/
>>
>>
>>
>> Yasumasa
>>
>>
>> On 2017/09/11 11:17, Yasumasa Suenaga wrote:
>>>
>>> Hi all,
>>>
>>> This review request is a part of [1].
>>>
>>>
>>> JBS:
>>>    https://bugs.openjdk.java.net/browse/JDK-8187402
>>>
>>> webrev:
>>>    http://cr.openjdk.java.net/~ysuenaga/JDK-8187402/webrev.00/
>>>
>>>
>>> I cannot access JPRT. So I need a sponsor.
>>>
>>>
>>> Thanks,
>>>
>>> Yasumasa
>>>
>>>
>>> [1]
>>> http://mail.openjdk.java.net/pipermail/serviceability-dev/2017-September/021821.html
>>>
>
Reply | Threaded
Open this post in threaded view
|

RE: RFR: 8187402: UnknownOopException is occurred on Stack Memory window in HSDB

Sharath Ballal
In reply to this post by Yasumasa Suenaga-4
Hi Yasumasa,
We don't have any tests for HSDB (because it is gui).  
If the problem recreates in CLHSDB you can write a testcase, if not you can add noreg-hard label.


Thanks,
Sharath


-----Original Message-----
From: Yasumasa Suenaga [mailto:[hidden email]]
Sent: Wednesday, September 27, 2017 4:11 AM
To: Jini George
Cc: [hidden email]
Subject: Re: RFR: 8187402: UnknownOopException is occurred on Stack Memory window in HSDB

Hi Jini,

IMHO this issue (JDK-8187402) and JDK-8187403 are too difficult to crate test cases because they are problems in Stack Memory window in HSDB.
Can we add noreg-hard label to JBS?


Thanks,

Yasumasa


On 2017/09/27 2:36, Jini George wrote:

> Hi Yasumasa,
>
> The changes look fine, but please do include the test case also for
> this. In general, it would be great if you could provide test cases
> also along with the code changes while sending for review.
>
> Thank you,
> Jini.
>
> On 9/26/2017 8:19 PM, Yasumasa Suenaga wrote:
>> Hi all,
>>
>> I uploaded new webrev to be adapted to jdk10/hs:
>>
>>  ? http://cr.openjdk.java.net/~ysuenaga/JDK-8187402/webrev.01/
>>
>>
>> Thanks,
>>
>> Yasumasa
>>
>>
>> On 2017/09/21 7:47, Yasumasa Suenaga wrote:
>>> PING:
>>>
>>> Have you checked this issue?
>>>
>>>> ?? http://cr.openjdk.java.net/~ysuenaga/JDK-8187402/webrev.00/
>>>
>>>
>>> Yasumasa
>>>
>>>
>>> On 2017/09/11 11:17, Yasumasa Suenaga wrote:
>>>> Hi all,
>>>>
>>>> This review request is a part of [1].
>>>>
>>>>
>>>> JBS:
>>>> ?? https://bugs.openjdk.java.net/browse/JDK-8187402
>>>>
>>>> webrev:
>>>> ?? http://cr.openjdk.java.net/~ysuenaga/JDK-8187402/webrev.00/
>>>>
>>>>
>>>> I cannot access JPRT. So I need a sponsor.
>>>>
>>>>
>>>> Thanks,
>>>>
>>>> Yasumasa
>>>>
>>>>
>>>> [1]
>>>> http://mail.openjdk.java.net/pipermail/serviceability-dev/2017-Sept
>>>> ember/021821.html
>>>>
>>>>
>
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8187402: UnknownOopException is occurred on Stack Memory window in HSDB

Yasumasa Suenaga-4
Hi Sharath,

I've reported 4 issues of HSDB.

I added noreg-hard to 8187401, 8187402, 8187403.
But 8175816 is testable so I've included testcase in webrev.


Thanks,

Yasumasa


On 2017/09/28 0:12, Sharath Ballal wrote:

> Hi Yasumasa,
> We don't have any tests for HSDB (because it is gui).
> If the problem recreates in CLHSDB you can write a testcase, if not you can add noreg-hard label.
>
>
> Thanks,
> Sharath
>
>
> -----Original Message-----
> From: Yasumasa Suenaga [mailto:[hidden email]]
> Sent: Wednesday, September 27, 2017 4:11 AM
> To: Jini George
> Cc: [hidden email]
> Subject: Re: RFR: 8187402: UnknownOopException is occurred on Stack Memory window in HSDB
>
> Hi Jini,
>
> IMHO this issue (JDK-8187402) and JDK-8187403 are too difficult to crate test cases because they are problems in Stack Memory window in HSDB.
> Can we add noreg-hard label to JBS?
>
>
> Thanks,
>
> Yasumasa
>
>
> On 2017/09/27 2:36, Jini George wrote:
>> Hi Yasumasa,
>>
>> The changes look fine, but please do include the test case also for
>> this. In general, it would be great if you could provide test cases
>> also along with the code changes while sending for review.
>>
>> Thank you,
>> Jini.
>>
>> On 9/26/2017 8:19 PM, Yasumasa Suenaga wrote:
>>> Hi all,
>>>
>>> I uploaded new webrev to be adapted to jdk10/hs:
>>>
>>>  ? http://cr.openjdk.java.net/~ysuenaga/JDK-8187402/webrev.01/
>>>
>>>
>>> Thanks,
>>>
>>> Yasumasa
>>>
>>>
>>> On 2017/09/21 7:47, Yasumasa Suenaga wrote:
>>>> PING:
>>>>
>>>> Have you checked this issue?
>>>>
>>>>> ?? http://cr.openjdk.java.net/~ysuenaga/JDK-8187402/webrev.00/
>>>>
>>>>
>>>> Yasumasa
>>>>
>>>>
>>>> On 2017/09/11 11:17, Yasumasa Suenaga wrote:
>>>>> Hi all,
>>>>>
>>>>> This review request is a part of [1].
>>>>>
>>>>>
>>>>> JBS:
>>>>> ?? https://bugs.openjdk.java.net/browse/JDK-8187402
>>>>>
>>>>> webrev:
>>>>> ?? http://cr.openjdk.java.net/~ysuenaga/JDK-8187402/webrev.00/
>>>>>
>>>>>
>>>>> I cannot access JPRT. So I need a sponsor.
>>>>>
>>>>>
>>>>> Thanks,
>>>>>
>>>>> Yasumasa
>>>>>
>>>>>
>>>>> [1]
>>>>> http://mail.openjdk.java.net/pipermail/serviceability-dev/2017-Sept
>>>>> ember/021821.html
>>>>>
>>>>>
>>
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8187402: UnknownOopException is occurred on Stack Memory window in HSDB

Jini George
In reply to this post by Yasumasa Suenaga-4
Apologize for the delay in responding to this, Yasumasa.

I tried my hand at creating a test case for this by attaching an SA  
process to jshell and by invoking a method to traverse the frame oopmaps  
for the 'output reader' thread -- Please do take a look at:

http://cr.openjdk.java.net/~jgeorge/sponsorships/8187402_ysuenaga/TestFrameOopMap.java

I think, in general, for the issues manifested through the GUI, we can  
probably try having unit test cases directly invoking the methods involved.

Thanks,
Jini.

On 9/27/2017 4:10 AM, Yasumasa Suenaga wrote:

> Hi Jini,
>
> IMHO this issue (JDK-8187402) and JDK-8187403 are too difficult to crate
> test cases because they are problems in Stack Memory window in HSDB.
> Can we add noreg-hard label to JBS?
>
>
> Thanks,
>
> Yasumasa
>
>
> On 2017/09/27 2:36, Jini George wrote:
>> Hi Yasumasa,
>>
>> The changes look fine, but please do include the test case also for
>> this. In general, it would be great if you could provide test cases also
>> along with the code changes while sending for review.
>>
>> Thank you,
>> Jini.
>>
>> On 9/26/2017 8:19 PM, Yasumasa Suenaga wrote:
>>> Hi all,
>>>
>>> I uploaded new webrev to be adapted to jdk10/hs:
>>>
>>>  ? http://cr.openjdk.java.net/~ysuenaga/JDK-8187402/webrev.01/
>>>
>>>
>>> Thanks,
>>>
>>> Yasumasa
>>>
>>>
>>> On 2017/09/21 7:47, Yasumasa Suenaga wrote:
>>>> PING:
>>>>
>>>> Have you checked this issue?
>>>>
>>>>> ?? http://cr.openjdk.java.net/~ysuenaga/JDK-8187402/webrev.00/
>>>>
>>>>
>>>> Yasumasa
>>>>
>>>>
>>>> On 2017/09/11 11:17, Yasumasa Suenaga wrote:
>>>>> Hi all,
>>>>>
>>>>> This review request is a part of [1].
>>>>>
>>>>>
>>>>> JBS:
>>>>> ?? https://bugs.openjdk.java.net/browse/JDK-8187402
>>>>>
>>>>> webrev:
>>>>> ?? http://cr.openjdk.java.net/~ysuenaga/JDK-8187402/webrev.00/
>>>>>
>>>>>
>>>>> I cannot access JPRT. So I need a sponsor.
>>>>>
>>>>>
>>>>> Thanks,
>>>>>
>>>>> Yasumasa
>>>>>
>>>>>
>>>>> [1]
>>>>> http://mail.openjdk.java.net/pipermail/serviceability-dev/2017-September/021821.html 
>>>>>
>>>>>
>>>>>
>>
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8187402: UnknownOopException is occurred on Stack Memory window in HSDB

Yasumasa Suenaga-4
Hi Jini,

Thank you for sharing the testcase.
However I concern about this as below:

1. This bug appears at JIT'ed frame. So it might not appear on test server.
We can add -Xcomp or JSON for compiler control for this issue, but we cannot control compile level (TieredCompilation) AFAIK.

2. If JShell implementation is changed in the future, this testcase might not verify this bug.


I will merge your testcase to the webrev if these concerns can be ignored.


Thanks,

Yasumasa



2017/10/02 0:51 "Jini George" <[hidden email]>:
Apologize for the delay in responding to this, Yasumasa.

I tried my hand at creating a test case for this by attaching an SA  process to jshell and by invoking a method to traverse the frame oopmaps  for the 'output reader' thread -- Please do take a look at:

http://cr.openjdk.java.net/~jgeorge/sponsorships/8187402_ysuenaga/TestFrameOopMap.java

I think, in general, for the issues manifested through the GUI, we can  probably try having unit test cases directly invoking the methods involved.

Thanks,
Jini.

On 9/27/2017 4:10 AM, Yasumasa Suenaga wrote:
Hi Jini,

IMHO this issue (JDK-8187402) and JDK-8187403 are too difficult to crate test cases because they are problems in Stack Memory window in HSDB.
Can we add noreg-hard label to JBS?


Thanks,

Yasumasa


On 2017/09/27 2:36, Jini George wrote:
Hi Yasumasa,

The changes look fine, but please do include the test case also for
this. In general, it would be great if you could provide test cases also
along with the code changes while sending for review.

Thank you,
Jini.

On 9/26/2017 8:19 PM, Yasumasa Suenaga wrote:
Hi all,

I uploaded new webrev to be adapted to jdk10/hs:

 ? http://cr.openjdk.java.net/~ysuenaga/JDK-8187402/webrev.01/


Thanks,

Yasumasa


On 2017/09/21 7:47, Yasumasa Suenaga wrote:
PING:

Have you checked this issue?

?? http://cr.openjdk.java.net/~ysuenaga/JDK-8187402/webrev.00/


Yasumasa


On 2017/09/11 11:17, Yasumasa Suenaga wrote:
Hi all,

This review request is a part of [1].


JBS:
?? https://bugs.openjdk.java.net/browse/JDK-8187402

webrev:
?? http://cr.openjdk.java.net/~ysuenaga/JDK-8187402/webrev.00/


I cannot access JPRT. So I need a sponsor.


Thanks,

Yasumasa


[1]
http://mail.openjdk.java.net/pipermail/serviceability-dev/2017-September/021821.html



Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8187402: UnknownOopException is occurred on Stack Memory window in HSDB

Jini George
Hi Yasumasa,

I think you could create an extension of LingeredApp with the "-Xcomp"
option or the "-XX:CompileCommand=compileonly,<method name>" option to
ensure JIT-ing of a method and maybe turn off TieredCompilation using
"-XX:-TieredCompilation" for ease, too. If that proves to be too
cumbersome, the JShell test case can still be used as a fallback option.

I agree with the possibility of JShell implementation change in the
future. But I might say it is better to have the test running till
however long it can, rather than not having any testing done for that
part at all.

Thank you,
Jini.

On 10/2/2017 5:03 AM, Yasumasa Suenaga wrote:

> Hi Jini,
>
> Thank you for sharing the testcase.
> However I concern about this as below:
>
> 1. This bug appears at JIT'ed frame. So it might not appear on test server.
> We can add -Xcomp or JSON for compiler control for this issue, but we
> cannot control compile level (TieredCompilation) AFAIK.
>
> 2. If JShell implementation is changed in the future, this testcase
> might not verify this bug.
>
>
> I will merge your testcase to the webrev if these concerns can be ignored.
>
>
> Thanks,
>
> Yasumasa
>
>
>
> 2017/10/02 0:51 "Jini George" <[hidden email]
> <mailto:[hidden email]>>:
>
>     Apologize for the delay in responding to this, Yasumasa.
>
>     I tried my hand at creating a test case for this by attaching an SA
>     process to jshell and by invoking a method to traverse the frame
>     oopmaps  for the 'output reader' thread -- Please do take a look at:
>
>     http://cr.openjdk.java.net/~jgeorge/sponsorships/8187402_ysuenaga/TestFrameOopMap.java
>     <http://cr.openjdk.java.net/~jgeorge/sponsorships/8187402_ysuenaga/TestFrameOopMap.java>
>
>     I think, in general, for the issues manifested through the GUI, we
>     can  probably try having unit test cases directly invoking the
>     methods involved.
>
>     Thanks,
>     Jini.
>
>     On 9/27/2017 4:10 AM, Yasumasa Suenaga wrote:
>
>         Hi Jini,
>
>         IMHO this issue (JDK-8187402) and JDK-8187403 are too difficult
>         to crate test cases because they are problems in Stack Memory
>         window in HSDB.
>         Can we add noreg-hard label to JBS?
>
>
>         Thanks,
>
>         Yasumasa
>
>
>         On 2017/09/27 2:36, Jini George wrote:
>
>             Hi Yasumasa,
>
>             The changes look fine, but please do include the test case
>             also for
>             this. In general, it would be great if you could provide
>             test cases also
>             along with the code changes while sending for review.
>
>             Thank you,
>             Jini.
>
>             On 9/26/2017 8:19 PM, Yasumasa Suenaga wrote:
>
>                 Hi all,
>
>                 I uploaded new webrev to be adapted to jdk10/hs:
>
>                   ?
>                 http://cr.openjdk.java.net/~ysuenaga/JDK-8187402/webrev.01/
>                 <http://cr.openjdk.java.net/~ysuenaga/JDK-8187402/webrev.01/>
>
>
>                 Thanks,
>
>                 Yasumasa
>
>
>                 On 2017/09/21 7:47, Yasumasa Suenaga wrote:
>
>                     PING:
>
>                     Have you checked this issue?
>
>                         ??
>                         http://cr.openjdk.java.net/~ysuenaga/JDK-8187402/webrev.00/
>                         <http://cr.openjdk.java.net/~ysuenaga/JDK-8187402/webrev.00/>
>
>
>
>                     Yasumasa
>
>
>                     On 2017/09/11 11:17, Yasumasa Suenaga wrote:
>
>                         Hi all,
>
>                         This review request is a part of [1].
>
>
>                         JBS:
>                         ??
>                         https://bugs.openjdk.java.net/browse/JDK-8187402
>                         <https://bugs.openjdk.java.net/browse/JDK-8187402>
>
>                         webrev:
>                         ??
>                         http://cr.openjdk.java.net/~ysuenaga/JDK-8187402/webrev.00/
>                         <http://cr.openjdk.java.net/~ysuenaga/JDK-8187402/webrev.00/>
>
>
>                         I cannot access JPRT. So I need a sponsor.
>
>
>                         Thanks,
>
>                         Yasumasa
>
>
>                         [1]
>                         http://mail.openjdk.java.net/pipermail/serviceability-dev/2017-September/021821.html
>                         <http://mail.openjdk.java.net/pipermail/serviceability-dev/2017-September/021821.html>
>
>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8187402: UnknownOopException is occurred on Stack Memory window in HSDB

serguei.spitsyn@oracle.com
Hi Jini,

Sorry, I've already pushed the fix for 8187402.
I understood that you are Ok with the fix itself.
Please, let me know if you still have some concerns.

David suggested to skip unit test development and add label noreg-hard
for the 8187401
(please, look at the email thread for 8187401).
The 8187402 is similar to 8187401 so that adding noreg-hard should be
also enough.
My understanding is that we have very few tests for HSDB at this point,
so that the coverage is very limited anyway.

I've not pushed the 8187401 and 8187403 yet because one more review is
required.

Thanks,
Serguei


On 10/5/17 02:36, Jini George wrote:

> Hi Yasumasa,
>
> I think you could create an extension of LingeredApp with the "-Xcomp"
> option or the "-XX:CompileCommand=compileonly,<method name>" option to
> ensure JIT-ing of a method and maybe turn off TieredCompilation using
> "-XX:-TieredCompilation" for ease, too. If that proves to be too
> cumbersome, the JShell test case can still be used as a fallback option.
>
> I agree with the possibility of JShell implementation change in the
> future. But I might say it is better to have the test running till
> however long it can, rather than not having any testing done for that
> part at all.
>
> Thank you,
> Jini.
>
> On 10/2/2017 5:03 AM, Yasumasa Suenaga wrote:
>> Hi Jini,
>>
>> Thank you for sharing the testcase.
>> However I concern about this as below:
>>
>> 1. This bug appears at JIT'ed frame. So it might not appear on test
>> server.
>> We can add -Xcomp or JSON for compiler control for this issue, but we
>> cannot control compile level (TieredCompilation) AFAIK.
>>
>> 2. If JShell implementation is changed in the future, this testcase
>> might not verify this bug.
>>
>>
>> I will merge your testcase to the webrev if these concerns can be
>> ignored.
>>
>>
>> Thanks,
>>
>> Yasumasa
>>
>>
>>
>> 2017/10/02 0:51 "Jini George" <[hidden email]
>> <mailto:[hidden email]>>:
>>
>>     Apologize for the delay in responding to this, Yasumasa.
>>
>>     I tried my hand at creating a test case for this by attaching an
>> SA     process to jshell and by invoking a method to traverse the frame
>>     oopmaps  for the 'output reader' thread -- Please do take a look at:
>>
>> http://cr.openjdk.java.net/~jgeorge/sponsorships/8187402_ysuenaga/TestFrameOopMap.java
>> <http://cr.openjdk.java.net/~jgeorge/sponsorships/8187402_ysuenaga/TestFrameOopMap.java>
>>
>>     I think, in general, for the issues manifested through the GUI, we
>>     can  probably try having unit test cases directly invoking the
>>     methods involved.
>>
>>     Thanks,
>>     Jini.
>>
>>     On 9/27/2017 4:10 AM, Yasumasa Suenaga wrote:
>>
>>         Hi Jini,
>>
>>         IMHO this issue (JDK-8187402) and JDK-8187403 are too difficult
>>         to crate test cases because they are problems in Stack Memory
>>         window in HSDB.
>>         Can we add noreg-hard label to JBS?
>>
>>
>>         Thanks,
>>
>>         Yasumasa
>>
>>
>>         On 2017/09/27 2:36, Jini George wrote:
>>
>>             Hi Yasumasa,
>>
>>             The changes look fine, but please do include the test case
>>             also for
>>             this. In general, it would be great if you could provide
>>             test cases also
>>             along with the code changes while sending for review.
>>
>>             Thank you,
>>             Jini.
>>
>>             On 9/26/2017 8:19 PM, Yasumasa Suenaga wrote:
>>
>>                 Hi all,
>>
>>                 I uploaded new webrev to be adapted to jdk10/hs:
>>
>>                   ?
>> http://cr.openjdk.java.net/~ysuenaga/JDK-8187402/webrev.01/
>> <http://cr.openjdk.java.net/~ysuenaga/JDK-8187402/webrev.01/>
>>
>>
>>                 Thanks,
>>
>>                 Yasumasa
>>
>>
>>                 On 2017/09/21 7:47, Yasumasa Suenaga wrote:
>>
>>                     PING:
>>
>>                     Have you checked this issue?
>>
>>                         ??
>> http://cr.openjdk.java.net/~ysuenaga/JDK-8187402/webrev.00/
>> <http://cr.openjdk.java.net/~ysuenaga/JDK-8187402/webrev.00/>
>>
>>
>>
>>                     Yasumasa
>>
>>
>>                     On 2017/09/11 11:17, Yasumasa Suenaga wrote:
>>
>>                         Hi all,
>>
>>                         This review request is a part of [1].
>>
>>
>>                         JBS:
>>                         ??
>> https://bugs.openjdk.java.net/browse/JDK-8187402
>> <https://bugs.openjdk.java.net/browse/JDK-8187402>
>>
>>                         webrev:
>>                         ??
>> http://cr.openjdk.java.net/~ysuenaga/JDK-8187402/webrev.00/
>> <http://cr.openjdk.java.net/~ysuenaga/JDK-8187402/webrev.00/>
>>
>>
>>                         I cannot access JPRT. So I need a sponsor.
>>
>>
>>                         Thanks,
>>
>>                         Yasumasa
>>
>>
>>                         [1]
>> http://mail.openjdk.java.net/pipermail/serviceability-dev/2017-September/021821.html
>> <http://mail.openjdk.java.net/pipermail/serviceability-dev/2017-September/021821.html>
>>
>>
>>
>>