RFR: 8187588: Error generating using JDK 9 javadoc against a JDK 8 source repository

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8187588: Error generating using JDK 9 javadoc against a JDK 8 source repository

Kumar Srinivasan
Hello,

Please review simple fix for [1]  webrev at [2].

Thanks
Kumar

[1] https://bugs.openjdk.java.net/browse/JDK-8187588
[2] http://cr.openjdk.java.net/~ksrini/8187588/webrev.00/
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8187588: Error generating using JDK 9 javadoc against a JDK 8 source repository

Jonathan Gibbons
Mostly OK.

Suggest removing repeated use of @modules. The first use of @modules is
enough ... it can take a list of values, spread over multiple lines.

   28  * @modules jdk.compiler/com.sun.tools.javac.api
   29  *          jdk.compiler/com.sun.tools.javac.main
   30  *          jdk.javadoc/jdk.javadoc.internal.api
   31  *          jdk.javadoc/jdk.javadoc.internal.tool
   32  * @library /tools/lib


-- Jon


On 11/20/2017 03:41 PM, Kumar Srinivasan wrote:
> Hello,
>
> Please review simple fix for [1]  webrev at [2].
>
> Thanks
> Kumar
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8187588
> [2] http://cr.openjdk.java.net/~ksrini/8187588/webrev.00/