RFR: 8187954 Update JAX-WS RI integration to latest version

classic Classic list List threaded Threaded
14 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8187954 Update JAX-WS RI integration to latest version

Jack Li
Hi,

Please review standalone JAXB/JAXWS changes, synced to jdk/jaxws repo.

JBS: https://bugs.openjdk.java.net/browse/JDK-8187954 <https://bugs.openjdk.java.net/browse/JDK-8187954>
Webrev: http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/ <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/>

Summary of changes:

jaxws/src/java.xml.bind/share/classes/javax/xml/bind/*
JDK-8186946 - Fix accessibility and other issues in the java.xml.bind module

jaxws/src/java.xml.ws/share/classes/com/sun/xml/internal/messaging/saaj/**
JDK-8186314 - code at c.s.x.i.m.saaj.soap.MessageImpl must be modified to avoid crash after javac change
And also contains the fixes for importing nodes for SOAPDocumentFragment


Patch also contains several small bugfixes, not tracked in JBS.

----------------
Best regards
Jack Li






Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8187954 Update JAX-WS RI integration to latest version

Lance Andersen
Hi Jack,

Is this change correct:

-------------
--- old/src/java.xml.bind/share/classes/javax/xml/bind/Marshaller.java 2017-09-29 13:58:31.968185273 +0100
+++ new/src/java.xml.bind/share/classes/javax/xml/bind/Marshaller.java 2017-09-29 13:58:31.676185267 +0100
@@ -373,7 +373,7 @@
      *      If the {@link ValidationEventHandler ValidationEventHandler}
      *      returns false from its {@code handleEvent} method or the
      *      {@code Marshaller} is unable to marshal {@code jaxbElement} (or any
-     *      object reachable from {@code jaxbElement}).  See <a href="{@docRoot}/javax/xml/bind/Marshaller.html#elementMarshalling">
+     *      object reachable from {@code jaxbElement}).  See <a href="{@docRoot}/java/xml/bind/Marshaller.html#elementMarshalling">
      *      Marshalling a JAXB element</a>.

------------

The URL that is being changed currently works

Best
Lance
On Sep 29, 2017, at 10:55 PM, Jack Li <[hidden email]> wrote:

> Hi,
>
> Please review standalone JAXB/JAXWS changes, synced to jdk/jaxws repo.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8187954 <https://bugs.openjdk.java.net/browse/JDK-8187954>
> Webrev: http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/ <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/>
>
> Summary of changes:
>
> jaxws/src/java.xml.bind/share/classes/javax/xml/bind/*
> JDK-8186946 - Fix accessibility and other issues in the java.xml.bind module
>
> jaxws/src/java.xml.ws/share/classes/com/sun/xml/internal/messaging/saaj/**
> JDK-8186314 - code at c.s.x.i.m.saaj.soap.MessageImpl must be modified to avoid crash after javac change
> And also contains the fixes for importing nodes for SOAPDocumentFragment
>
>
> Patch also contains several small bugfixes, not tracked in JBS.
>
> ----------------
> Best regards
> Jack Li
>
>
>
>
>
>




Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
[hidden email]




Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8187954 Update JAX-WS RI integration to latest version

Jack Li
Hi Lance,

the change is incorrect, it should be “javax/xml/bind”.
thanks a lot for your finding, do you think I need to fix it and resubmit the webrev this time?
or can you skip this file this time and I fix it in next integration?

> On Oct 4, 2017, at 02:09, Lance Andersen <[hidden email]> wrote:
>
> Hi Jack,
>
> Is this change correct:
>
> -------------
> --- old/src/java.xml.bind/share/classes/javax/xml/bind/Marshaller.java 2017-09-29 13:58:31.968185273 +0100
> +++ new/src/java.xml.bind/share/classes/javax/xml/bind/Marshaller.java 2017-09-29 13:58:31.676185267 +0100
> @@ -373,7 +373,7 @@
>       *      If the {@link ValidationEventHandler ValidationEventHandler}
>       *      returns false from its {@code handleEvent} method or the
>       *      {@code Marshaller} is unable to marshal {@code jaxbElement} (or any
> -     *      object reachable from {@code jaxbElement}).  See <a href="{@docRoot}/javax/xml/bind/Marshaller.html#elementMarshalling">
> +     *      object reachable from {@code jaxbElement}).  See <a href="{@docRoot}/java/xml/bind/Marshaller.html#elementMarshalling">
>       *      Marshalling a JAXB element</a>.
>
> ------------
>
> The URL that is being changed currently works
>
> Best
> Lance
> On Sep 29, 2017, at 10:55 PM, Jack Li <[hidden email] <mailto:[hidden email]>> wrote:
>
>> Hi,
>>
>> Please review standalone JAXB/JAXWS changes, synced to jdk/jaxws repo.
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8187954 <https://bugs.openjdk.java.net/browse/JDK-8187954> <https://bugs.openjdk.java.net/browse/JDK-8187954 <https://bugs.openjdk.java.net/browse/JDK-8187954>>
>> Webrev: http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/ <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/> <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/ <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/>>
>>
>> Summary of changes:
>>
>> jaxws/src/java.xml.bind/share/classes/javax/xml/bind/*
>> JDK-8186946 - Fix accessibility and other issues in the java.xml.bind module
>>
>> jaxws/src/java.xml.ws/share/classes/com/sun/xml/internal/messaging/saaj/**
>> JDK-8186314 - code at c.s.x.i.m.saaj.soap.MessageImpl must be modified to avoid crash after javac change
>> And also contains the fixes for importing nodes for SOAPDocumentFragment
>>
>>
>> Patch also contains several small bugfixes, not tracked in JBS.
>>
>> ----------------
>> Best regards
>> Jack Li
>>
>>
>>
>>
>>
>>
>
>
> <oracle_sig_logo.gif>
>
> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering 
> 1 Network Drive 
> Burlington, MA 01803
>  <http://oracle.com/us/design/oracle-email-sig-198324.gif>[hidden email] <mailto:[hidden email]>

----------------
Best regards
Jack Li






Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8187954 Update JAX-WS RI integration to latest version

Lance Andersen
Hi Jack,

UnMarshaller also has the same issue.  I would update the webrev given the number of places to help sanity check for omissions

Best
Lance

> On Oct 8, 2017, at 9:22 PM, Jack Li <[hidden email]> wrote:
>
> Hi Lance,
>
> the change is incorrect, it should be “javax/xml/bind”.
> thanks a lot for your finding, do you think I need to fix it and resubmit the webrev this time?
> or can you skip this file this time and I fix it in next integration?
>
>> On Oct 4, 2017, at 02:09, Lance Andersen <[hidden email] <mailto:[hidden email]>> wrote:
>>
>> Hi Jack,
>>
>> Is this change correct:
>>
>> -------------
>> --- old/src/java.xml.bind/share/classes/javax/xml/bind/Marshaller.java 2017-09-29 13:58:31.968185273 +0100
>> +++ new/src/java.xml.bind/share/classes/javax/xml/bind/Marshaller.java 2017-09-29 13:58:31.676185267 +0100
>> @@ -373,7 +373,7 @@
>>       *      If the {@link ValidationEventHandler ValidationEventHandler}
>>       *      returns false from its {@code handleEvent} method or the
>>       *      {@code Marshaller} is unable to marshal {@code jaxbElement} (or any
>> -     *      object reachable from {@code jaxbElement}).  See <a href="{@docRoot}/javax/xml/bind/Marshaller.html#elementMarshalling">
>> +     *      object reachable from {@code jaxbElement}).  See <a href="{@docRoot}/java/xml/bind/Marshaller.html#elementMarshalling">
>>       *      Marshalling a JAXB element</a>.
>>
>> ------------
>>
>> The URL that is being changed currently works
>>
>> Best
>> Lance
>> On Sep 29, 2017, at 10:55 PM, Jack Li <[hidden email] <mailto:[hidden email]>> wrote:
>>
>>> Hi,
>>>
>>> Please review standalone JAXB/JAXWS changes, synced to jdk/jaxws repo.
>>>
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8187954 <https://bugs.openjdk.java.net/browse/JDK-8187954> <https://bugs.openjdk.java.net/browse/JDK-8187954 <https://bugs.openjdk.java.net/browse/JDK-8187954>>
>>> Webrev: http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/ <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/> <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/ <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/>>
>>>
>>> Summary of changes:
>>>
>>> jaxws/src/java.xml.bind/share/classes/javax/xml/bind/*
>>> JDK-8186946 - Fix accessibility and other issues in the java.xml.bind module
>>>
>>> jaxws/src/java.xml.ws/share/classes/com/sun/xml/internal/messaging/saaj/**
>>> JDK-8186314 - code at c.s.x.i.m.saaj.soap.MessageImpl must be modified to avoid crash after javac change
>>> And also contains the fixes for importing nodes for SOAPDocumentFragment
>>>
>>>
>>> Patch also contains several small bugfixes, not tracked in JBS.
>>>
>>> ----------------
>>> Best regards
>>> Jack Li
>>>
>>>
>>>
>>>
>>>
>>>
>>
>>
>> <oracle_sig_logo.gif>
>>
>> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>> Oracle Java Engineering 
>> 1 Network Drive 
>> Burlington, MA 01803
>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif>[hidden email] <mailto:[hidden email]>
>
> ----------------
> Best regards
> Jack Li
>
>
>
>
>
>

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
[hidden email] <mailto:[hidden email]>



Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8187954 Update JAX-WS RI integration to latest version

Jack Li
Hi Lance

I will update them in Metro repository, do I need to regenerate webrev?
or can you skip the files this time and I fix it in next integration?

> On Oct 9, 2017, at 19:35, Lance Andersen <[hidden email]> wrote:
>
> Hi Jack,
>
> UnMarshaller also has the same issue.  I would update the webrev given the number of places to help sanity check for omissions
>
> Best
> Lance
>> On Oct 8, 2017, at 9:22 PM, Jack Li <[hidden email] <mailto:[hidden email]>> wrote:
>>
>> Hi Lance,
>>
>> the change is incorrect, it should be “javax/xml/bind”.
>> thanks a lot for your finding, do you think I need to fix it and resubmit the webrev this time?
>> or can you skip this file this time and I fix it in next integration?
>>
>>> On Oct 4, 2017, at 02:09, Lance Andersen <[hidden email] <mailto:[hidden email]>> wrote:
>>>
>>> Hi Jack,
>>>
>>> Is this change correct:
>>>
>>> -------------
>>> --- old/src/java.xml.bind/share/classes/javax/xml/bind/Marshaller.java 2017-09-29 13:58:31.968185273 +0100
>>> +++ new/src/java.xml.bind/share/classes/javax/xml/bind/Marshaller.java 2017-09-29 13:58:31.676185267 +0100
>>> @@ -373,7 +373,7 @@
>>>       *      If the {@link ValidationEventHandler ValidationEventHandler}
>>>       *      returns false from its {@code handleEvent} method or the
>>>       *      {@code Marshaller} is unable to marshal {@code jaxbElement} (or any
>>> -     *      object reachable from {@code jaxbElement}).  See <a href="{@docRoot}/javax/xml/bind/Marshaller.html#elementMarshalling">
>>> +     *      object reachable from {@code jaxbElement}).  See <a href="{@docRoot}/java/xml/bind/Marshaller.html#elementMarshalling">
>>>       *      Marshalling a JAXB element</a>.
>>>
>>> ------------
>>>
>>> The URL that is being changed currently works
>>>
>>> Best
>>> Lance
>>> On Sep 29, 2017, at 10:55 PM, Jack Li <[hidden email] <mailto:[hidden email]>> wrote:
>>>
>>>> Hi,
>>>>
>>>> Please review standalone JAXB/JAXWS changes, synced to jdk/jaxws repo.
>>>>
>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8187954 <https://bugs.openjdk.java.net/browse/JDK-8187954> <https://bugs.openjdk.java.net/browse/JDK-8187954 <https://bugs.openjdk.java.net/browse/JDK-8187954>>
>>>> Webrev: http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/ <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/> <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/ <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/>>
>>>>
>>>> Summary of changes:
>>>>
>>>> jaxws/src/java.xml.bind/share/classes/javax/xml/bind/*
>>>> JDK-8186946 - Fix accessibility and other issues in the java.xml.bind module
>>>>
>>>> jaxws/src/java.xml.ws/share/classes/com/sun/xml/internal/messaging/saaj/**
>>>> JDK-8186314 - code at c.s.x.i.m.saaj.soap.MessageImpl must be modified to avoid crash after javac change
>>>> And also contains the fixes for importing nodes for SOAPDocumentFragment
>>>>
>>>>
>>>> Patch also contains several small bugfixes, not tracked in JBS.
>>>>
>>>> ----------------
>>>> Best regards
>>>> Jack Li
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>
>>>
>>> <oracle_sig_logo.gif>
>>>
>>> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>> Oracle Java Engineering 
>>> 1 Network Drive 
>>> Burlington, MA 01803
>>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif>[hidden email] <mailto:[hidden email]>
>>
>> ----------------
>> Best regards
>> Jack Li
>>
>>
>>
>>
>>
>>
>
> <oracle_sig_logo.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>  <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>  <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> [hidden email] <mailto:[hidden email]>
>
>
>


----------------
Best regards
Jack Li






Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8187954 Update JAX-WS RI integration to latest version

Lance Andersen
Hi Jack,

I would prefer to see an updated webrev so that we do not inadvertently
push these changes.

Best
Lance

> On Oct 11, 2017, at 3:26 AM, Jack Li <[hidden email]> wrote:
>
> Hi Lance
>
> I will update them in Metro repository, do I need to regenerate webrev?
> or can you skip the files this time and I fix it in next integration?
>
>> On Oct 9, 2017, at 19:35, Lance Andersen <[hidden email] <mailto:[hidden email]>> wrote:
>>
>> Hi Jack,
>>
>> UnMarshaller also has the same issue.  I would update the webrev given the number of places to help sanity check for omissions
>>
>> Best
>> Lance
>>> On Oct 8, 2017, at 9:22 PM, Jack Li <[hidden email] <mailto:[hidden email]>> wrote:
>>>
>>> Hi Lance,
>>>
>>> the change is incorrect, it should be “javax/xml/bind”.
>>> thanks a lot for your finding, do you think I need to fix it and resubmit the webrev this time?
>>> or can you skip this file this time and I fix it in next integration?
>>>
>>>> On Oct 4, 2017, at 02:09, Lance Andersen <[hidden email] <mailto:[hidden email]>> wrote:
>>>>
>>>> Hi Jack,
>>>>
>>>> Is this change correct:
>>>>
>>>> -------------
>>>> --- old/src/java.xml.bind/share/classes/javax/xml/bind/Marshaller.java 2017-09-29 13:58:31.968185273 +0100
>>>> +++ new/src/java.xml.bind/share/classes/javax/xml/bind/Marshaller.java 2017-09-29 13:58:31.676185267 +0100
>>>> @@ -373,7 +373,7 @@
>>>>       *      If the {@link ValidationEventHandler ValidationEventHandler}
>>>>       *      returns false from its {@code handleEvent} method or the
>>>>       *      {@code Marshaller} is unable to marshal {@code jaxbElement} (or any
>>>> -     *      object reachable from {@code jaxbElement}).  See <a href="{@docRoot}/javax/xml/bind/Marshaller.html#elementMarshalling">
>>>> +     *      object reachable from {@code jaxbElement}).  See <a href="{@docRoot}/java/xml/bind/Marshaller.html#elementMarshalling">
>>>>       *      Marshalling a JAXB element</a>.
>>>>
>>>> ------------
>>>>
>>>> The URL that is being changed currently works
>>>>
>>>> Best
>>>> Lance
>>>> On Sep 29, 2017, at 10:55 PM, Jack Li <[hidden email] <mailto:[hidden email]>> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> Please review standalone JAXB/JAXWS changes, synced to jdk/jaxws repo.
>>>>>
>>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8187954 <https://bugs.openjdk.java.net/browse/JDK-8187954> <https://bugs.openjdk.java.net/browse/JDK-8187954 <https://bugs.openjdk.java.net/browse/JDK-8187954>>
>>>>> Webrev: http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/ <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/> <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/ <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/>>
>>>>>
>>>>> Summary of changes:
>>>>>
>>>>> jaxws/src/java.xml.bind/share/classes/javax/xml/bind/*
>>>>> JDK-8186946 - Fix accessibility and other issues in the java.xml.bind module
>>>>>
>>>>> jaxws/src/java.xml.ws/share/classes/com/sun/xml/internal/messaging/saaj/**
>>>>> JDK-8186314 - code at c.s.x.i.m.saaj.soap.MessageImpl must be modified to avoid crash after javac change
>>>>> And also contains the fixes for importing nodes for SOAPDocumentFragment
>>>>>
>>>>>
>>>>> Patch also contains several small bugfixes, not tracked in JBS.
>>>>>
>>>>> ----------------
>>>>> Best regards
>>>>> Jack Li
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>> <oracle_sig_logo.gif>
>>>>
>>>> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>>> Oracle Java Engineering 
>>>> 1 Network Drive 
>>>> Burlington, MA 01803
>>>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif>[hidden email] <mailto:[hidden email]>
>>>
>>> ----------------
>>> Best regards
>>> Jack Li
>>>
>>>
>>>
>>>
>>>
>>>
>>
>> <oracle_sig_logo.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>> Oracle Java Engineering
>> 1 Network Drive
>> Burlington, MA 01803
>> [hidden email] <mailto:[hidden email]>
>>
>>
>>
>
>
> ----------------
> Best regards
> Jack Li

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
[hidden email] <mailto:[hidden email]>



Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8187954 Update JAX-WS RI integration to latest version

Jack Li
Hi Lance,

The webrev is updated, can you please review it again?

JBS: https://bugs.openjdk.java.net/browse/JDK-8187954 <https://bugs.openjdk.java.net/browse/JDK-8187954>
Webrev: http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/01 <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/01>

Summary of changes:

jaxws/src/java.xml.bind/share/classes/javax/xml/bind/*
JDK-8186946 - Fix accessibility and other issues in the java.xml.bind module

jaxws/src/java.xml.ws/share/classes/com/sun/xml/internal/messaging/saaj/**
JDK-8186314 - code at c.s.x.i.m.saaj.soap.MessageImpl must be modified to avoid crash after javac change
And also contains the fixes for importing nodes for SOAPDocumentFragment


Patch also contains several small bugfixes, not tracked in JBS.

> On Oct 11, 2017, at 18:47, Lance Andersen <[hidden email]> wrote:
>
> Hi Jack,
>
> I would prefer to see an updated webrev so that we do not inadvertently
> push these changes.
>
> Best
> Lance
>> On Oct 11, 2017, at 3:26 AM, Jack Li <[hidden email] <mailto:[hidden email]>> wrote:
>>
>> Hi Lance
>>
>> I will update them in Metro repository, do I need to regenerate webrev?
>> or can you skip the files this time and I fix it in next integration?
>>
>>> On Oct 9, 2017, at 19:35, Lance Andersen <[hidden email] <mailto:[hidden email]>> wrote:
>>>
>>> Hi Jack,
>>>
>>> UnMarshaller also has the same issue.  I would update the webrev given the number of places to help sanity check for omissions
>>>
>>> Best
>>> Lance
>>>> On Oct 8, 2017, at 9:22 PM, Jack Li <[hidden email] <mailto:[hidden email]>> wrote:
>>>>
>>>> Hi Lance,
>>>>
>>>> the change is incorrect, it should be “javax/xml/bind”.
>>>> thanks a lot for your finding, do you think I need to fix it and resubmit the webrev this time?
>>>> or can you skip this file this time and I fix it in next integration?
>>>>
>>>>> On Oct 4, 2017, at 02:09, Lance Andersen <[hidden email] <mailto:[hidden email]>> wrote:
>>>>>
>>>>> Hi Jack,
>>>>>
>>>>> Is this change correct:
>>>>>
>>>>> -------------
>>>>> --- old/src/java.xml.bind/share/classes/javax/xml/bind/Marshaller.java 2017-09-29 13:58:31.968185273 +0100
>>>>> +++ new/src/java.xml.bind/share/classes/javax/xml/bind/Marshaller.java 2017-09-29 13:58:31.676185267 +0100
>>>>> @@ -373,7 +373,7 @@
>>>>>       *      If the {@link ValidationEventHandler ValidationEventHandler}
>>>>>       *      returns false from its {@code handleEvent} method or the
>>>>>       *      {@code Marshaller} is unable to marshal {@code jaxbElement} (or any
>>>>> -     *      object reachable from {@code jaxbElement}).  See <a href="{@docRoot}/javax/xml/bind/Marshaller.html#elementMarshalling">
>>>>> +     *      object reachable from {@code jaxbElement}).  See <a href="{@docRoot}/java/xml/bind/Marshaller.html#elementMarshalling">
>>>>>       *      Marshalling a JAXB element</a>.
>>>>>
>>>>> ------------
>>>>>
>>>>> The URL that is being changed currently works
>>>>>
>>>>> Best
>>>>> Lance
>>>>> On Sep 29, 2017, at 10:55 PM, Jack Li <[hidden email] <mailto:[hidden email]>> wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> Please review standalone JAXB/JAXWS changes, synced to jdk/jaxws repo.
>>>>>>
>>>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8187954 <https://bugs.openjdk.java.net/browse/JDK-8187954> <https://bugs.openjdk.java.net/browse/JDK-8187954 <https://bugs.openjdk.java.net/browse/JDK-8187954>>
>>>>>> Webrev: http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/ <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/> <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/ <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/>>
>>>>>>
>>>>>> Summary of changes:
>>>>>>
>>>>>> jaxws/src/java.xml.bind/share/classes/javax/xml/bind/*
>>>>>> JDK-8186946 - Fix accessibility and other issues in the java.xml.bind module
>>>>>>
>>>>>> jaxws/src/java.xml.ws/share/classes/com/sun/xml/internal/messaging/saaj/**
>>>>>> JDK-8186314 - code at c.s.x.i.m.saaj.soap.MessageImpl must be modified to avoid crash after javac change
>>>>>> And also contains the fixes for importing nodes for SOAPDocumentFragment
>>>>>>
>>>>>>
>>>>>> Patch also contains several small bugfixes, not tracked in JBS.
>>>>>>
>>>>>> ----------------
>>>>>> Best regards
>>>>>> Jack Li
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> <oracle_sig_logo.gif>
>>>>>
>>>>> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>>>> Oracle Java Engineering 
>>>>> 1 Network Drive 
>>>>> Burlington, MA 01803
>>>>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif>[hidden email] <mailto:[hidden email]>
>>>>
>>>> ----------------
>>>> Best regards
>>>> Jack Li
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>
>>> <oracle_sig_logo.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>> Oracle Java Engineering
>>> 1 Network Drive
>>> Burlington, MA 01803
>>> [hidden email] <mailto:[hidden email]>
>>>
>>>
>>>
>>
>>
>> ----------------
>> Best regards
>> Jack Li
>
> <oracle_sig_logo.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>  <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>  <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> [hidden email] <mailto:[hidden email]>
>
>
>


----------------
Best regards
Jack Li






Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8187954 Update JAX-WS RI integration to latest version

Jack Li
Hi Lance

Is there anything wrong in the new webrev?


> On Oct 25, 2017, at 10:00, Jack Li <[hidden email]> wrote:
>
> Hi Lance,
>
> The webrev is updated, can you please review it again?
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8187954 <https://bugs.openjdk.java.net/browse/JDK-8187954>
> Webrev: http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/01 <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/01>
>
> Summary of changes:
>
> jaxws/src/java.xml.bind/share/classes/javax/xml/bind/*
> JDK-8186946 - Fix accessibility and other issues in the java.xml.bind module
>
> jaxws/src/java.xml.ws/share/classes/com/sun/xml/internal/messaging/saaj/**
> JDK-8186314 - code at c.s.x.i.m.saaj.soap.MessageImpl must be modified to avoid crash after javac change
> And also contains the fixes for importing nodes for SOAPDocumentFragment
>
>
> Patch also contains several small bugfixes, not tracked in JBS.
>
>> On Oct 11, 2017, at 18:47, Lance Andersen <[hidden email] <mailto:[hidden email]>> wrote:
>>
>> Hi Jack,
>>
>> I would prefer to see an updated webrev so that we do not inadvertently
>> push these changes.
>>
>> Best
>> Lance
>>> On Oct 11, 2017, at 3:26 AM, Jack Li <[hidden email] <mailto:[hidden email]>> wrote:
>>>
>>> Hi Lance
>>>
>>> I will update them in Metro repository, do I need to regenerate webrev?
>>> or can you skip the files this time and I fix it in next integration?
>>>
>>>> On Oct 9, 2017, at 19:35, Lance Andersen <[hidden email] <mailto:[hidden email]>> wrote:
>>>>
>>>> Hi Jack,
>>>>
>>>> UnMarshaller also has the same issue.  I would update the webrev given the number of places to help sanity check for omissions
>>>>
>>>> Best
>>>> Lance
>>>>> On Oct 8, 2017, at 9:22 PM, Jack Li <[hidden email] <mailto:[hidden email]>> wrote:
>>>>>
>>>>> Hi Lance,
>>>>>
>>>>> the change is incorrect, it should be “javax/xml/bind”.
>>>>> thanks a lot for your finding, do you think I need to fix it and resubmit the webrev this time?
>>>>> or can you skip this file this time and I fix it in next integration?
>>>>>
>>>>>> On Oct 4, 2017, at 02:09, Lance Andersen <[hidden email] <mailto:[hidden email]>> wrote:
>>>>>>
>>>>>> Hi Jack,
>>>>>>
>>>>>> Is this change correct:
>>>>>>
>>>>>> -------------
>>>>>> --- old/src/java.xml.bind/share/classes/javax/xml/bind/Marshaller.java 2017-09-29 13:58:31.968185273 +0100
>>>>>> +++ new/src/java.xml.bind/share/classes/javax/xml/bind/Marshaller.java 2017-09-29 13:58:31.676185267 +0100
>>>>>> @@ -373,7 +373,7 @@
>>>>>>       *      If the {@link ValidationEventHandler ValidationEventHandler}
>>>>>>       *      returns false from its {@code handleEvent} method or the
>>>>>>       *      {@code Marshaller} is unable to marshal {@code jaxbElement} (or any
>>>>>> -     *      object reachable from {@code jaxbElement}).  See <a href="{@docRoot}/javax/xml/bind/Marshaller.html#elementMarshalling">
>>>>>> +     *      object reachable from {@code jaxbElement}).  See <a href="{@docRoot}/java/xml/bind/Marshaller.html#elementMarshalling">
>>>>>>       *      Marshalling a JAXB element</a>.
>>>>>>
>>>>>> ------------
>>>>>>
>>>>>> The URL that is being changed currently works
>>>>>>
>>>>>> Best
>>>>>> Lance
>>>>>> On Sep 29, 2017, at 10:55 PM, Jack Li <[hidden email] <mailto:[hidden email]>> wrote:
>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> Please review standalone JAXB/JAXWS changes, synced to jdk/jaxws repo.
>>>>>>>
>>>>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8187954 <https://bugs.openjdk.java.net/browse/JDK-8187954> <https://bugs.openjdk.java.net/browse/JDK-8187954 <https://bugs.openjdk.java.net/browse/JDK-8187954>>
>>>>>>> Webrev: http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/ <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/> <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/ <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/>>
>>>>>>>
>>>>>>> Summary of changes:
>>>>>>>
>>>>>>> jaxws/src/java.xml.bind/share/classes/javax/xml/bind/*
>>>>>>> JDK-8186946 - Fix accessibility and other issues in the java.xml.bind module
>>>>>>>
>>>>>>> jaxws/src/java.xml.ws/share/classes/com/sun/xml/internal/messaging/saaj/**
>>>>>>> JDK-8186314 - code at c.s.x.i.m.saaj.soap.MessageImpl must be modified to avoid crash after javac change
>>>>>>> And also contains the fixes for importing nodes for SOAPDocumentFragment
>>>>>>>
>>>>>>>
>>>>>>> Patch also contains several small bugfixes, not tracked in JBS.
>>>>>>>
>>>>>>> ----------------
>>>>>>> Best regards
>>>>>>> Jack Li
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>> <oracle_sig_logo.gif>
>>>>>>
>>>>>> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>>>>> Oracle Java Engineering 
>>>>>> 1 Network Drive 
>>>>>> Burlington, MA 01803
>>>>>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif>[hidden email] <mailto:[hidden email]>
>>>>>
>>>>> ----------------
>>>>> Best regards
>>>>> Jack Li
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>> <oracle_sig_logo.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>>> Oracle Java Engineering
>>>> 1 Network Drive
>>>> Burlington, MA 01803
>>>> [hidden email] <mailto:[hidden email]>
>>>>
>>>>
>>>>
>>>
>>>
>>> ----------------
>>> Best regards
>>> Jack Li
>>
>> <oracle_sig_logo.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>> Oracle Java Engineering
>> 1 Network Drive
>> Burlington, MA 01803
>> [hidden email] <mailto:[hidden email]>
>>
>>
>>
>
>
> ----------------
> Best regards
> Jack Li
>
>
>
>
>
>


----------------
Best regards
Jack Li






Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8187954 Update JAX-WS RI integration to latest version

Lance Andersen
Hi Jack

Its on my list to finish by the end of the week.

Best
Lance

> On Nov 2, 2017, at 4:34 AM, Jack Li <[hidden email]> wrote:
>
> Hi Lance
>
> Is there anything wrong in the new webrev?
>
>
>> On Oct 25, 2017, at 10:00, Jack Li <[hidden email] <mailto:[hidden email]>> wrote:
>>
>> Hi Lance,
>>
>> The webrev is updated, can you please review it again?
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8187954 <https://bugs.openjdk.java.net/browse/JDK-8187954>
>> Webrev: http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/01 <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/01>
>>
>> Summary of changes:
>>
>> jaxws/src/java.xml.bind/share/classes/javax/xml/bind/*
>> JDK-8186946 - Fix accessibility and other issues in the java.xml.bind module
>>
>> jaxws/src/java.xml.ws/share/classes/com/sun/xml/internal/messaging/saaj/**
>> JDK-8186314 - code at c.s.x.i.m.saaj.soap.MessageImpl must be modified to avoid crash after javac change
>> And also contains the fixes for importing nodes for SOAPDocumentFragment
>>
>>
>> Patch also contains several small bugfixes, not tracked in JBS.
>>
>>> On Oct 11, 2017, at 18:47, Lance Andersen <[hidden email] <mailto:[hidden email]>> wrote:
>>>
>>> Hi Jack,
>>>
>>> I would prefer to see an updated webrev so that we do not inadvertently
>>> push these changes.
>>>
>>> Best
>>> Lance
>>>> On Oct 11, 2017, at 3:26 AM, Jack Li <[hidden email] <mailto:[hidden email]>> wrote:
>>>>
>>>> Hi Lance
>>>>
>>>> I will update them in Metro repository, do I need to regenerate webrev?
>>>> or can you skip the files this time and I fix it in next integration?
>>>>
>>>>> On Oct 9, 2017, at 19:35, Lance Andersen <[hidden email] <mailto:[hidden email]>> wrote:
>>>>>
>>>>> Hi Jack,
>>>>>
>>>>> UnMarshaller also has the same issue.  I would update the webrev given the number of places to help sanity check for omissions
>>>>>
>>>>> Best
>>>>> Lance
>>>>>> On Oct 8, 2017, at 9:22 PM, Jack Li <[hidden email] <mailto:[hidden email]>> wrote:
>>>>>>
>>>>>> Hi Lance,
>>>>>>
>>>>>> the change is incorrect, it should be “javax/xml/bind”.
>>>>>> thanks a lot for your finding, do you think I need to fix it and resubmit the webrev this time?
>>>>>> or can you skip this file this time and I fix it in next integration?
>>>>>>
>>>>>>> On Oct 4, 2017, at 02:09, Lance Andersen <[hidden email] <mailto:[hidden email]>> wrote:
>>>>>>>
>>>>>>> Hi Jack,
>>>>>>>
>>>>>>> Is this change correct:
>>>>>>>
>>>>>>> -------------
>>>>>>> --- old/src/java.xml.bind/share/classes/javax/xml/bind/Marshaller.java 2017-09-29 13:58:31.968185273 +0100
>>>>>>> +++ new/src/java.xml.bind/share/classes/javax/xml/bind/Marshaller.java 2017-09-29 13:58:31.676185267 +0100
>>>>>>> @@ -373,7 +373,7 @@
>>>>>>>       *      If the {@link ValidationEventHandler ValidationEventHandler}
>>>>>>>       *      returns false from its {@code handleEvent} method or the
>>>>>>>       *      {@code Marshaller} is unable to marshal {@code jaxbElement} (or any
>>>>>>> -     *      object reachable from {@code jaxbElement}).  See <a href="{@docRoot}/javax/xml/bind/Marshaller.html#elementMarshalling">
>>>>>>> +     *      object reachable from {@code jaxbElement}).  See <a href="{@docRoot}/java/xml/bind/Marshaller.html#elementMarshalling">
>>>>>>>       *      Marshalling a JAXB element</a>.
>>>>>>>
>>>>>>> ------------
>>>>>>>
>>>>>>> The URL that is being changed currently works
>>>>>>>
>>>>>>> Best
>>>>>>> Lance
>>>>>>> On Sep 29, 2017, at 10:55 PM, Jack Li <[hidden email] <mailto:[hidden email]>> wrote:
>>>>>>>
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> Please review standalone JAXB/JAXWS changes, synced to jdk/jaxws repo.
>>>>>>>>
>>>>>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8187954 <https://bugs.openjdk.java.net/browse/JDK-8187954> <https://bugs.openjdk.java.net/browse/JDK-8187954 <https://bugs.openjdk.java.net/browse/JDK-8187954>>
>>>>>>>> Webrev: http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/ <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/> <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/ <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/>>
>>>>>>>>
>>>>>>>> Summary of changes:
>>>>>>>>
>>>>>>>> jaxws/src/java.xml.bind/share/classes/javax/xml/bind/*
>>>>>>>> JDK-8186946 - Fix accessibility and other issues in the java.xml.bind module
>>>>>>>>
>>>>>>>> jaxws/src/java.xml.ws/share/classes/com/sun/xml/internal/messaging/saaj/**
>>>>>>>> JDK-8186314 - code at c.s.x.i.m.saaj.soap.MessageImpl must be modified to avoid crash after javac change
>>>>>>>> And also contains the fixes for importing nodes for SOAPDocumentFragment
>>>>>>>>
>>>>>>>>
>>>>>>>> Patch also contains several small bugfixes, not tracked in JBS.
>>>>>>>>
>>>>>>>> ----------------
>>>>>>>> Best regards
>>>>>>>> Jack Li
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> <oracle_sig_logo.gif>
>>>>>>>
>>>>>>> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>>>>>> Oracle Java Engineering 
>>>>>>> 1 Network Drive 
>>>>>>> Burlington, MA 01803
>>>>>>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif>[hidden email] <mailto:[hidden email]>
>>>>>>
>>>>>> ----------------
>>>>>> Best regards
>>>>>> Jack Li
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>> <oracle_sig_logo.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>>>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>>>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>>>> Oracle Java Engineering
>>>>> 1 Network Drive
>>>>> Burlington, MA 01803
>>>>> [hidden email] <mailto:[hidden email]>
>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>> ----------------
>>>> Best regards
>>>> Jack Li
>>>
>>> <oracle_sig_logo.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>> Oracle Java Engineering
>>> 1 Network Drive
>>> Burlington, MA 01803
>>> [hidden email] <mailto:[hidden email]>
>>>
>>>
>>>
>>
>>
>> ----------------
>> Best regards
>> Jack Li
>>
>>
>>
>>
>>
>>
>
>
> ----------------
> Best regards
> Jack Li
>
>
>
>
>
>

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
[hidden email] <mailto:[hidden email]>



Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8187954 Update JAX-WS RI integration to latest version

Lance Andersen
Hi Jack,

Overall looks OK.  I am assuming all of the test suites are passing?

Best
Lance

> On Nov 2, 2017, at 7:34 AM, Lance Andersen <[hidden email]> wrote:
>
> Hi Jack
>
> Its on my list to finish by the end of the week.
>
> Best
> Lance
>> On Nov 2, 2017, at 4:34 AM, Jack Li <[hidden email]> wrote:
>>
>> Hi Lance
>>
>> Is there anything wrong in the new webrev?
>>
>>
>>> On Oct 25, 2017, at 10:00, Jack Li <[hidden email] <mailto:[hidden email]>> wrote:
>>>
>>> Hi Lance,
>>>
>>> The webrev is updated, can you please review it again?
>>>
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8187954 <https://bugs.openjdk.java.net/browse/JDK-8187954>
>>> Webrev: http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/01 <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/01>
>>>
>>> Summary of changes:
>>>
>>> jaxws/src/java.xml.bind/share/classes/javax/xml/bind/*
>>> JDK-8186946 - Fix accessibility and other issues in the java.xml.bind module
>>>
>>> jaxws/src/java.xml.ws/share/classes/com/sun/xml/internal/messaging/saaj/**
>>> JDK-8186314 - code at c.s.x.i.m.saaj.soap.MessageImpl must be modified to avoid crash after javac change
>>> And also contains the fixes for importing nodes for SOAPDocumentFragment
>>>
>>>
>>> Patch also contains several small bugfixes, not tracked in JBS.
>>>
>>>> On Oct 11, 2017, at 18:47, Lance Andersen <[hidden email] <mailto:[hidden email]>> wrote:
>>>>
>>>> Hi Jack,
>>>>
>>>> I would prefer to see an updated webrev so that we do not inadvertently
>>>> push these changes.
>>>>
>>>> Best
>>>> Lance
>>>>> On Oct 11, 2017, at 3:26 AM, Jack Li <[hidden email] <mailto:[hidden email]>> wrote:
>>>>>
>>>>> Hi Lance
>>>>>
>>>>> I will update them in Metro repository, do I need to regenerate webrev?
>>>>> or can you skip the files this time and I fix it in next integration?
>>>>>
>>>>>> On Oct 9, 2017, at 19:35, Lance Andersen <[hidden email] <mailto:[hidden email]>> wrote:
>>>>>>
>>>>>> Hi Jack,
>>>>>>
>>>>>> UnMarshaller also has the same issue.  I would update the webrev given the number of places to help sanity check for omissions
>>>>>>
>>>>>> Best
>>>>>> Lance
>>>>>>> On Oct 8, 2017, at 9:22 PM, Jack Li <[hidden email] <mailto:[hidden email]>> wrote:
>>>>>>>
>>>>>>> Hi Lance,
>>>>>>>
>>>>>>> the change is incorrect, it should be “javax/xml/bind”.
>>>>>>> thanks a lot for your finding, do you think I need to fix it and resubmit the webrev this time?
>>>>>>> or can you skip this file this time and I fix it in next integration?
>>>>>>>
>>>>>>>> On Oct 4, 2017, at 02:09, Lance Andersen <[hidden email] <mailto:[hidden email]>> wrote:
>>>>>>>>
>>>>>>>> Hi Jack,
>>>>>>>>
>>>>>>>> Is this change correct:
>>>>>>>>
>>>>>>>> -------------
>>>>>>>> --- old/src/java.xml.bind/share/classes/javax/xml/bind/Marshaller.java 2017-09-29 13:58:31.968185273 +0100
>>>>>>>> +++ new/src/java.xml.bind/share/classes/javax/xml/bind/Marshaller.java 2017-09-29 13:58:31.676185267 +0100
>>>>>>>> @@ -373,7 +373,7 @@
>>>>>>>>      *      If the {@link ValidationEventHandler ValidationEventHandler}
>>>>>>>>      *      returns false from its {@code handleEvent} method or the
>>>>>>>>      *      {@code Marshaller} is unable to marshal {@code jaxbElement} (or any
>>>>>>>> -     *      object reachable from {@code jaxbElement}).  See <a href="{@docRoot}/javax/xml/bind/Marshaller.html#elementMarshalling">
>>>>>>>> +     *      object reachable from {@code jaxbElement}).  See <a href="{@docRoot}/java/xml/bind/Marshaller.html#elementMarshalling">
>>>>>>>>      *      Marshalling a JAXB element</a>.
>>>>>>>>
>>>>>>>> ------------
>>>>>>>>
>>>>>>>> The URL that is being changed currently works
>>>>>>>>
>>>>>>>> Best
>>>>>>>> Lance
>>>>>>>> On Sep 29, 2017, at 10:55 PM, Jack Li <[hidden email] <mailto:[hidden email]>> wrote:
>>>>>>>>
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> Please review standalone JAXB/JAXWS changes, synced to jdk/jaxws repo.
>>>>>>>>>
>>>>>>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8187954 <https://bugs.openjdk.java.net/browse/JDK-8187954> <https://bugs.openjdk.java.net/browse/JDK-8187954 <https://bugs.openjdk.java.net/browse/JDK-8187954>>
>>>>>>>>> Webrev: http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/ <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/> <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/ <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/>>
>>>>>>>>>
>>>>>>>>> Summary of changes:
>>>>>>>>>
>>>>>>>>> jaxws/src/java.xml.bind/share/classes/javax/xml/bind/*
>>>>>>>>> JDK-8186946 - Fix accessibility and other issues in the java.xml.bind module
>>>>>>>>>
>>>>>>>>> jaxws/src/java.xml.ws/share/classes/com/sun/xml/internal/messaging/saaj/**
>>>>>>>>> JDK-8186314 - code at c.s.x.i.m.saaj.soap.MessageImpl must be modified to avoid crash after javac change
>>>>>>>>> And also contains the fixes for importing nodes for SOAPDocumentFragment
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Patch also contains several small bugfixes, not tracked in JBS.
>>>>>>>>>
>>>>>>>>> ----------------
>>>>>>>>> Best regards
>>>>>>>>> Jack Li
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> <oracle_sig_logo.gif>
>>>>>>>>
>>>>>>>> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>>>>>>> Oracle Java Engineering
>>>>>>>> 1 Network Drive
>>>>>>>> Burlington, MA 01803
>>>>>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>[hidden email] <mailto:[hidden email]>
>>>>>>>
>>>>>>> ----------------
>>>>>>> Best regards
>>>>>>> Jack Li
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>> <oracle_sig_logo.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>>>>> Oracle Java Engineering
>>>>>> 1 Network Drive
>>>>>> Burlington, MA 01803
>>>>>> [hidden email] <mailto:[hidden email]>
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> ----------------
>>>>> Best regards
>>>>> Jack Li
>>>>
>>>> <oracle_sig_logo.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>>> Oracle Java Engineering
>>>> 1 Network Drive
>>>> Burlington, MA 01803
>>>> [hidden email] <mailto:[hidden email]>
>>>>
>>>>
>>>>
>>>
>>>
>>> ----------------
>>> Best regards
>>> Jack Li
>>>
>>>
>>>
>>>
>>>
>>>
>>
>>
>> ----------------
>> Best regards
>> Jack Li
>>
>>
>>
>>
>>
>>
>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> [hidden email] <mailto:[hidden email]>
>
>
>

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
[hidden email] <mailto:[hidden email]>



Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8187954 Update JAX-WS RI integration to latest version

Jack Li

Yes, all the tests are passed.


> 在 2017年11月6日,05:05,Lance Andersen <[hidden email]> 写道:
>
> Hi Jack,
>
> Overall looks OK.  I am assuming all of the test suites are passing?
>
> Best
> Lance
>> On Nov 2, 2017, at 7:34 AM, Lance Andersen <[hidden email]> wrote:
>>
>> Hi Jack
>>
>> Its on my list to finish by the end of the week.
>>
>> Best
>> Lance
>>> On Nov 2, 2017, at 4:34 AM, Jack Li <[hidden email]> wrote:
>>>
>>> Hi Lance
>>>
>>> Is there anything wrong in the new webrev?
>>>
>>>
>>>> On Oct 25, 2017, at 10:00, Jack Li <[hidden email] <mailto:[hidden email]>> wrote:
>>>>
>>>> Hi Lance,
>>>>
>>>> The webrev is updated, can you please review it again?
>>>>
>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8187954 <https://bugs.openjdk.java.net/browse/JDK-8187954>
>>>> Webrev: http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/01 <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/01>
>>>>
>>>> Summary of changes:
>>>>
>>>> jaxws/src/java.xml.bind/share/classes/javax/xml/bind/*
>>>> JDK-8186946 - Fix accessibility and other issues in the java.xml.bind module
>>>>
>>>> jaxws/src/java.xml.ws/share/classes/com/sun/xml/internal/messaging/saaj/**
>>>> JDK-8186314 - code at c.s.x.i.m.saaj.soap.MessageImpl must be modified to avoid crash after javac change
>>>> And also contains the fixes for importing nodes for SOAPDocumentFragment
>>>>
>>>>
>>>> Patch also contains several small bugfixes, not tracked in JBS.
>>>>
>>>>> On Oct 11, 2017, at 18:47, Lance Andersen <[hidden email] <mailto:[hidden email]>> wrote:
>>>>>
>>>>> Hi Jack,
>>>>>
>>>>> I would prefer to see an updated webrev so that we do not inadvertently
>>>>> push these changes.
>>>>>
>>>>> Best
>>>>> Lance
>>>>>> On Oct 11, 2017, at 3:26 AM, Jack Li <[hidden email] <mailto:[hidden email]>> wrote:
>>>>>>
>>>>>> Hi Lance
>>>>>>
>>>>>> I will update them in Metro repository, do I need to regenerate webrev?
>>>>>> or can you skip the files this time and I fix it in next integration?
>>>>>>
>>>>>>> On Oct 9, 2017, at 19:35, Lance Andersen <[hidden email] <mailto:[hidden email]>> wrote:
>>>>>>>
>>>>>>> Hi Jack,
>>>>>>>
>>>>>>> UnMarshaller also has the same issue.  I would update the webrev given the number of places to help sanity check for omissions
>>>>>>>
>>>>>>> Best
>>>>>>> Lance
>>>>>>>> On Oct 8, 2017, at 9:22 PM, Jack Li <[hidden email] <mailto:[hidden email]>> wrote:
>>>>>>>>
>>>>>>>> Hi Lance,
>>>>>>>>
>>>>>>>> the change is incorrect, it should be “javax/xml/bind”.
>>>>>>>> thanks a lot for your finding, do you think I need to fix it and resubmit the webrev this time?
>>>>>>>> or can you skip this file this time and I fix it in next integration?
>>>>>>>>
>>>>>>>>> On Oct 4, 2017, at 02:09, Lance Andersen <[hidden email] <mailto:[hidden email]>> wrote:
>>>>>>>>>
>>>>>>>>> Hi Jack,
>>>>>>>>>
>>>>>>>>> Is this change correct:
>>>>>>>>>
>>>>>>>>> -------------
>>>>>>>>> --- old/src/java.xml.bind/share/classes/javax/xml/bind/Marshaller.java 2017-09-29 13:58:31.968185273 +0100
>>>>>>>>> +++ new/src/java.xml.bind/share/classes/javax/xml/bind/Marshaller.java 2017-09-29 13:58:31.676185267 +0100
>>>>>>>>> @@ -373,7 +373,7 @@
>>>>>>>>>      *      If the {@link ValidationEventHandler ValidationEventHandler}
>>>>>>>>>      *      returns false from its {@code handleEvent} method or the
>>>>>>>>>      *      {@code Marshaller} is unable to marshal {@code jaxbElement} (or any
>>>>>>>>> -     *      object reachable from {@code jaxbElement}).  See <a href="{@docRoot}/javax/xml/bind/Marshaller.html#elementMarshalling">
>>>>>>>>> +     *      object reachable from {@code jaxbElement}).  See <a href="{@docRoot}/java/xml/bind/Marshaller.html#elementMarshalling">
>>>>>>>>>      *      Marshalling a JAXB element</a>.
>>>>>>>>>
>>>>>>>>> ------------
>>>>>>>>>
>>>>>>>>> The URL that is being changed currently works
>>>>>>>>>
>>>>>>>>> Best
>>>>>>>>> Lance
>>>>>>>>>> On Sep 29, 2017, at 10:55 PM, Jack Li <[hidden email] <mailto:[hidden email]>> wrote:
>>>>>>>>>>
>>>>>>>>>> Hi,
>>>>>>>>>>
>>>>>>>>>> Please review standalone JAXB/JAXWS changes, synced to jdk/jaxws repo.
>>>>>>>>>>
>>>>>>>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8187954 <https://bugs.openjdk.java.net/browse/JDK-8187954> <https://bugs.openjdk.java.net/browse/JDK-8187954 <https://bugs.openjdk.java.net/browse/JDK-8187954>>
>>>>>>>>>> Webrev: http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/ <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/> <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/ <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/>>
>>>>>>>>>>
>>>>>>>>>> Summary of changes:
>>>>>>>>>>
>>>>>>>>>> jaxws/src/java.xml.bind/share/classes/javax/xml/bind/*
>>>>>>>>>> JDK-8186946 - Fix accessibility and other issues in the java.xml.bind module
>>>>>>>>>>
>>>>>>>>>> jaxws/src/java.xml.ws/share/classes/com/sun/xml/internal/messaging/saaj/**
>>>>>>>>>> JDK-8186314 - code at c.s.x.i.m.saaj.soap.MessageImpl must be modified to avoid crash after javac change
>>>>>>>>>> And also contains the fixes for importing nodes for SOAPDocumentFragment
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Patch also contains several small bugfixes, not tracked in JBS.
>>>>>>>>>>
>>>>>>>>>> ----------------
>>>>>>>>>> Best regards
>>>>>>>>>> Jack Li
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> <oracle_sig_logo.gif>
>>>>>>>>>
>>>>>>>>> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>>>>>>>> Oracle Java Engineering
>>>>>>>>> 1 Network Drive
>>>>>>>>> Burlington, MA 01803
>>>>>>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>[hidden email] <mailto:[hidden email]>
>>>>>>>>
>>>>>>>> ----------------
>>>>>>>> Best regards
>>>>>>>> Jack Li
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>> <oracle_sig_logo.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>>>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>>>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>>>>>> Oracle Java Engineering
>>>>>>> 1 Network Drive
>>>>>>> Burlington, MA 01803
>>>>>>> [hidden email] <mailto:[hidden email]>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>> ----------------
>>>>>> Best regards
>>>>>> Jack Li
>>>>>
>>>>> <oracle_sig_logo.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>>>> Oracle Java Engineering
>>>>> 1 Network Drive
>>>>> Burlington, MA 01803
>>>>> [hidden email] <mailto:[hidden email]>
>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>> ----------------
>>>> Best regards
>>>> Jack Li
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>
>>>
>>> ----------------
>>> Best regards
>>> Jack Li
>>>
>>>
>>>
>>>
>>>
>>>
>>
>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>> Oracle Java Engineering
>> 1 Network Drive
>> Burlington, MA 01803
>> [hidden email] <mailto:[hidden email]>
>>
>>
>>
>
>
>
> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> [hidden email]
>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8187954 Update JAX-WS RI integration to latest version

Jack Li
Hi Lance

Is there any other issue about it? can you approve it to merge?

> On Nov 6, 2017, at 07:59, ZhengJun Li <[hidden email]> wrote:
>
>
> Yes, all the tests are passed.
>
>
> 在 2017年11月6日,05:05,Lance Andersen <[hidden email] <mailto:[hidden email]>> 写道:
>
>> Hi Jack,
>>
>> Overall looks OK.  I am assuming all of the test suites are passing?
>>
>> Best
>> Lance
>>> On Nov 2, 2017, at 7:34 AM, Lance Andersen <[hidden email] <mailto:[hidden email]>> wrote:
>>>
>>> Hi Jack
>>>
>>> Its on my list to finish by the end of the week.
>>>
>>> Best
>>> Lance
>>>> On Nov 2, 2017, at 4:34 AM, Jack Li <[hidden email] <mailto:[hidden email]>> wrote:
>>>>
>>>> Hi Lance
>>>>
>>>> Is there anything wrong in the new webrev?
>>>>
>>>>
>>>>> On Oct 25, 2017, at 10:00, Jack Li <[hidden email] <mailto:[hidden email]> <mailto:[hidden email] <mailto:[hidden email]>>> wrote:
>>>>>
>>>>> Hi Lance,
>>>>>
>>>>> The webrev is updated, can you please review it again?
>>>>>
>>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8187954 <https://bugs.openjdk.java.net/browse/JDK-8187954> <https://bugs.openjdk.java.net/browse/JDK-8187954 <https://bugs.openjdk.java.net/browse/JDK-8187954>>
>>>>> Webrev: http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/01 <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/01> <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/01 <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/01>>
>>>>>
>>>>> Summary of changes:
>>>>>
>>>>> jaxws/src/java.xml.bind/share/classes/javax/xml/bind/*
>>>>> JDK-8186946 - Fix accessibility and other issues in the java.xml.bind module
>>>>>
>>>>> jaxws/src/java.xml.ws/share/classes/com/sun/xml/internal/messaging/saaj/**
>>>>> JDK-8186314 - code at c.s.x.i.m.saaj.soap.MessageImpl must be modified to avoid crash after javac change
>>>>> And also contains the fixes for importing nodes for SOAPDocumentFragment
>>>>>
>>>>>
>>>>> Patch also contains several small bugfixes, not tracked in JBS.
>>>>>
>>>>>> On Oct 11, 2017, at 18:47, Lance Andersen <[hidden email] <mailto:[hidden email]> <mailto:[hidden email] <mailto:[hidden email]>>> wrote:
>>>>>>
>>>>>> Hi Jack,
>>>>>>
>>>>>> I would prefer to see an updated webrev so that we do not inadvertently
>>>>>> push these changes.
>>>>>>
>>>>>> Best
>>>>>> Lance
>>>>>>> On Oct 11, 2017, at 3:26 AM, Jack Li <[hidden email] <mailto:[hidden email]> <mailto:[hidden email] <mailto:[hidden email]>>> wrote:
>>>>>>>
>>>>>>> Hi Lance
>>>>>>>
>>>>>>> I will update them in Metro repository, do I need to regenerate webrev?
>>>>>>> or can you skip the files this time and I fix it in next integration?
>>>>>>>
>>>>>>>> On Oct 9, 2017, at 19:35, Lance Andersen <[hidden email] <mailto:[hidden email]> <mailto:[hidden email] <mailto:[hidden email]>>> wrote:
>>>>>>>>
>>>>>>>> Hi Jack,
>>>>>>>>
>>>>>>>> UnMarshaller also has the same issue.  I would update the webrev given the number of places to help sanity check for omissions
>>>>>>>>
>>>>>>>> Best
>>>>>>>> Lance
>>>>>>>>> On Oct 8, 2017, at 9:22 PM, Jack Li <[hidden email] <mailto:[hidden email]> <mailto:[hidden email] <mailto:[hidden email]>>> wrote:
>>>>>>>>>
>>>>>>>>> Hi Lance,
>>>>>>>>>
>>>>>>>>> the change is incorrect, it should be “javax/xml/bind”.
>>>>>>>>> thanks a lot for your finding, do you think I need to fix it and resubmit the webrev this time?
>>>>>>>>> or can you skip this file this time and I fix it in next integration?
>>>>>>>>>
>>>>>>>>>> On Oct 4, 2017, at 02:09, Lance Andersen <[hidden email] <mailto:[hidden email]> <mailto:[hidden email] <mailto:[hidden email]>>> wrote:
>>>>>>>>>>
>>>>>>>>>> Hi Jack,
>>>>>>>>>>
>>>>>>>>>> Is this change correct:
>>>>>>>>>>
>>>>>>>>>> -------------
>>>>>>>>>> --- old/src/java.xml.bind/share/classes/javax/xml/bind/Marshaller.java 2017-09-29 13:58:31.968185273 +0100
>>>>>>>>>> +++ new/src/java.xml.bind/share/classes/javax/xml/bind/Marshaller.java 2017-09-29 13:58:31.676185267 +0100
>>>>>>>>>> @@ -373,7 +373,7 @@
>>>>>>>>>>      *      If the {@link ValidationEventHandler ValidationEventHandler}
>>>>>>>>>>      *      returns false from its {@code handleEvent} method or the
>>>>>>>>>>      *      {@code Marshaller} is unable to marshal {@code jaxbElement} (or any
>>>>>>>>>> -     *      object reachable from {@code jaxbElement}).  See <a href="{@docRoot}/javax/xml/bind/Marshaller.html#elementMarshalling">
>>>>>>>>>> +     *      object reachable from {@code jaxbElement}).  See <a href="{@docRoot}/java/xml/bind/Marshaller.html#elementMarshalling">
>>>>>>>>>>      *      Marshalling a JAXB element</a>.
>>>>>>>>>>
>>>>>>>>>> ------------
>>>>>>>>>>
>>>>>>>>>> The URL that is being changed currently works
>>>>>>>>>>
>>>>>>>>>> Best
>>>>>>>>>> Lance
>>>>>>>>>> On Sep 29, 2017, at 10:55 PM, Jack Li <[hidden email] <mailto:[hidden email]> <mailto:[hidden email] <mailto:[hidden email]>>> wrote:
>>>>>>>>>>
>>>>>>>>>>> Hi,
>>>>>>>>>>>
>>>>>>>>>>> Please review standalone JAXB/JAXWS changes, synced to jdk/jaxws repo.
>>>>>>>>>>>
>>>>>>>>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8187954 <https://bugs.openjdk.java.net/browse/JDK-8187954> <https://bugs.openjdk.java.net/browse/JDK-8187954 <https://bugs.openjdk.java.net/browse/JDK-8187954>> <https://bugs.openjdk.java.net/browse/JDK-8187954 <https://bugs.openjdk.java.net/browse/JDK-8187954> <https://bugs.openjdk.java.net/browse/JDK-8187954 <https://bugs.openjdk.java.net/browse/JDK-8187954>>>
>>>>>>>>>>> Webrev: http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/ <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/> <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/ <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/>> <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/ <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/> <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/ <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/>>>
>>>>>>>>>>>
>>>>>>>>>>> Summary of changes:
>>>>>>>>>>>
>>>>>>>>>>> jaxws/src/java.xml.bind/share/classes/javax/xml/bind/*
>>>>>>>>>>> JDK-8186946 - Fix accessibility and other issues in the java.xml.bind module
>>>>>>>>>>>
>>>>>>>>>>> jaxws/src/java.xml.ws/share/classes/com/sun/xml/internal/messaging/saaj/**
>>>>>>>>>>> JDK-8186314 - code at c.s.x.i.m.saaj.soap.MessageImpl must be modified to avoid crash after javac change
>>>>>>>>>>> And also contains the fixes for importing nodes for SOAPDocumentFragment
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Patch also contains several small bugfixes, not tracked in JBS.
>>>>>>>>>>>
>>>>>>>>>>> ----------------
>>>>>>>>>>> Best regards
>>>>>>>>>>> Jack Li
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> <oracle_sig_logo.gif>
>>>>>>>>>>
>>>>>>>>>> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>>>>>>>>> Oracle Java Engineering
>>>>>>>>>> 1 Network Drive
>>>>>>>>>> Burlington, MA 01803
>>>>>>>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif>>[hidden email] <mailto:[hidden email]> <mailto:[hidden email] <mailto:[hidden email]>>
>>>>>>>>>
>>>>>>>>> ----------------
>>>>>>>>> Best regards
>>>>>>>>> Jack Li
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>> <oracle_sig_logo.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif>>
>>>>>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif>> <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif>>
>>>>>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif>>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>>>>>>> Oracle Java Engineering
>>>>>>>> 1 Network Drive
>>>>>>>> Burlington, MA 01803
>>>>>>>> [hidden email] <mailto:[hidden email]> <mailto:[hidden email] <mailto:[hidden email]>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> ----------------
>>>>>>> Best regards
>>>>>>> Jack Li
>>>>>>
>>>>>> <oracle_sig_logo.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif>>
>>>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif>> <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif>>
>>>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif>>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>>>>> Oracle Java Engineering
>>>>>> 1 Network Drive
>>>>>> Burlington, MA 01803
>>>>>> [hidden email] <mailto:[hidden email]> <mailto:[hidden email] <mailto:[hidden email]>>
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> ----------------
>>>>> Best regards
>>>>> Jack Li
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>> ----------------
>>>> Best regards
>>>> Jack Li
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>
>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif>>
>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif>> <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif>>
>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif>>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>> Oracle Java Engineering
>>> 1 Network Drive
>>> Burlington, MA 01803
>>> [hidden email] <mailto:[hidden email]> <mailto:[hidden email] <mailto:[hidden email]>>
>>>
>>>
>>>
>>
>> <oracle_sig_logo.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>> Oracle Java Engineering
>> 1 Network Drive
>> Burlington, MA 01803
>> [hidden email] <mailto:[hidden email]>
>>
>>
>>


----------------
Best regards
Jack Li






Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8187954 Update JAX-WS RI integration to latest version

Jack Li
Hi,

any response?

> On Nov 15, 2017, at 08:05, Jack Li <[hidden email]> wrote:
>
> Hi Lance
>
> Is there any other issue about it? can you approve it to merge?
>
>> On Nov 6, 2017, at 07:59, ZhengJun Li <[hidden email] <mailto:[hidden email]>> wrote:
>>
>>
>> Yes, all the tests are passed.
>>
>>
>> 在 2017年11月6日,05:05,Lance Andersen <[hidden email] <mailto:[hidden email]>> 写道:
>>
>>> Hi Jack,
>>>
>>> Overall looks OK.  I am assuming all of the test suites are passing?
>>>
>>> Best
>>> Lance
>>>> On Nov 2, 2017, at 7:34 AM, Lance Andersen <[hidden email] <mailto:[hidden email]>> wrote:
>>>>
>>>> Hi Jack
>>>>
>>>> Its on my list to finish by the end of the week.
>>>>
>>>> Best
>>>> Lance
>>>>> On Nov 2, 2017, at 4:34 AM, Jack Li <[hidden email] <mailto:[hidden email]>> wrote:
>>>>>
>>>>> Hi Lance
>>>>>
>>>>> Is there anything wrong in the new webrev?
>>>>>
>>>>>
>>>>>> On Oct 25, 2017, at 10:00, Jack Li <[hidden email] <mailto:[hidden email]> <mailto:[hidden email] <mailto:[hidden email]>>> wrote:
>>>>>>
>>>>>> Hi Lance,
>>>>>>
>>>>>> The webrev is updated, can you please review it again?
>>>>>>
>>>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8187954 <https://bugs.openjdk.java.net/browse/JDK-8187954> <https://bugs.openjdk.java.net/browse/JDK-8187954 <https://bugs.openjdk.java.net/browse/JDK-8187954>>
>>>>>> Webrev: http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/01 <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/01> <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/01 <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/01>>
>>>>>>
>>>>>> Summary of changes:
>>>>>>
>>>>>> jaxws/src/java.xml.bind/share/classes/javax/xml/bind/*
>>>>>> JDK-8186946 - Fix accessibility and other issues in the java.xml.bind module
>>>>>>
>>>>>> jaxws/src/java.xml.ws/share/classes/com/sun/xml/internal/messaging/saaj/**
>>>>>> JDK-8186314 - code at c.s.x.i.m.saaj.soap.MessageImpl must be modified to avoid crash after javac change
>>>>>> And also contains the fixes for importing nodes for SOAPDocumentFragment
>>>>>>
>>>>>>
>>>>>> Patch also contains several small bugfixes, not tracked in JBS.
>>>>>>
>>>>>>> On Oct 11, 2017, at 18:47, Lance Andersen <[hidden email] <mailto:[hidden email]> <mailto:[hidden email] <mailto:[hidden email]>>> wrote:
>>>>>>>
>>>>>>> Hi Jack,
>>>>>>>
>>>>>>> I would prefer to see an updated webrev so that we do not inadvertently
>>>>>>> push these changes.
>>>>>>>
>>>>>>> Best
>>>>>>> Lance
>>>>>>>> On Oct 11, 2017, at 3:26 AM, Jack Li <[hidden email] <mailto:[hidden email]> <mailto:[hidden email] <mailto:[hidden email]>>> wrote:
>>>>>>>>
>>>>>>>> Hi Lance
>>>>>>>>
>>>>>>>> I will update them in Metro repository, do I need to regenerate webrev?
>>>>>>>> or can you skip the files this time and I fix it in next integration?
>>>>>>>>
>>>>>>>>> On Oct 9, 2017, at 19:35, Lance Andersen <[hidden email] <mailto:[hidden email]> <mailto:[hidden email] <mailto:[hidden email]>>> wrote:
>>>>>>>>>
>>>>>>>>> Hi Jack,
>>>>>>>>>
>>>>>>>>> UnMarshaller also has the same issue.  I would update the webrev given the number of places to help sanity check for omissions
>>>>>>>>>
>>>>>>>>> Best
>>>>>>>>> Lance
>>>>>>>>>> On Oct 8, 2017, at 9:22 PM, Jack Li <[hidden email] <mailto:[hidden email]> <mailto:[hidden email] <mailto:[hidden email]>>> wrote:
>>>>>>>>>>
>>>>>>>>>> Hi Lance,
>>>>>>>>>>
>>>>>>>>>> the change is incorrect, it should be “javax/xml/bind”.
>>>>>>>>>> thanks a lot for your finding, do you think I need to fix it and resubmit the webrev this time?
>>>>>>>>>> or can you skip this file this time and I fix it in next integration?
>>>>>>>>>>
>>>>>>>>>>> On Oct 4, 2017, at 02:09, Lance Andersen <[hidden email] <mailto:[hidden email]> <mailto:[hidden email] <mailto:[hidden email]>>> wrote:
>>>>>>>>>>>
>>>>>>>>>>> Hi Jack,
>>>>>>>>>>>
>>>>>>>>>>> Is this change correct:
>>>>>>>>>>>
>>>>>>>>>>> -------------
>>>>>>>>>>> --- old/src/java.xml.bind/share/classes/javax/xml/bind/Marshaller.java 2017-09-29 13:58:31.968185273 +0100
>>>>>>>>>>> +++ new/src/java.xml.bind/share/classes/javax/xml/bind/Marshaller.java 2017-09-29 13:58:31.676185267 +0100
>>>>>>>>>>> @@ -373,7 +373,7 @@
>>>>>>>>>>>      *      If the {@link ValidationEventHandler ValidationEventHandler}
>>>>>>>>>>>      *      returns false from its {@code handleEvent} method or the
>>>>>>>>>>>      *      {@code Marshaller} is unable to marshal {@code jaxbElement} (or any
>>>>>>>>>>> -     *      object reachable from {@code jaxbElement}).  See <a href="{@docRoot}/javax/xml/bind/Marshaller.html#elementMarshalling">
>>>>>>>>>>> +     *      object reachable from {@code jaxbElement}).  See <a href="{@docRoot}/java/xml/bind/Marshaller.html#elementMarshalling">
>>>>>>>>>>>      *      Marshalling a JAXB element</a>.
>>>>>>>>>>>
>>>>>>>>>>> ------------
>>>>>>>>>>>
>>>>>>>>>>> The URL that is being changed currently works
>>>>>>>>>>>
>>>>>>>>>>> Best
>>>>>>>>>>> Lance
>>>>>>>>>>> On Sep 29, 2017, at 10:55 PM, Jack Li <[hidden email] <mailto:[hidden email]> <mailto:[hidden email] <mailto:[hidden email]>>> wrote:
>>>>>>>>>>>
>>>>>>>>>>>> Hi,
>>>>>>>>>>>>
>>>>>>>>>>>> Please review standalone JAXB/JAXWS changes, synced to jdk/jaxws repo.
>>>>>>>>>>>>
>>>>>>>>>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8187954 <https://bugs.openjdk.java.net/browse/JDK-8187954> <https://bugs.openjdk.java.net/browse/JDK-8187954 <https://bugs.openjdk.java.net/browse/JDK-8187954>> <https://bugs.openjdk.java.net/browse/JDK-8187954 <https://bugs.openjdk.java.net/browse/JDK-8187954> <https://bugs.openjdk.java.net/browse/JDK-8187954 <https://bugs.openjdk.java.net/browse/JDK-8187954>>>
>>>>>>>>>>>> Webrev: http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/ <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/> <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/ <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/>> <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/ <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/> <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/ <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/>>>
>>>>>>>>>>>>
>>>>>>>>>>>> Summary of changes:
>>>>>>>>>>>>
>>>>>>>>>>>> jaxws/src/java.xml.bind/share/classes/javax/xml/bind/*
>>>>>>>>>>>> JDK-8186946 - Fix accessibility and other issues in the java.xml.bind module
>>>>>>>>>>>>
>>>>>>>>>>>> jaxws/src/java.xml.ws/share/classes/com/sun/xml/internal/messaging/saaj/**
>>>>>>>>>>>> JDK-8186314 - code at c.s.x.i.m.saaj.soap.MessageImpl must be modified to avoid crash after javac change
>>>>>>>>>>>> And also contains the fixes for importing nodes for SOAPDocumentFragment
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> Patch also contains several small bugfixes, not tracked in JBS.
>>>>>>>>>>>>
>>>>>>>>>>>> ----------------
>>>>>>>>>>>> Best regards
>>>>>>>>>>>> Jack Li
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> <oracle_sig_logo.gif>
>>>>>>>>>>>
>>>>>>>>>>> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>>>>>>>>>> Oracle Java Engineering
>>>>>>>>>>> 1 Network Drive
>>>>>>>>>>> Burlington, MA 01803
>>>>>>>>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif>>[hidden email] <mailto:[hidden email]> <mailto:[hidden email] <mailto:[hidden email]>>
>>>>>>>>>>
>>>>>>>>>> ----------------
>>>>>>>>>> Best regards
>>>>>>>>>> Jack Li
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> <oracle_sig_logo.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif>>
>>>>>>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif>> <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif>>
>>>>>>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif>>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>>>>>>>> Oracle Java Engineering
>>>>>>>>> 1 Network Drive
>>>>>>>>> Burlington, MA 01803
>>>>>>>>> [hidden email] <mailto:[hidden email]> <mailto:[hidden email] <mailto:[hidden email]>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> ----------------
>>>>>>>> Best regards
>>>>>>>> Jack Li
>>>>>>>
>>>>>>> <oracle_sig_logo.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif>>
>>>>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif>> <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif>>
>>>>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif>>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>>>>>> Oracle Java Engineering
>>>>>>> 1 Network Drive
>>>>>>> Burlington, MA 01803
>>>>>>> [hidden email] <mailto:[hidden email]> <mailto:[hidden email] <mailto:[hidden email]>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>> ----------------
>>>>>> Best regards
>>>>>> Jack Li
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> ----------------
>>>>> Best regards
>>>>> Jack Li
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif>>
>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif>> <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif>>
>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif>>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>>> Oracle Java Engineering
>>>> 1 Network Drive
>>>> Burlington, MA 01803
>>>> [hidden email] <mailto:[hidden email]> <mailto:[hidden email] <mailto:[hidden email]>>
>>>>
>>>>
>>>>
>>>
>>> <oracle_sig_logo.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>> Oracle Java Engineering
>>> 1 Network Drive
>>> Burlington, MA 01803
>>> [hidden email] <mailto:[hidden email]>
>>>
>>>
>>>
>
>
> ----------------
> Best regards
> Jack Li
>
>
>
>
>
>


----------------
Best regards
Jack Li






Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8187954 Update JAX-WS RI integration to latest version

Lance Andersen
Hi Jack

I said previously that the last round of changes were OK so you are good to go

> On Nov 22, 2017, at 1:03 AM, Jack Li <[hidden email]> wrote:
>
> Hi,
>
> any response?
>
>> On Nov 15, 2017, at 08:05, Jack Li <[hidden email] <mailto:[hidden email]>> wrote:
>>
>> Hi Lance
>>
>> Is there any other issue about it? can you approve it to merge?
>>
>>> On Nov 6, 2017, at 07:59, ZhengJun Li <[hidden email] <mailto:[hidden email]>> wrote:
>>>
>>>
>>> Yes, all the tests are passed.
>>>
>>>
>>> 在 2017年11月6日,05:05,Lance Andersen <[hidden email] <mailto:[hidden email]>> 写道:
>>>
>>>> Hi Jack,
>>>>
>>>> Overall looks OK.  I am assuming all of the test suites are passing?
>>>>
>>>> Best
>>>> Lance
>>>>> On Nov 2, 2017, at 7:34 AM, Lance Andersen <[hidden email] <mailto:[hidden email]>> wrote:
>>>>>
>>>>> Hi Jack
>>>>>
>>>>> Its on my list to finish by the end of the week.
>>>>>
>>>>> Best
>>>>> Lance
>>>>>> On Nov 2, 2017, at 4:34 AM, Jack Li <[hidden email] <mailto:[hidden email]>> wrote:
>>>>>>
>>>>>> Hi Lance
>>>>>>
>>>>>> Is there anything wrong in the new webrev?
>>>>>>
>>>>>>
>>>>>>> On Oct 25, 2017, at 10:00, Jack Li <[hidden email] <mailto:[hidden email]> <mailto:[hidden email] <mailto:[hidden email]>>> wrote:
>>>>>>>
>>>>>>> Hi Lance,
>>>>>>>
>>>>>>> The webrev is updated, can you please review it again?
>>>>>>>
>>>>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8187954 <https://bugs.openjdk.java.net/browse/JDK-8187954> <https://bugs.openjdk.java.net/browse/JDK-8187954 <https://bugs.openjdk.java.net/browse/JDK-8187954>>
>>>>>>> Webrev: http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/01 <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/01> <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/01 <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/01>>
>>>>>>>
>>>>>>> Summary of changes:
>>>>>>>
>>>>>>> jaxws/src/java.xml.bind/share/classes/javax/xml/bind/*
>>>>>>> JDK-8186946 - Fix accessibility and other issues in the java.xml.bind module
>>>>>>>
>>>>>>> jaxws/src/java.xml.ws/share/classes/com/sun/xml/internal/messaging/saaj/**
>>>>>>> JDK-8186314 - code at c.s.x.i.m.saaj.soap.MessageImpl must be modified to avoid crash after javac change
>>>>>>> And also contains the fixes for importing nodes for SOAPDocumentFragment
>>>>>>>
>>>>>>>
>>>>>>> Patch also contains several small bugfixes, not tracked in JBS.
>>>>>>>
>>>>>>>> On Oct 11, 2017, at 18:47, Lance Andersen <[hidden email] <mailto:[hidden email]> <mailto:[hidden email] <mailto:[hidden email]>>> wrote:
>>>>>>>>
>>>>>>>> Hi Jack,
>>>>>>>>
>>>>>>>> I would prefer to see an updated webrev so that we do not inadvertently
>>>>>>>> push these changes.
>>>>>>>>
>>>>>>>> Best
>>>>>>>> Lance
>>>>>>>>> On Oct 11, 2017, at 3:26 AM, Jack Li <[hidden email] <mailto:[hidden email]> <mailto:[hidden email] <mailto:[hidden email]>>> wrote:
>>>>>>>>>
>>>>>>>>> Hi Lance
>>>>>>>>>
>>>>>>>>> I will update them in Metro repository, do I need to regenerate webrev?
>>>>>>>>> or can you skip the files this time and I fix it in next integration?
>>>>>>>>>
>>>>>>>>>> On Oct 9, 2017, at 19:35, Lance Andersen <[hidden email] <mailto:[hidden email]> <mailto:[hidden email] <mailto:[hidden email]>>> wrote:
>>>>>>>>>>
>>>>>>>>>> Hi Jack,
>>>>>>>>>>
>>>>>>>>>> UnMarshaller also has the same issue.  I would update the webrev given the number of places to help sanity check for omissions
>>>>>>>>>>
>>>>>>>>>> Best
>>>>>>>>>> Lance
>>>>>>>>>>> On Oct 8, 2017, at 9:22 PM, Jack Li <[hidden email] <mailto:[hidden email]> <mailto:[hidden email] <mailto:[hidden email]>>> wrote:
>>>>>>>>>>>
>>>>>>>>>>> Hi Lance,
>>>>>>>>>>>
>>>>>>>>>>> the change is incorrect, it should be “javax/xml/bind”.
>>>>>>>>>>> thanks a lot for your finding, do you think I need to fix it and resubmit the webrev this time?
>>>>>>>>>>> or can you skip this file this time and I fix it in next integration?
>>>>>>>>>>>
>>>>>>>>>>>> On Oct 4, 2017, at 02:09, Lance Andersen <[hidden email] <mailto:[hidden email]> <mailto:[hidden email] <mailto:[hidden email]>>> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>> Hi Jack,
>>>>>>>>>>>>
>>>>>>>>>>>> Is this change correct:
>>>>>>>>>>>>
>>>>>>>>>>>> -------------
>>>>>>>>>>>> --- old/src/java.xml.bind/share/classes/javax/xml/bind/Marshaller.java 2017-09-29 13:58:31.968185273 +0100
>>>>>>>>>>>> +++ new/src/java.xml.bind/share/classes/javax/xml/bind/Marshaller.java 2017-09-29 13:58:31.676185267 +0100
>>>>>>>>>>>> @@ -373,7 +373,7 @@
>>>>>>>>>>>>      *      If the {@link ValidationEventHandler ValidationEventHandler}
>>>>>>>>>>>>      *      returns false from its {@code handleEvent} method or the
>>>>>>>>>>>>      *      {@code Marshaller} is unable to marshal {@code jaxbElement} (or any
>>>>>>>>>>>> -     *      object reachable from {@code jaxbElement}).  See <a href="{@docRoot}/javax/xml/bind/Marshaller.html#elementMarshalling">
>>>>>>>>>>>> +     *      object reachable from {@code jaxbElement}).  See <a href="{@docRoot}/java/xml/bind/Marshaller.html#elementMarshalling">
>>>>>>>>>>>>      *      Marshalling a JAXB element</a>.
>>>>>>>>>>>>
>>>>>>>>>>>> ------------
>>>>>>>>>>>>
>>>>>>>>>>>> The URL that is being changed currently works
>>>>>>>>>>>>
>>>>>>>>>>>> Best
>>>>>>>>>>>> Lance
>>>>>>>>>>>> On Sep 29, 2017, at 10:55 PM, Jack Li <[hidden email] <mailto:[hidden email]> <mailto:[hidden email] <mailto:[hidden email]>>> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>> Hi,
>>>>>>>>>>>>>
>>>>>>>>>>>>> Please review standalone JAXB/JAXWS changes, synced to jdk/jaxws repo.
>>>>>>>>>>>>>
>>>>>>>>>>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8187954 <https://bugs.openjdk.java.net/browse/JDK-8187954> <https://bugs.openjdk.java.net/browse/JDK-8187954 <https://bugs.openjdk.java.net/browse/JDK-8187954>> <https://bugs.openjdk.java.net/browse/JDK-8187954 <https://bugs.openjdk.java.net/browse/JDK-8187954> <https://bugs.openjdk.java.net/browse/JDK-8187954 <https://bugs.openjdk.java.net/browse/JDK-8187954>>>
>>>>>>>>>>>>> Webrev: http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/ <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/> <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/ <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/>> <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/ <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/> <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/ <http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8187954/10/00/>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> Summary of changes:
>>>>>>>>>>>>>
>>>>>>>>>>>>> jaxws/src/java.xml.bind/share/classes/javax/xml/bind/*
>>>>>>>>>>>>> JDK-8186946 - Fix accessibility and other issues in the java.xml.bind module
>>>>>>>>>>>>>
>>>>>>>>>>>>> jaxws/src/java.xml.ws/share/classes/com/sun/xml/internal/messaging/saaj/**
>>>>>>>>>>>>> JDK-8186314 - code at c.s.x.i.m.saaj.soap.MessageImpl must be modified to avoid crash after javac change
>>>>>>>>>>>>> And also contains the fixes for importing nodes for SOAPDocumentFragment
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> Patch also contains several small bugfixes, not tracked in JBS.
>>>>>>>>>>>>>
>>>>>>>>>>>>> ----------------
>>>>>>>>>>>>> Best regards
>>>>>>>>>>>>> Jack Li
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> <oracle_sig_logo.gif>
>>>>>>>>>>>>
>>>>>>>>>>>> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>>>>>>>>>>> Oracle Java Engineering
>>>>>>>>>>>> 1 Network Drive
>>>>>>>>>>>> Burlington, MA 01803
>>>>>>>>>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif>>[hidden email] <mailto:[hidden email]> <mailto:[hidden email] <mailto:[hidden email]>>
>>>>>>>>>>>
>>>>>>>>>>> ----------------
>>>>>>>>>>> Best regards
>>>>>>>>>>> Jack Li
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> <oracle_sig_logo.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif>>
>>>>>>>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif>> <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif>>
>>>>>>>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif>>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>>>>>>>>> Oracle Java Engineering
>>>>>>>>>> 1 Network Drive
>>>>>>>>>> Burlington, MA 01803
>>>>>>>>>> [hidden email] <mailto:[hidden email]> <mailto:[hidden email] <mailto:[hidden email]>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> ----------------
>>>>>>>>> Best regards
>>>>>>>>> Jack Li
>>>>>>>>
>>>>>>>> <oracle_sig_logo.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif>>
>>>>>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif>> <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif>>
>>>>>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif>>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>>>>>>> Oracle Java Engineering
>>>>>>>> 1 Network Drive
>>>>>>>> Burlington, MA 01803
>>>>>>>> [hidden email] <mailto:[hidden email]> <mailto:[hidden email] <mailto:[hidden email]>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> ----------------
>>>>>>> Best regards
>>>>>>> Jack Li
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>> ----------------
>>>>>> Best regards
>>>>>> Jack Li
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif>>
>>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif>> <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif>>
>>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif>>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>>>> Oracle Java Engineering
>>>>> 1 Network Drive
>>>>> Burlington, MA 01803
>>>>> [hidden email] <mailto:[hidden email]> <mailto:[hidden email] <mailto:[hidden email]>>
>>>>>
>>>>>
>>>>>
>>>>
>>>> <oracle_sig_logo.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>>> Oracle Java Engineering
>>>> 1 Network Drive
>>>> Burlington, MA 01803
>>>> [hidden email] <mailto:[hidden email]>
>>>>
>>>>
>>>>
>>
>>
>> ----------------
>> Best regards
>> Jack Li
>>
>>
>>
>>
>>
>>
>
>
> ----------------
> Best regards
> Jack Li
>
>
>
>
>
>

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
[hidden email] <mailto:[hidden email]>