RFR: 8189069: regression after push of 8187403: "AssertionFailure: addr should be OopHandle"

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8189069: regression after push of 8187403: "AssertionFailure: addr should be OopHandle"

Yasumasa Suenaga-4
Hi all,

The following serviceability/sa tests are failed after 8187403:

  serviceability/sa/TestHeapDumpForInvokeDynamic.java
  serviceability/sa/TestHeapDumpForLargeArray.java
  serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java

These failures are caused by the address of HeapRegion.
The address which is passed to c'tor of HeapRegion might not be OopHandle.
So we have to switch the method of address calculation.

I uploaded webrev for this issue. Could you review it?

  http://cr.openjdk.java.net/~ysuenaga/JDK-8189069/webrev.00/


I cannot access JPRT. So I need a sponsor.


Thanks,

Yasumasa
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8189069: regression after push of 8187403: "AssertionFailure: addr should be OopHandle"

serguei.spitsyn@oracle.com
Hi Yasumasa,

Thank you for the quick fix!
It looks good.
I'll sponsor your fix after we get at least one more review.

Thanks,
Serguei


On 10/9/17 19:03, Yasumasa Suenaga wrote:

> Hi all,
>
> The following serviceability/sa tests are failed after 8187403:
>
>    serviceability/sa/TestHeapDumpForInvokeDynamic.java
>    serviceability/sa/TestHeapDumpForLargeArray.java
>    serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java
>
> These failures are caused by the address of HeapRegion.
> The address which is passed to c'tor of HeapRegion might not be OopHandle.
> So we have to switch the method of address calculation.
>
> I uploaded webrev for this issue. Could you review it?
>
>    http://cr.openjdk.java.net/~ysuenaga/JDK-8189069/webrev.00/
>
>
> I cannot access JPRT. So I need a sponsor.
>
>
> Thanks,
>
> Yasumasa

Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8189069: regression after push of 8187403: "AssertionFailure: addr should be OopHandle"

David Holmes
In reply to this post by Yasumasa Suenaga-4
Hi Yasumasa,

On 10/10/2017 12:03 PM, Yasumasa Suenaga wrote:
> Hi all,
>
> The following serviceability/sa tests are failed after 8187403:

Please ensure you add a link to the bug that introduces a failure when
creating the new bug - I've added it now.

>    serviceability/sa/TestHeapDumpForInvokeDynamic.java
>    serviceability/sa/TestHeapDumpForLargeArray.java
>    serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java

Why was this not detected before 8187403 was pushed?

> These failures are caused by the address of HeapRegion.
> The address which is passed to c'tor of HeapRegion might not be OopHandle.
> So we have to switch the method of address calculation.
>
> I uploaded webrev for this issue. Could you review it?
>
>    http://cr.openjdk.java.net/~ysuenaga/JDK-8189069/webrev.00/

The approach seems reasonable though I'm somewhat unclear on what the
possibilities for the address are.

Thanks,
David
-----

>
> I cannot access JPRT. So I need a sponsor.
>
>
> Thanks,
>
> Yasumasa
>
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8189069: regression after push of 8187403: "AssertionFailure: addr should be OopHandle"

serguei.spitsyn@oracle.com
Hi David,


On 10/9/17 20:19, David Holmes wrote:
> Hi Yasumasa,
>
> On 10/10/2017 12:03 PM, Yasumasa Suenaga wrote:
>> Hi all,
>>
>> The following serviceability/sa tests are failed after 8187403:
>
> Please ensure you add a link to the bug that introduces a failure when
> creating the new bug - I've added it now.

Thanks, David!
I've also added a link to the original mdash failures.

>> serviceability/sa/TestHeapDumpForInvokeDynamic.java
>>    serviceability/sa/TestHeapDumpForLargeArray.java
>>    serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java
>
> Why was this not detected before 8187403 was pushed?

It was a miscommunication between me and Yasumasa.
I expected him to run all the SA tests before requesting a push.

Thanks,
Serguei

>
>> These failures are caused by the address of HeapRegion.
>> The address which is passed to c'tor of HeapRegion might not be
>> OopHandle.
>> So we have to switch the method of address calculation.
>>
>> I uploaded webrev for this issue. Could you review it?
>>
>>    http://cr.openjdk.java.net/~ysuenaga/JDK-8189069/webrev.00/
>
> The approach seems reasonable though I'm somewhat unclear on what the
> possibilities for the address are.
>
> Thanks,
> David
> -----
>
>>
>> I cannot access JPRT. So I need a sponsor.
>>
>>
>> Thanks,
>>
>> Yasumasa
>>

Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8189069: regression after push of 8187403: "AssertionFailure: addr should be OopHandle"

Yasumasa Suenaga-4
Hi David, Serguei,

> It was a miscommunication between me and Yasumasa.
> I expected him to run all the SA tests before requesting a push.

Sorry, I did not run jtreg about this.
I expected JPRT runs all tests before pushing.


>> The approach seems reasonable though I'm somewhat unclear on what the
>> possibilities for the address are.

Exception stack shows that it was occurred in heap region iteration.
So I guess it might not be OopHandle when the region is not used.


Thanks,

Yasumasa


2017-10-10 13:31 GMT+09:00 [hidden email]
<[hidden email]>:

> Hi David,
>
>
> On 10/9/17 20:19, David Holmes wrote:
>>
>> Hi Yasumasa,
>>
>> On 10/10/2017 12:03 PM, Yasumasa Suenaga wrote:
>>>
>>> Hi all,
>>>
>>> The following serviceability/sa tests are failed after 8187403:
>>
>>
>> Please ensure you add a link to the bug that introduces a failure when
>> creating the new bug - I've added it now.
>
>
> Thanks, David!
> I've also added a link to the original mdash failures.
>
>>> serviceability/sa/TestHeapDumpForInvokeDynamic.java
>>>    serviceability/sa/TestHeapDumpForLargeArray.java
>>>    serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java
>>
>>
>> Why was this not detected before 8187403 was pushed?
>
>
> It was a miscommunication between me and Yasumasa.
> I expected him to run all the SA tests before requesting a push.
>
> Thanks,
> Serguei
>
>
>>
>>> These failures are caused by the address of HeapRegion.
>>> The address which is passed to c'tor of HeapRegion might not be
>>> OopHandle.
>>> So we have to switch the method of address calculation.
>>>
>>> I uploaded webrev for this issue. Could you review it?
>>>
>>>    http://cr.openjdk.java.net/~ysuenaga/JDK-8189069/webrev.00/
>>
>>
>> The approach seems reasonable though I'm somewhat unclear on what the
>> possibilities for the address are.
>>
>> Thanks,
>> David
>> -----
>>
>>>
>>> I cannot access JPRT. So I need a sponsor.
>>>
>>>
>>> Thanks,
>>>
>>> Yasumasa
>>>
>
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8189069: regression after push of 8187403: "AssertionFailure: addr should be OopHandle"

Jini George
In reply to this post by serguei.spitsyn@oracle.com
Hi Yasumasa,

The changes look fine.

Thanks,
Jini (not a Reviewer).

On 10/10/2017 7:40 AM, [hidden email] wrote:

> Hi Yasumasa,
>
> Thank you for the quick fix!
> It looks good.
> I'll sponsor your fix after we get at least one more review.
>
> Thanks,
> Serguei
>
>
> On 10/9/17 19:03, Yasumasa Suenaga wrote:
>> Hi all,
>>
>> The following serviceability/sa tests are failed after 8187403:
>>
>>    serviceability/sa/TestHeapDumpForInvokeDynamic.java
>>    serviceability/sa/TestHeapDumpForLargeArray.java
>>    serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java
>>
>> These failures are caused by the address of HeapRegion.
>> The address which is passed to c'tor of HeapRegion might not be
>> OopHandle.
>> So we have to switch the method of address calculation.
>>
>> I uploaded webrev for this issue. Could you review it?
>>
>>    http://cr.openjdk.java.net/~ysuenaga/JDK-8189069/webrev.00/
>>
>>
>> I cannot access JPRT. So I need a sponsor.
>>
>>
>> Thanks,
>>
>> Yasumasa
>