RFR: 8189431: Netbeans nb_native project needs to be adapted to new repo structure

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8189431: Netbeans nb_native project needs to be adapted to new repo structure

Thomas Stüfe-2
Hi all,

may I please have a review of this fix. This fixes the nb_native projects
and adapts them to the new repo structure (removing old dead hotspot branch
etc). It also adds a new windows x64 specific platform.

Bug:

https://bugs.openjdk.java.net/browse/JDK-8189431

Webrev:

http://cr.openjdk.java.net/~stuefe/webrevs/8189431-fix_nb_native-after-repo-change/webrev.00/webrev/

Thanks a lot!

Thomas
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8189431: Netbeans nb_native project needs to be adapted to new repo structure

Magnus Ihse Bursie
On 2017-10-17 15:46, Thomas Stüfe wrote:

> Hi all,
>
> may I please have a review of this fix. This fixes the nb_native projects
> and adapts them to the new repo structure (removing old dead hotspot branch
> etc). It also adds a new windows x64 specific platform.
>
> Bug:
>
> https://bugs.openjdk.java.net/browse/JDK-8189431
>
> Webrev:
>
> http://cr.openjdk.java.net/~stuefe/webrevs/8189431-fix_nb_native-after-repo-change/webrev.00/webrev/
It's a bit hard to manually verify the diff, but it looks right-ish, and
if you have verified that it works, I'm okay with it.

/Magnus
>
> Thanks a lot!
>
> Thomas

Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8189431: Netbeans nb_native project needs to be adapted to new repo structure

Thomas Stüfe-2
On Wed, Oct 18, 2017 at 9:50 AM, Magnus Ihse Bursie <
[hidden email]> wrote:

> On 2017-10-17 15:46, Thomas Stüfe wrote:
>
> Hi all,
>
> may I please have a review of this fix. This fixes the nb_native projects
> and adapts them to the new repo structure (removing old dead hotspot branch
> etc). It also adds a new windows x64 specific platform.
>
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8189431
>
> Webrev:
> http://cr.openjdk.java.net/~stuefe/webrevs/8189431-fix_nb_native-after-repo-change/webrev.00/webrev/
>
> It's a bit hard to manually verify the diff, but it looks right-ish, and
> if you have verified that it works, I'm okay with it.
>
>
Yes, I felt a bit guilty about posting this, but found no easy way to
simplify the diff (any ideas?). Thanks for reviewing!


> /Magnus
>
> Thanks a lot!
>
> Thomas
>
>
>