RFR: 8189734: Cleanup MarkSweep when G1 dependency is gone

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8189734: Cleanup MarkSweep when G1 dependency is gone

Stefan Johansson
Hi,

Please review this change for RFE:
https://bugs.openjdk.java.net/browse/JDK-8189734

Webrev:
http://cr.openjdk.java.net/~sjohanss/8189734/00/

Summary:
This is change is based on the changes made for JEP 307 (Parallel Full
GC for G1) and will, if reviewed, be pushed as soon as the Full GC has
been integrated. The work in JEP 307 removes the dependency G1 currently
have on the MarkSweep code. This changes removes the extra code added to
the serial full GC to handle G1 heaps.

Testing:
* Local jtreg tests hotspot_gc with and without -XX:+UseSerialGC
* Built through JPRT

Thanks,
Stefan
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8189734: Cleanup MarkSweep when G1 dependency is gone

Thomas Schatzl
Hi,

On Mon, 2017-10-23 at 15:52 +0200, Stefan Johansson wrote:

> Hi,
>
> Please review this change for RFE:
> https://bugs.openjdk.java.net/browse/JDK-8189734
>
> Webrev:
> http://cr.openjdk.java.net/~sjohanss/8189734/00/
>
> Summary:
> This is change is based on the changes made for JEP 307 (Parallel
> Full GC for G1) and will, if reviewed, be pushed as soon as the Full
> GC has been integrated. The work in JEP 307 removes the dependency G1
> currently have on the MarkSweep code. This changes removes the extra
> code added to the serial full GC to handle G1 heaps.
>
> Testing:
> * Local jtreg tests hotspot_gc with and without -XX:+UseSerialGC
> * Built through JPRT
>

  looks good

Thomas

Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8189734: Cleanup MarkSweep when G1 dependency is gone

Stefan Johansson
Thanks for the review Thomas,
Stefan

On 2017-10-24 10:21, Thomas Schatzl wrote:

> Hi,
>
> On Mon, 2017-10-23 at 15:52 +0200, Stefan Johansson wrote:
>> Hi,
>>
>> Please review this change for RFE:
>> https://bugs.openjdk.java.net/browse/JDK-8189734
>>
>> Webrev:
>> http://cr.openjdk.java.net/~sjohanss/8189734/00/
>>
>> Summary:
>> This is change is based on the changes made for JEP 307 (Parallel
>> Full GC for G1) and will, if reviewed, be pushed as soon as the Full
>> GC has been integrated. The work in JEP 307 removes the dependency G1
>> currently have on the MarkSweep code. This changes removes the extra
>> code added to the serial full GC to handle G1 heaps.
>>
>> Testing:
>> * Local jtreg tests hotspot_gc with and without -XX:+UseSerialGC
>> * Built through JPRT
>>
>    looks good
>
> Thomas
>

Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8189734: Cleanup MarkSweep when G1 dependency is gone

sangheon.kim@oracle.com
In reply to this post by Stefan Johansson
Hi Stefan,

On 10/23/2017 06:52 AM, Stefan Johansson wrote:

> Hi,
>
> Please review this change for RFE:
> https://bugs.openjdk.java.net/browse/JDK-8189734
>
> Webrev:
> http://cr.openjdk.java.net/~sjohanss/8189734/00/
>
> Summary:
> This is change is based on the changes made for JEP 307 (Parallel Full
> GC for G1) and will, if reviewed, be pushed as soon as the Full GC has
> been integrated. The work in JEP 307 removes the dependency G1
> currently have on the MarkSweep code. This changes removes the extra
> code added to the serial full GC to handle G1 heaps.
>
> Testing:
> * Local jtreg tests hotspot_gc with and without -XX:+UseSerialGC
> * Built through JPRT
Looks good.

You can update copyright year at genMarkSweep.hpp before pushing it.

Thanks,
Sangheon


>
> Thanks,
> Stefan