RFR: 8190415: [JVMCI] JVMCIRuntime::adjust_comp_level must not swallow ThreadDeath

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8190415: [JVMCI] JVMCIRuntime::adjust_comp_level must not swallow ThreadDeath

Doug Simon @ Oracle
Please review this change that fixes a JVMCI code path that was swallowing ThreadDeath exceptions and thus preventing Thread.stop from working as intended.
The webrev also contains some minor unrelated cleanup to mx_jvmci.py needed for supporting the consolidated repo.

The internal test that caught this problem is now passing.

https://bugs.openjdk.java.net/browse/JDK-8190415
http://cr.openjdk.java.net/~dnsimon/8190415/

-Doug
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8190415: [JVMCI] JVMCIRuntime::adjust_comp_level must not swallow ThreadDeath

Tobias Hartmann-2
Hi Doug,

this looks good to me.

Best regards,
Tobias

On 31.10.2017 14:05, Doug Simon wrote:

> Please review this change that fixes a JVMCI code path that was swallowing ThreadDeath exceptions and thus preventing Thread.stop from working as intended.
> The webrev also contains some minor unrelated cleanup to mx_jvmci.py needed for supporting the consolidated repo.
>
> The internal test that caught this problem is now passing.
>
> https://bugs.openjdk.java.net/browse/JDK-8190415
> http://cr.openjdk.java.net/~dnsimon/8190415/
>
> -Doug
>
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8190415: [JVMCI] JVMCIRuntime::adjust_comp_level must not swallow ThreadDeath

Tom Rodriguez-2
In reply to this post by Doug Simon @ Oracle
Looks good.

tom

Doug Simon wrote:
> Please review this change that fixes a JVMCI code path that was swallowing ThreadDeath exceptions and thus preventing Thread.stop from working as intended.
> The webrev also contains some minor unrelated cleanup to mx_jvmci.py needed for supporting the consolidated repo.
>
> The internal test that caught this problem is now passing.
>
> https://bugs.openjdk.java.net/browse/JDK-8190415
> http://cr.openjdk.java.net/~dnsimon/8190415/
>
> -Doug