You went to the trouble of checking test.src. Shouldn't CONFIG_FILE be
found relative to SRC_DIR?
+ public static final Path SRC_DIR =
+ Paths.get(System.getProperty("test.src", "src"));
+ public static final Path USER_DIR =
+ Paths.get(System.getProperty("user.dir", "."));
+ public static final Path CONFIG_FILE = Paths.get("logging.properties");
On 07/12/2017 19:15, Martin Buchholz wrote:
> I'm not a logging expert, but this change Looks Good To Me.
> > configure => configured
> + // For backward compatibility: add any handlers configure using
Fixed. Thanks for spotting that!
> A bunch of "handler" should be changed to "handlers"
Oh :-( I am ashamed. I should have proof read it. Fixed.
> + // Verify that exactly one of the two handler is a custom.Handler
> + // Verify that exactly one of the two handler is a
> + // Verify that the two handler have an id of '1'
> This code makes me think you use the identity of the Longs, but it seems
> you don't, so I would just get rid of these and use e.g. 3L instead of
> + public static final Long ONE = 1L;
> + public static final Long TWO = 2L;
> + public static final Long THREE = 3L;