RFR: 8191782: Missing deprecated options in VMDeprecatedOptions.java

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8191782: Missing deprecated options in VMDeprecatedOptions.java

Robbin Ehn
Hi all, please review.

Bug: https://bugs.openjdk.java.net/browse/JDK-8191782

Test: test/hotspot/jtreg/runtime/CommandLine/ and tier 1-5 with no unexpected failure.

Thanks, Robbin!

diff -r 2cd1c2b03782 test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java
--- a/test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java Wed Nov 22 01:12:23 2017 -0800
+++ b/test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java Wed Nov 22 21:28:36 2017 +0100
@@ -46,6 +46,11 @@
          {"MinRAMFraction",            "2"},
          {"InitialRAMFraction",        "64"},
          {"AssumeMP",                  "false"},
+        {"UseMembar",                 "true"},
+        {"FastTLABRefill",            "false"},
+        {"DeferPollingPageLoopCount", "-1"},
+        {"SafepointSpinBeforeYield",  "2000"},
+        {"DeferPollingPageLoopCount", "4000"},

          // deprecated alias flags (see also aliased_jvm_flags):
          {"DefaultMaxRAMFraction", "4"},
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8191782: Missing deprecated options in VMDeprecatedOptions.java

Daniel D. Daugherty
On 11/22/17 3:37 PM, Robbin Ehn wrote:
> Hi all, please review.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8191782
>
> Test: test/hotspot/jtreg/runtime/CommandLine/ and tier 1-5 with no
> unexpected failure.
>
> Thanks, Robbin!

Thumbs up on the change. We should put a comment in the code where
deprecated options are put to remind folks to update this test.

Dan


>
> diff -r 2cd1c2b03782
> test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java
> --- a/test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java
> Wed Nov 22 01:12:23 2017 -0800
> +++ b/test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java
> Wed Nov 22 21:28:36 2017 +0100
> @@ -46,6 +46,11 @@
>          {"MinRAMFraction",            "2"},
>          {"InitialRAMFraction",        "64"},
>          {"AssumeMP",                  "false"},
> +        {"UseMembar",                 "true"},
> +        {"FastTLABRefill",            "false"},
> +        {"DeferPollingPageLoopCount", "-1"},
> +        {"SafepointSpinBeforeYield",  "2000"},
> +        {"DeferPollingPageLoopCount", "4000"},
>
>          // deprecated alias flags (see also aliased_jvm_flags):
>          {"DefaultMaxRAMFraction", "4"},

Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8191782: Missing deprecated options in VMDeprecatedOptions.java

Robbin Ehn
Thanks Dan.

/Robbin

On 2017-11-23 01:24, Daniel D. Daugherty wrote:

> On 11/22/17 3:37 PM, Robbin Ehn wrote:
>> Hi all, please review.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8191782
>>
>> Test: test/hotspot/jtreg/runtime/CommandLine/ and tier 1-5 with no unexpected failure.
>>
>> Thanks, Robbin!
>
> Thumbs up on the change. We should put a comment in the code where
> deprecated options are put to remind folks to update this test.
>
> Dan
>
>
>>
>> diff -r 2cd1c2b03782 test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java
>> --- a/test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java Wed Nov 22 01:12:23 2017 -0800
>> +++ b/test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java Wed Nov 22 21:28:36 2017 +0100
>> @@ -46,6 +46,11 @@
>>          {"MinRAMFraction",            "2"},
>>          {"InitialRAMFraction",        "64"},
>>          {"AssumeMP",                  "false"},
>> +        {"UseMembar",                 "true"},
>> +        {"FastTLABRefill",            "false"},
>> +        {"DeferPollingPageLoopCount", "-1"},
>> +        {"SafepointSpinBeforeYield",  "2000"},
>> +        {"DeferPollingPageLoopCount", "4000"},
>>
>>          // deprecated alias flags (see also aliased_jvm_flags):
>>          {"DefaultMaxRAMFraction", "4"},
>
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8191782: Missing deprecated options in VMDeprecatedOptions.java

Marcus Larsson
In reply to this post by Robbin Ehn
Hi,

Looks good!

Thanks,
Marcus

On 2017-11-22 21:37, Robbin Ehn wrote:

> Hi all, please review.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8191782
>
> Test: test/hotspot/jtreg/runtime/CommandLine/ and tier 1-5 with no
> unexpected failure.
>
> Thanks, Robbin!
>
> diff -r 2cd1c2b03782
> test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java
> --- a/test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java
> Wed Nov 22 01:12:23 2017 -0800
> +++ b/test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java
> Wed Nov 22 21:28:36 2017 +0100
> @@ -46,6 +46,11 @@
>          {"MinRAMFraction",            "2"},
>          {"InitialRAMFraction",        "64"},
>          {"AssumeMP",                  "false"},
> +        {"UseMembar",                 "true"},
> +        {"FastTLABRefill",            "false"},
> +        {"DeferPollingPageLoopCount", "-1"},
> +        {"SafepointSpinBeforeYield",  "2000"},
> +        {"DeferPollingPageLoopCount", "4000"},
>
>          // deprecated alias flags (see also aliased_jvm_flags):
>          {"DefaultMaxRAMFraction", "4"},

Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8191782: Missing deprecated options in VMDeprecatedOptions.java

Robbin Ehn
Thanks Robbin!

On 2017-11-24 11:34, Marcus Larsson wrote:

> Hi,
>
> Looks good!
>
> Thanks,
> Marcus
>
> On 2017-11-22 21:37, Robbin Ehn wrote:
>> Hi all, please review.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8191782
>>
>> Test: test/hotspot/jtreg/runtime/CommandLine/ and tier 1-5 with no unexpected failure.
>>
>> Thanks, Robbin!
>>
>> diff -r 2cd1c2b03782 test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java
>> --- a/test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java Wed Nov 22 01:12:23 2017 -0800
>> +++ b/test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java Wed Nov 22 21:28:36 2017 +0100
>> @@ -46,6 +46,11 @@
>>          {"MinRAMFraction",            "2"},
>>          {"InitialRAMFraction",        "64"},
>>          {"AssumeMP",                  "false"},
>> +        {"UseMembar",                 "true"},
>> +        {"FastTLABRefill",            "false"},
>> +        {"DeferPollingPageLoopCount", "-1"},
>> +        {"SafepointSpinBeforeYield",  "2000"},
>> +        {"DeferPollingPageLoopCount", "4000"},
>>
>>          // deprecated alias flags (see also aliased_jvm_flags):
>>          {"DefaultMaxRAMFraction", "4"},
>
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8191782: Missing deprecated options in VMDeprecatedOptions.java

David Holmes
In reply to this post by Robbin Ehn
Late to the party but ...

On 23/11/2017 6:37 AM, Robbin Ehn wrote:

> Hi all, please review.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8191782
>
> Test: test/hotspot/jtreg/runtime/CommandLine/ and tier 1-5 with no
> unexpected failure.
>
> Thanks, Robbin!
>
> diff -r 2cd1c2b03782
> test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java
> --- a/test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java    
> Wed Nov 22 01:12:23 2017 -0800
> +++ b/test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java    
> Wed Nov 22 21:28:36 2017 +0100
> @@ -46,6 +46,11 @@
>           {"MinRAMFraction",            "2"},
>           {"InitialRAMFraction",        "64"},
>           {"AssumeMP",                  "false"},
> +        {"UseMembar",                 "true"},
> +        {"FastTLABRefill",            "false"},
> +        {"DeferPollingPageLoopCount", "-1"},
> +        {"SafepointSpinBeforeYield",  "2000"},
> +        {"DeferPollingPageLoopCount", "4000"},

Why is DeferPollingPageLoopCount in there twice??

Cheers,
David


>           // deprecated alias flags (see also aliased_jvm_flags):
>           {"DefaultMaxRAMFraction", "4"},
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8191782: Missing deprecated options in VMDeprecatedOptions.java

Robbin Ehn
Thanks, David.

I'll fix that!

/Robbin


On 2017-11-29 11:00, David Holmes wrote:

> Late to the party but ...
>
> On 23/11/2017 6:37 AM, Robbin Ehn wrote:
>> Hi all, please review.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8191782
>>
>> Test: test/hotspot/jtreg/runtime/CommandLine/ and tier 1-5 with no unexpected failure.
>>
>> Thanks, Robbin!
>>
>> diff -r 2cd1c2b03782 test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java
>> --- a/test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java Wed Nov 22 01:12:23 2017 -0800
>> +++ b/test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java Wed Nov 22 21:28:36 2017 +0100
>> @@ -46,6 +46,11 @@
>>           {"MinRAMFraction",            "2"},
>>           {"InitialRAMFraction",        "64"},
>>           {"AssumeMP",                  "false"},
>> +        {"UseMembar",                 "true"},
>> +        {"FastTLABRefill",            "false"},
>> +        {"DeferPollingPageLoopCount", "-1"},
>> +        {"SafepointSpinBeforeYield",  "2000"},
>> +        {"DeferPollingPageLoopCount", "4000"},
>
> Why is DeferPollingPageLoopCount in there twice??
>
> Cheers,
> David
>
>
>>           // deprecated alias flags (see also aliased_jvm_flags):
>>           {"DefaultMaxRAMFraction", "4"},