RFR 8191988: TLAB Refills for S390

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR 8191988: TLAB Refills for S390

JC Beyler
Hi all,

The TLAB and the inline contiguous allocations handling are different
for each architecture. On certain architectures, TLAB is never
actually never refilled (ref:
https://bugs.openjdk.java.net/browse/JDK-8190862).

The S390 patch is a cleanup code webrev, it used to set the
allow_shared_alloc variable to false and then left code there. This
cleans it up and simplifies that code path.

Bug: https://bugs.openjdk.java.net/browse/JDK-8191988
WebRev: http://cr.openjdk.java.net/~rasbold/8191988/webrev.02/

Let me know what you think and if someone could test/verify it, that
would be great.

Thanks for your help,
Jc
Reply | Threaded
Open this post in threaded view
|

Re: RFR 8191988: TLAB Refills for S390

John Paul Adrian Glaubitz
Hi JC!

On 12/20/2017 09:33 PM, JC Beyler wrote:
> WebRev: http://cr.openjdk.java.net/~rasbold/8191988/webrev.02/

This URL 404s. Did you mean: http://cr.openjdk.java.net/~rasbold/8191988/webrev.01/ ?

Adrian

--
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - [hidden email]
`. `'   Freie Universitaet Berlin - [hidden email]
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913
Reply | Threaded
Open this post in threaded view
|

Re: RFR 8191988: TLAB Refills for S390

JC Beyler
Sorry, I went too fast:

WebRev: http://cr.openjdk.java.net/~jcbeyler/8191988/webrev.02/

Thanks!
Jc

2017-12-20 12:49 GMT-08:00 John Paul Adrian Glaubitz
<[hidden email]>:

> Hi JC!
>
> On 12/20/2017 09:33 PM, JC Beyler wrote:
>> WebRev: http://cr.openjdk.java.net/~rasbold/8191988/webrev.02/
>
> This URL 404s. Did you mean: http://cr.openjdk.java.net/~rasbold/8191988/webrev.01/ ?
>
> Adrian
>
> --
>  .''`.  John Paul Adrian Glaubitz
> : :' :  Debian Developer - [hidden email]
> `. `'   Freie Universitaet Berlin - [hidden email]
>   `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913
Reply | Threaded
Open this post in threaded view
|

RE: RFR 8191988: TLAB Refills for S390

Doerr, Martin
Hi Jc,

reviewed. Looks good.
I can push it together with the PPC change.
 
Thanks and best regards,
Martin


-----Original Message-----
From: hotspot-dev [mailto:[hidden email]] On Behalf Of JC Beyler
Sent: Mittwoch, 20. Dezember 2017 22:04
To: John Paul Adrian Glaubitz <[hidden email]>
Cc: [hidden email]
Subject: Re: RFR 8191988: TLAB Refills for S390

Sorry, I went too fast:

WebRev: http://cr.openjdk.java.net/~jcbeyler/8191988/webrev.02/

Thanks!
Jc

2017-12-20 12:49 GMT-08:00 John Paul Adrian Glaubitz
<[hidden email]>:

> Hi JC!
>
> On 12/20/2017 09:33 PM, JC Beyler wrote:
>> WebRev: http://cr.openjdk.java.net/~rasbold/8191988/webrev.02/
>
> This URL 404s. Did you mean: http://cr.openjdk.java.net/~rasbold/8191988/webrev.01/ ?
>
> Adrian
>
> --
>  .''`.  John Paul Adrian Glaubitz
> : :' :  Debian Developer - [hidden email]
> `. `'   Freie Universitaet Berlin - [hidden email]
>   `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913
Reply | Threaded
Open this post in threaded view
|

RE: RFR 8191988: TLAB Refills for S390

Lindenmaier, Goetz
Hi,

thanks for doing this, especially as it fixes compiler/memoryinitialization/ZeroTLABTest.java.
Therefore this one might be a candidate to push to 10.

Looks good.

Best regards,
  Goetz.

> -----Original Message-----
> From: hotspot-dev [mailto:[hidden email]] On
> Behalf Of Doerr, Martin
> Sent: Donnerstag, 21. Dezember 2017 16:05
> To: JC Beyler <[hidden email]>; John Paul Adrian Glaubitz
> <[hidden email]>
> Cc: [hidden email]
> Subject: RE: RFR 8191988: TLAB Refills for S390
>
> Hi Jc,
>
> reviewed. Looks good.
> I can push it together with the PPC change.
>
> Thanks and best regards,
> Martin
>
>
> -----Original Message-----
> From: hotspot-dev [mailto:[hidden email]] On
> Behalf Of JC Beyler
> Sent: Mittwoch, 20. Dezember 2017 22:04
> To: John Paul Adrian Glaubitz <[hidden email]>
> Cc: [hidden email]
> Subject: Re: RFR 8191988: TLAB Refills for S390
>
> Sorry, I went too fast:
>
> WebRev: http://cr.openjdk.java.net/~jcbeyler/8191988/webrev.02/
>
> Thanks!
> Jc
>
> 2017-12-20 12:49 GMT-08:00 John Paul Adrian Glaubitz
> <[hidden email]>:
> > Hi JC!
> >
> > On 12/20/2017 09:33 PM, JC Beyler wrote:
> >> WebRev: http://cr.openjdk.java.net/~rasbold/8191988/webrev.02/
> >
> > This URL 404s. Did you mean:
> http://cr.openjdk.java.net/~rasbold/8191988/webrev.01/ ?
> >
> > Adrian
> >
> > --
> >  .''`.  John Paul Adrian Glaubitz
> > : :' :  Debian Developer - [hidden email]
> > `. `'   Freie Universitaet Berlin - [hidden email]
> >   `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913
Reply | Threaded
Open this post in threaded view
|

RE: RFR 8191988: TLAB Refills for S390

Doerr, Martin
Hi all,

I have changed priority to P3 and pushed it to jdk10 because it fixes ZeroTLAB. It will get merged into hs, later.

Thanks everyone and best regards,
Martin


-----Original Message-----
From: Lindenmaier, Goetz
Sent: Donnerstag, 21. Dezember 2017 16:28
To: Doerr, Martin <[hidden email]>; JC Beyler <[hidden email]>; John Paul Adrian Glaubitz <[hidden email]>
Cc: [hidden email]
Subject: RE: RFR 8191988: TLAB Refills for S390

Hi,

thanks for doing this, especially as it fixes compiler/memoryinitialization/ZeroTLABTest.java.
Therefore this one might be a candidate to push to 10.

Looks good.

Best regards,
  Goetz.

> -----Original Message-----
> From: hotspot-dev [mailto:[hidden email]] On
> Behalf Of Doerr, Martin
> Sent: Donnerstag, 21. Dezember 2017 16:05
> To: JC Beyler <[hidden email]>; John Paul Adrian Glaubitz
> <[hidden email]>
> Cc: [hidden email]
> Subject: RE: RFR 8191988: TLAB Refills for S390
>
> Hi Jc,
>
> reviewed. Looks good.
> I can push it together with the PPC change.
>
> Thanks and best regards,
> Martin
>
>
> -----Original Message-----
> From: hotspot-dev [mailto:[hidden email]] On
> Behalf Of JC Beyler
> Sent: Mittwoch, 20. Dezember 2017 22:04
> To: John Paul Adrian Glaubitz <[hidden email]>
> Cc: [hidden email]
> Subject: Re: RFR 8191988: TLAB Refills for S390
>
> Sorry, I went too fast:
>
> WebRev: http://cr.openjdk.java.net/~jcbeyler/8191988/webrev.02/
>
> Thanks!
> Jc
>
> 2017-12-20 12:49 GMT-08:00 John Paul Adrian Glaubitz
> <[hidden email]>:
> > Hi JC!
> >
> > On 12/20/2017 09:33 PM, JC Beyler wrote:
> >> WebRev: http://cr.openjdk.java.net/~rasbold/8191988/webrev.02/
> >
> > This URL 404s. Did you mean:
> http://cr.openjdk.java.net/~rasbold/8191988/webrev.01/ ?
> >
> > Adrian
> >
> > --
> >  .''`.  John Paul Adrian Glaubitz
> > : :' :  Debian Developer - [hidden email]
> > `. `'   Freie Universitaet Berlin - [hidden email]
> >   `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913
Reply | Threaded
Open this post in threaded view
|

Re: RFR 8191988: TLAB Refills for S390

JC Beyler
Thanks a lot all for the reviews and push :)
Jc

On Fri, Dec 22, 2017 at 3:01 AM, Doerr, Martin <[hidden email]> wrote:

> Hi all,
>
> I have changed priority to P3 and pushed it to jdk10 because it fixes ZeroTLAB. It will get merged into hs, later.
>
> Thanks everyone and best regards,
> Martin
>
>
> -----Original Message-----
> From: Lindenmaier, Goetz
> Sent: Donnerstag, 21. Dezember 2017 16:28
> To: Doerr, Martin <[hidden email]>; JC Beyler <[hidden email]>; John Paul Adrian Glaubitz <[hidden email]>
> Cc: [hidden email]
> Subject: RE: RFR 8191988: TLAB Refills for S390
>
> Hi,
>
> thanks for doing this, especially as it fixes compiler/memoryinitialization/ZeroTLABTest.java.
> Therefore this one might be a candidate to push to 10.
>
> Looks good.
>
> Best regards,
>   Goetz.
>
>> -----Original Message-----
>> From: hotspot-dev [mailto:[hidden email]] On
>> Behalf Of Doerr, Martin
>> Sent: Donnerstag, 21. Dezember 2017 16:05
>> To: JC Beyler <[hidden email]>; John Paul Adrian Glaubitz
>> <[hidden email]>
>> Cc: [hidden email]
>> Subject: RE: RFR 8191988: TLAB Refills for S390
>>
>> Hi Jc,
>>
>> reviewed. Looks good.
>> I can push it together with the PPC change.
>>
>> Thanks and best regards,
>> Martin
>>
>>
>> -----Original Message-----
>> From: hotspot-dev [mailto:[hidden email]] On
>> Behalf Of JC Beyler
>> Sent: Mittwoch, 20. Dezember 2017 22:04
>> To: John Paul Adrian Glaubitz <[hidden email]>
>> Cc: [hidden email]
>> Subject: Re: RFR 8191988: TLAB Refills for S390
>>
>> Sorry, I went too fast:
>>
>> WebRev: http://cr.openjdk.java.net/~jcbeyler/8191988/webrev.02/
>>
>> Thanks!
>> Jc
>>
>> 2017-12-20 12:49 GMT-08:00 John Paul Adrian Glaubitz
>> <[hidden email]>:
>> > Hi JC!
>> >
>> > On 12/20/2017 09:33 PM, JC Beyler wrote:
>> >> WebRev: http://cr.openjdk.java.net/~rasbold/8191988/webrev.02/
>> >
>> > This URL 404s. Did you mean:
>> http://cr.openjdk.java.net/~rasbold/8191988/webrev.01/ ?
>> >
>> > Adrian
>> >
>> > --
>> >  .''`.  John Paul Adrian Glaubitz
>> > : :' :  Debian Developer - [hidden email]
>> > `. `'   Freie Universitaet Berlin - [hidden email]
>> >   `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913