RFR: 8194069: doclint throws missing comment warnings on lines which can't even have javadoc

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8194069: doclint throws missing comment warnings on lines which can't even have javadoc

Jonathan Gibbons
Please review a simple update for JDK 10, that fixes a recently reported
issue, that doclint was reporting spurious errors related to lambda
expressions.

The fix is simple: ignore lambda expressions when scanning for doc
comments. In addition, all BlockTree nodes are also ignored, since
javadoc never analyses declarations within blocks.

The test is lightly edited from the test case provided in the bug report.

Bug: https://bugs.openjdk.java.net/browse/JDK-8194069
Webrev: http://cr.openjdk.java.net/~jjg/8194069/webrev.00/

-- Jon

Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8194069: doclint throws missing comment warnings on lines which can't even have javadoc

Kumar Srinivasan
Hi Jon,

Looks good to me.

Thanks
Kumar

On 1/3/2018 4:26 PM, Jonathan Gibbons wrote:

> Please review a simple update for JDK 10, that fixes a recently
> reported issue, that doclint was reporting spurious errors related to
> lambda expressions.
>
> The fix is simple: ignore lambda expressions when scanning for doc
> comments. In addition, all BlockTree nodes are also ignored, since
> javadoc never analyses declarations within blocks.
>
> The test is lightly edited from the test case provided in the bug report.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8194069
> Webrev: http://cr.openjdk.java.net/~jjg/8194069/webrev.00/
>
> -- Jon
>