RFR 8194268: Incorrect parameter names for synthetic methods

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR 8194268: Incorrect parameter names for synthetic methods

Liam Miller-Cushon
Hello,

that caused incorrect parameter names to be generated for synthetic methods.
As I mentioned in the bug I don't think it's a regression, but it still seems
worth cleaning up.


Thanks,
Liam
Reply | Threaded
Open this post in threaded view
|

Re: RFR 8194268: Incorrect parameter names for synthetic methods

Liam Miller-Cushon
Bump.

On Fri, Dec 29, 2017 at 2:24 PM, Liam Miller-Cushon <[hidden email]> wrote:
Hello,

that caused incorrect parameter names to be generated for synthetic methods.
As I mentioned in the bug I don't think it's a regression, but it still seems
worth cleaning up.


Thanks,
Liam

Reply | Threaded
Open this post in threaded view
|

Re: RFR 8194268: Incorrect parameter names for synthetic methods

Jan Lahoda
Sorry for delay. Seems OK to me, I'll run tests and push early next week.

Thanks,
      Jan

On 25.1.2018 19:27, Liam Miller-Cushon wrote:

> Bump.
>
> On Fri, Dec 29, 2017 at 2:24 PM, Liam Miller-Cushon <[hidden email]
> <mailto:[hidden email]>> wrote:
>
>     Hello,
>
>     This fixes a mistake in
>     http://hg.openjdk.java.net/jdk/jdk/rev/89f6aa26fd6c
>     <http://hg.openjdk.java.net/jdk/jdk/rev/89f6aa26fd6c>
>     that caused incorrect parameter names to be generated for synthetic
>     methods.
>     As I mentioned in the bug I don't think it's a regression, but it
>     still seems
>     worth cleaning up.
>
>     bug: https://bugs.openjdk.java.net/browse/JDK-8194268
>     <https://bugs.openjdk.java.net/browse/JDK-8194268>
>     webrev: http://cr.openjdk.java.net/~cushon/8194268/webrev.00/
>     <http://cr.openjdk.java.net/~cushon/8194268/webrev.00/>
>
>     Thanks,
>     Liam
>
>
Reply | Threaded
Open this post in threaded view
|

Re: RFR 8194268: Incorrect parameter names for synthetic methods

Liam Miller-Cushon
Thanks! The changeset is attached.

On Fri, Jan 26, 2018 at 10:34 AM, Jan Lahoda <[hidden email]> wrote:
Sorry for delay. Seems OK to me, I'll run tests and push early next week.

Thanks,
     Jan

On 25.1.2018 19:27, Liam Miller-Cushon wrote:
Bump.

On Fri, Dec 29, 2017 at 2:24 PM, Liam Miller-Cushon <[hidden email]
<mailto:[hidden email]>> wrote:

    Hello,

    This fixes a mistake in
    http://hg.openjdk.java.net/jdk/jdk/rev/89f6aa26fd6c
    <http://hg.openjdk.java.net/jdk/jdk/rev/89f6aa26fd6c>
    that caused incorrect parameter names to be generated for synthetic
    methods.
    As I mentioned in the bug I don't think it's a regression, but it
    still seems
    worth cleaning up.

    bug: https://bugs.openjdk.java.net/browse/JDK-8194268
    <https://bugs.openjdk.java.net/browse/JDK-8194268>
    webrev: http://cr.openjdk.java.net/~cushon/8194268/webrev.00/
    <http://cr.openjdk.java.net/~cushon/8194268/webrev.00/>

    Thanks,
    Liam




8194268.patch (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: RFR 8194268: Incorrect parameter names for synthetic methods

Vicente Romero-2
looks good, I can help pushing it

Vicente

On 01/26/2018 02:30 PM, Liam Miller-Cushon wrote:
Thanks! The changeset is attached.

On Fri, Jan 26, 2018 at 10:34 AM, Jan Lahoda <[hidden email]> wrote:
Sorry for delay. Seems OK to me, I'll run tests and push early next week.

Thanks,
     Jan

On 25.1.2018 19:27, Liam Miller-Cushon wrote:
Bump.

On Fri, Dec 29, 2017 at 2:24 PM, Liam Miller-Cushon <[hidden email]
<mailto:[hidden email]>> wrote:

    Hello,

    This fixes a mistake in
    http://hg.openjdk.java.net/jdk/jdk/rev/89f6aa26fd6c
    <http://hg.openjdk.java.net/jdk/jdk/rev/89f6aa26fd6c>
    that caused incorrect parameter names to be generated for synthetic
    methods.
    As I mentioned in the bug I don't think it's a regression, but it
    still seems
    worth cleaning up.

    bug: https://bugs.openjdk.java.net/browse/JDK-8194268
    <https://bugs.openjdk.java.net/browse/JDK-8194268>
    webrev: http://cr.openjdk.java.net/~cushon/8194268/webrev.00/
    <http://cr.openjdk.java.net/~cushon/8194268/webrev.00/>

    Thanks,
    Liam




Reply | Threaded
Open this post in threaded view
|

Re: RFR 8194268: Incorrect parameter names for synthetic methods

Jan Lahoda
I've just pushed the change:
http://hg.openjdk.java.net/jdk/jdk/rev/b2f2bdba0472

Thanks for the patch and for the offer for help.

Jan

On 30.1.2018 14:42, Vicente Romero wrote:

> looks good, I can help pushing it
>
> Vicente
>
> On 01/26/2018 02:30 PM, Liam Miller-Cushon wrote:
>> Thanks! The changeset is attached.
>>
>> On Fri, Jan 26, 2018 at 10:34 AM, Jan Lahoda <[hidden email]
>> <mailto:[hidden email]>> wrote:
>>
>>     Sorry for delay. Seems OK to me, I'll run tests and push early
>>     next week.
>>
>>     Thanks,
>>          Jan
>>
>>     On 25.1.2018 19:27, Liam Miller-Cushon wrote:
>>
>>         Bump.
>>
>>         On Fri, Dec 29, 2017 at 2:24 PM, Liam Miller-Cushon
>>         <[hidden email] <mailto:[hidden email]>
>>         <mailto:[hidden email] <mailto:[hidden email]>>> wrote:
>>
>>             Hello,
>>
>>             This fixes a mistake in
>>         http://hg.openjdk.java.net/jdk/jdk/rev/89f6aa26fd6c
>>         <http://hg.openjdk.java.net/jdk/jdk/rev/89f6aa26fd6c>
>>             <http://hg.openjdk.java.net/jdk/jdk/rev/89f6aa26fd6c
>>         <http://hg.openjdk.java.net/jdk/jdk/rev/89f6aa26fd6c>>
>>             that caused incorrect parameter names to be generated for
>>         synthetic
>>             methods.
>>             As I mentioned in the bug I don't think it's a regression,
>>         but it
>>             still seems
>>             worth cleaning up.
>>
>>             bug: https://bugs.openjdk.java.net/browse/JDK-8194268
>>         <https://bugs.openjdk.java.net/browse/JDK-8194268>
>>             <https://bugs.openjdk.java.net/browse/JDK-8194268
>>         <https://bugs.openjdk.java.net/browse/JDK-8194268>>
>>             webrev:
>>         http://cr.openjdk.java.net/~cushon/8194268/webrev.00/
>>         <http://cr.openjdk.java.net/%7Ecushon/8194268/webrev.00/>
>>             <http://cr.openjdk.java.net/~cushon/8194268/webrev.00/
>>         <http://cr.openjdk.java.net/%7Ecushon/8194268/webrev.00/>>
>>
>>             Thanks,
>>             Liam
>>
>>
>>
>