RFR: 8194287 and 8194286: simple test changes for the execution of these tests in a docket container

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8194287 and 8194286: simple test changes for the execution of these tests in a docket container

Kumar Srinivasan
Hi,

Please review bug fixes for 2 test bugs, which fails with a  base Linux
installation
in a docker container.

Thanks
Kumar

[1] http://cr.openjdk.java.net/~ksrini/8194287/webrev-00/
[2] http://cr.openjdk.java.net/~ksrini/8194287/cmt.txt
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8194287 and 8194286: simple test changes for the execution of these tests in a docket container

roger riggs
Hi Kumar,

RunPathTest should say *what* is missing from the environment to skip
the test.
Otherwise, the curious has to go back a read the code to figure it out.

Thanks, Roger


On 1/11/2018 6:00 PM, Kumar Srinivasan wrote:

> Hi,
>
> Please review bug fixes for 2 test bugs, which fails with a  base
> Linux installation
> in a docker container.
>
> Thanks
> Kumar
>
> [1] http://cr.openjdk.java.net/~ksrini/8194287/webrev-00/
> [2] http://cr.openjdk.java.net/~ksrini/8194287/cmt.txt

Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8194287 and 8194286: simple test changes for the execution of these tests in a docket container

Kumar Srinivasan
Hi Roger,

Thanks for looking at this.

> Hi Kumar,
>
> RunPathTest should say *what* is missing from the environment to skip
> the test.
> Otherwise, the curious has to go back a read the code to figure it out.


Actually it  *does* say *what* is missing, however it will be printed
before this message.

webrev does not quite make this clear as it gobbles up areas of the
source files which have
are not changed, please see this line, it will become apparent.

http://cr.openjdk.java.net/~ksrini/8194287/webrev-00/test/jdk/tools/launcher/RunpathTest.java.html 

line 52

Thanks
Kumar

>
> Thanks, Roger
>
>
> On 1/11/2018 6:00 PM, Kumar Srinivasan wrote:
>> Hi,
>>
>> Please review bug fixes for 2 test bugs, which fails with a base
>> Linux installation
>> in a docker container.
>>
>> Thanks
>> Kumar
>>
>> [1] http://cr.openjdk.java.net/~ksrini/8194287/webrev-00/
>> [2] http://cr.openjdk.java.net/~ksrini/8194287/cmt.txt
>

Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8194287 and 8194286: simple test changes for the execution of these tests in a docket container

roger riggs
ok, in that case, no additional Warning message is needed, the useful
warning has already been printed.

Thanks, Roger

On 1/12/2018 10:42 AM, Kumar Srinivasan wrote:

> Hi Roger,
>
> Thanks for looking at this.
>
>> Hi Kumar,
>>
>> RunPathTest should say *what* is missing from the environment to skip
>> the test.
>> Otherwise, the curious has to go back a read the code to figure it out.
>
>
> Actually it  *does* say *what* is missing, however it will be printed
> before this message.
>
> webrev does not quite make this clear as it gobbles up areas of the
> source files which have
> are not changed, please see this line, it will become apparent.
>
> http://cr.openjdk.java.net/~ksrini/8194287/webrev-00/test/jdk/tools/launcher/RunpathTest.java.html 
>
> line 52
>
> Thanks
> Kumar
>>
>> Thanks, Roger
>>
>>
>> On 1/11/2018 6:00 PM, Kumar Srinivasan wrote:
>>> Hi,
>>>
>>> Please review bug fixes for 2 test bugs, which fails with a base
>>> Linux installation
>>> in a docker container.
>>>
>>> Thanks
>>> Kumar
>>>
>>> [1] http://cr.openjdk.java.net/~ksrini/8194287/webrev-00/
>>> [2] http://cr.openjdk.java.net/~ksrini/8194287/cmt.txt
>>
>