RFR: 8194925: NMT: SummarySanityCheck test can't parse values > max_jint

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8194925: NMT: SummarySanityCheck test can't parse values > max_jint

Stefan Karlsson
Hi all,

Please review this small patch to use longs instead of ints for the
parsed committed and reserved memory.

http://cr.openjdk.java.net/~stefank/8194925/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8194925

Thanks,
StefanK
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8194925: NMT: SummarySanityCheck test can't parse values > max_jint

Aleksey Shipilev-4
On 01/11/2018 05:06 PM, Stefan Karlsson wrote:
> http://cr.openjdk.java.net/~stefank/8194925/webrev.01/

Looks trivially correct to me.

Thanks,
-Aleksey

Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8194925: NMT: SummarySanityCheck test can't parse values > max_jint

Zhengyu Gu-2
Good to me too.

Thanks,

-Zhengyu

On 01/11/2018 11:11 AM, Aleksey Shipilev wrote:
> On 01/11/2018 05:06 PM, Stefan Karlsson wrote:
>> http://cr.openjdk.java.net/~stefank/8194925/webrev.01/
>
> Looks trivially correct to me.
>
> Thanks,
> -Aleksey
>
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8194925: NMT: SummarySanityCheck test can't parse values > max_jint

Stefan Karlsson
In reply to this post by Aleksey Shipilev-4
Thanks for the review!

StefanK

On 2018-01-11 17:11, Aleksey Shipilev wrote:
> On 01/11/2018 05:06 PM, Stefan Karlsson wrote:
>> http://cr.openjdk.java.net/~stefank/8194925/webrev.01/
>
> Looks trivially correct to me.
>
> Thanks,
> -Aleksey
>
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8194925: NMT: SummarySanityCheck test can't parse values > max_jint

Stefan Karlsson
In reply to this post by Zhengyu Gu-2
Thanks for the review!

StefanK


On 2018-01-11 17:15, Zhengyu Gu wrote:

> Good to me too.
>
> Thanks,
>
> -Zhengyu
>
> On 01/11/2018 11:11 AM, Aleksey Shipilev wrote:
>> On 01/11/2018 05:06 PM, Stefan Karlsson wrote:
>>> http://cr.openjdk.java.net/~stefank/8194925/webrev.01/
>>
>> Looks trivially correct to me.
>>
>> Thanks,
>> -Aleksey
>>