RFR: 8198317: Enhance JavacTool.getTask for flexibility

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8198317: Enhance JavacTool.getTask for flexibility

Jan Lahoda-3
This is a clone of https://github.com/openjdk/jdk/pull/1896, which got closed by Skara.

@lgxbslgx, please let me know if you would prefer to resubmit the PR yourself.

-------------

Commit messages:
 - Revise test code. Fix typo.
 - Revise test.
 - Add a test case.
 - 8198317: Enhance JavacTool.getTask for flexibility

Changes: https://git.openjdk.java.net/jdk/pull/2871/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2871&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8198317
  Stats: 137 lines in 2 files changed: 135 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2871.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2871/head:pull/2871

PR: https://git.openjdk.java.net/jdk/pull/2871
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8198317: Enhance JavacTool.getTask for flexibility

liach
On Mon, 8 Mar 2021 11:21:38 GMT, Jan Lahoda <[hidden email]> wrote:

> This is a clone of https://github.com/openjdk/jdk/pull/1896, which got closed by Skara.
>
> @lgxbslgx, please let me know if you would prefer to resubmit the PR yourself.

test/langtools/tools/javac/api/8198317/T8198317.java line 54:

> 52: import static toolbox.ToolBox.lineSeparator;
> 53:
> 54: public class T8198317 extends TestRunner{

formatting

-------------

PR: https://git.openjdk.java.net/jdk/pull/2871
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8198317: Enhance JavacTool.getTask for flexibility

Jonathan Gibbons-2
In reply to this post by Jan Lahoda-3
On Mon, 8 Mar 2021 11:21:38 GMT, Jan Lahoda <[hidden email]> wrote:

> This is a clone of https://github.com/openjdk/jdk/pull/1896, which got closed by Skara.
>
> @lgxbslgx, please let me know if you would prefer to resubmit the PR yourself.

Changes requested by jjg (Reviewer).

test/langtools/tools/javac/api/8198317/T8198317.java line 54:

> 52: import static toolbox.ToolBox.lineSeparator;
> 53:
> 54: public class T8198317 extends TestRunner{

These days, it is considered bad form to base a test name on a bug number. It's better to come up with a meaningful name for the test.  That probably applies to the enclosing directory as well.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2871
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8198317: Enhance JavacTool.getTask for flexibility [v2]

Jan Lahoda-3
In reply to this post by Jan Lahoda-3
> This is a clone of https://github.com/openjdk/jdk/pull/1896, which got closed by Skara.
>
> @lgxbslgx, please let me know if you would prefer to resubmit the PR yourself.

Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:

  Updating test per review comments.

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/2871/files
  - new: https://git.openjdk.java.net/jdk/pull/2871/files/909140e1..ec3c8927

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2871&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2871&range=00-01

  Stats: 7 lines in 1 file changed: 0 ins; 3 del; 4 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2871.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2871/head:pull/2871

PR: https://git.openjdk.java.net/jdk/pull/2871
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8198317: Enhance JavacTool.getTask for flexibility

Guoxiong Li-2
In reply to this post by Jan Lahoda-3
On Mon, 8 Mar 2021 11:21:38 GMT, Jan Lahoda <[hidden email]> wrote:

> This is a clone of https://github.com/openjdk/jdk/pull/1896, which got closed by Skara.
>
> @lgxbslgx, please let me know if you would prefer to resubmit the PR yourself.

@lahodaj It is good for me to continue the work in this PR. I will assist you if you need.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2871