RFR 8205422: assert(false) failed: Bad verification_type_info

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR 8205422: assert(false) failed: Bad verification_type_info

Harold David Seigel
Hi,

Please review this fix to prevent the debug build of the JVM from
failing with an assert when the verifier tries to print a stack map
containing a bad verification type.  The verifier now prints
"BAD:<bad-verification-type-number>" for the illegal value type.

For example:

       Stackmap Table:
         same_frame(@15)
         same_locals_1_stack_item_frame(@18,BAD:9)
         same_frame(@19)

Open Webrev: http://cr.openjdk.java.net/~hseigel/bug_8205422/webrev/

JBS Bug:  https://bugs.openjdk.java.net/browse/JDK-8205422

This fix was tested with Mach5 tiers 1 and 2 tests and builds on
Linux-X64, Windows, Solaris Sparc, and Mac OS X, with tiers 3-5 tests on
Linux-x64, and with JCK-11 Lang and VM tests.

Thanks, Harold

Reply | Threaded
Open this post in threaded view
|

Re: RFR 8205422: assert(false) failed: Bad verification_type_info

Lois Foltan
This looks good Harold.
Lois

On 6/22/2018 1:49 PM, Harold David Seigel wrote:

> Hi,
>
> Please review this fix to prevent the debug build of the JVM from
> failing with an assert when the verifier tries to print a stack map
> containing a bad verification type.  The verifier now prints
> "BAD:<bad-verification-type-number>" for the illegal value type.
>
> For example:
>
>       Stackmap Table:
>         same_frame(@15)
>         same_locals_1_stack_item_frame(@18,BAD:9)
>         same_frame(@19)
>
> Open Webrev: http://cr.openjdk.java.net/~hseigel/bug_8205422/webrev/
>
> JBS Bug:  https://bugs.openjdk.java.net/browse/JDK-8205422
>
> This fix was tested with Mach5 tiers 1 and 2 tests and builds on
> Linux-X64, Windows, Solaris Sparc, and Mac OS X, with tiers 3-5 tests
> on Linux-x64, and with JCK-11 Lang and VM tests.
>
> Thanks, Harold
>

Reply | Threaded
Open this post in threaded view
|

Re: RFR 8205422: assert(false) failed: Bad verification_type_info

Harold David Seigel
Thanks Lois!

Harold


On 6/22/2018 4:32 PM, Lois Foltan wrote:

> This looks good Harold.
> Lois
>
> On 6/22/2018 1:49 PM, Harold David Seigel wrote:
>> Hi,
>>
>> Please review this fix to prevent the debug build of the JVM from
>> failing with an assert when the verifier tries to print a stack map
>> containing a bad verification type.  The verifier now prints
>> "BAD:<bad-verification-type-number>" for the illegal value type.
>>
>> For example:
>>
>>       Stackmap Table:
>>         same_frame(@15)
>>         same_locals_1_stack_item_frame(@18,BAD:9)
>>         same_frame(@19)
>>
>> Open Webrev: http://cr.openjdk.java.net/~hseigel/bug_8205422/webrev/
>>
>> JBS Bug:  https://bugs.openjdk.java.net/browse/JDK-8205422
>>
>> This fix was tested with Mach5 tiers 1 and 2 tests and builds on
>> Linux-X64, Windows, Solaris Sparc, and Mac OS X, with tiers 3-5 tests
>> on Linux-x64, and with JCK-11 Lang and VM tests.
>>
>> Thanks, Harold
>>
>

Reply | Threaded
Open this post in threaded view
|

Re: RFR 8205422: assert(false) failed: Bad verification_type_info

coleen.phillimore
In reply to this post by Harold David Seigel

http://cr.openjdk.java.net/~hseigel/bug_8205422/webrev/test/hotspot/jtreg/runtime/verifier/stackMapTableTests/StackMapTableTest.java.html

Is -verify the same as -Xverify:all ?

Other than this question, the change looks great.
Coleen

On 6/22/18 1:49 PM, Harold David Seigel wrote:

> Hi,
>
> Please review this fix to prevent the debug build of the JVM from
> failing with an assert when the verifier tries to print a stack map
> containing a bad verification type.  The verifier now prints
> "BAD:<bad-verification-type-number>" for the illegal value type.
>
> For example:
>
>       Stackmap Table:
>         same_frame(@15)
>         same_locals_1_stack_item_frame(@18,BAD:9)
>         same_frame(@19)
>
> Open Webrev: http://cr.openjdk.java.net/~hseigel/bug_8205422/webrev/
>
> JBS Bug:  https://bugs.openjdk.java.net/browse/JDK-8205422
>
> This fix was tested with Mach5 tiers 1 and 2 tests and builds on
> Linux-X64, Windows, Solaris Sparc, and Mac OS X, with tiers 3-5 tests
> on Linux-x64, and with JCK-11 Lang and VM tests.
>
> Thanks, Harold
>

Reply | Threaded
Open this post in threaded view
|

Re: RFR 8205422: assert(false) failed: Bad verification_type_info

Harold David Seigel
Thanks Coleen!

 >> Is -verify the same as -Xverify:all ?

Yes.  See java.base/share/native/libjli/java.c:

             } else if (JLI_StrCmp(arg, "-verify") == 0) {
                 AddOption("-Xverify:all", NULL);

Harold
On 6/25/2018 10:16 AM, [hidden email] wrote:

>
> http://cr.openjdk.java.net/~hseigel/bug_8205422/webrev/test/hotspot/jtreg/runtime/verifier/stackMapTableTests/StackMapTableTest.java.html 
>
>
> Is -verify the same as -Xverify:all ?
>
> Other than this question, the change looks great.
> Coleen
>
> On 6/22/18 1:49 PM, Harold David Seigel wrote:
>> Hi,
>>
>> Please review this fix to prevent the debug build of the JVM from
>> failing with an assert when the verifier tries to print a stack map
>> containing a bad verification type.  The verifier now prints
>> "BAD:<bad-verification-type-number>" for the illegal value type.
>>
>> For example:
>>
>>       Stackmap Table:
>>         same_frame(@15)
>>         same_locals_1_stack_item_frame(@18,BAD:9)
>>         same_frame(@19)
>>
>> Open Webrev: http://cr.openjdk.java.net/~hseigel/bug_8205422/webrev/
>>
>> JBS Bug:  https://bugs.openjdk.java.net/browse/JDK-8205422
>>
>> This fix was tested with Mach5 tiers 1 and 2 tests and builds on
>> Linux-X64, Windows, Solaris Sparc, and Mac OS X, with tiers 3-5 tests
>> on Linux-x64, and with JCK-11 Lang and VM tests.
>>
>> Thanks, Harold
>>
>