RFR: 8206179: com/sun/management/OperatingSystemMXBean/GetCommittedVirtualMemorySize.java fails with Committed virtual memory size illegal value

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8206179: com/sun/management/OperatingSystemMXBean/GetCommittedVirtualMemorySize.java fails with Committed virtual memory size illegal value

Daniil Titov
Please review the change that fixes the failure of the test.

The test assumes that the amount of the virtual memory committed to the process could not
be greater than the total of the RAM and the swap size the machine has, however, it is not
correct if, for example, the process uses a memory-mapped file.

That results in the test failure on the machines where the total of the RAM and the size of the swap
file is less than the memory committed to the test process.

Webrev: https://cr.openjdk.java.net/~dtitov/8206179/webrev.01/
Bug: https://bugs.openjdk.java.net/browse/JDK-8206179

Thanks,
--Daniil


Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8206179: com/sun/management/OperatingSystemMXBean/GetCommittedVirtualMemorySize.java fails with Committed virtual memory size illegal value

serguei.spitsyn@oracle.com
Hi Daniil,

It looks good to me.

Thanks,
Serguei


On 7/16/19 4:12 PM, Daniil Titov wrote:

> Please review the change that fixes the failure of the test.
>
> The test assumes that the amount of the virtual memory committed to the process could not
> be greater than the total of the RAM and the swap size the machine has, however, it is not
> correct if, for example, the process uses a memory-mapped file.
>
> That results in the test failure on the machines where the total of the RAM and the size of the swap
> file is less than the memory committed to the test process.
>
> Webrev: https://cr.openjdk.java.net/~dtitov/8206179/webrev.01/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8206179
>
> Thanks,
> --Daniil
>
>

Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8206179: com/sun/management/OperatingSystemMXBean/GetCommittedVirtualMemorySize.java fails with Committed virtual memory size illegal value

Chris Plummer
In reply to this post by Daniil Titov
Looks good.

Chris

On 7/16/19 4:12 PM, Daniil Titov wrote:

> Please review the change that fixes the failure of the test.
>
> The test assumes that the amount of the virtual memory committed to the process could not
> be greater than the total of the RAM and the swap size the machine has, however, it is not
> correct if, for example, the process uses a memory-mapped file.
>
> That results in the test failure on the machines where the total of the RAM and the size of the swap
> file is less than the memory committed to the test process.
>
> Webrev: https://cr.openjdk.java.net/~dtitov/8206179/webrev.01/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8206179
>
> Thanks,
> --Daniil
>
>

Reply | Threaded
Open this post in threaded view
|

Re: 8206179: com/sun/management/OperatingSystemMXBean/GetCommittedVirtualMemorySize.java fails with Committed virtual memory size illegal value

Daniil Titov
Thank you, Chris and Serguei, for reviewing this change!

Best regards,
Daniil

´╗┐On 7/16/19, 4:58 PM, "Chris Plummer" <[hidden email]> wrote:

    Looks good.
   
    Chris
   
    On 7/16/19 4:12 PM, Daniil Titov wrote:
    > Please review the change that fixes the failure of the test.
    >
    > The test assumes that the amount of the virtual memory committed to the process could not
    > be greater than the total of the RAM and the swap size the machine has, however, it is not
    > correct if, for example, the process uses a memory-mapped file.
    >
    > That results in the test failure on the machines where the total of the RAM and the size of the swap
    > file is less than the memory committed to the test process.
    >
    > Webrev: https://cr.openjdk.java.net/~dtitov/8206179/webrev.01/
    > Bug: https://bugs.openjdk.java.net/browse/JDK-8206179
    >
    > Thanks,
    > --Daniil
    >
    >