RFR: 8224775: test/jdk/com/sun/jdi/JdwpListenTest.java failed to attach

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8224775: test/jdk/com/sun/jdi/JdwpListenTest.java failed to attach

Alex Menkov-3
The fix also partially fixes JdwpAttachTest failures (JDK-8253940).
The failures are caused by network configuration changes during test execution ("global" IPv6 addresses disappears from interface).
To minimize chances of intermittent failures like this java.net tests use only link-local addresses whenever possible.
The fix does the same for JDI tests (Utils.getAddressesWithSymbolicAndNumericScopes  is used by JdwpListenTest and JdwpAttachTest)

-------------

Commit messages:
 - test only IPv6 link-local addresses

Changes: https://git.openjdk.java.net/jdk/pull/2633/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2633&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8224775
  Stats: 14 lines in 1 file changed: 3 ins; 0 del; 11 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2633.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2633/head:pull/2633

PR: https://git.openjdk.java.net/jdk/pull/2633
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8224775: test/jdk/com/sun/jdi/JdwpListenTest.java failed to attach

Alex Menkov-3
On Thu, 18 Feb 2021 21:43:00 GMT, Alex Menkov <[hidden email]> wrote:

> The fix also partially fixes JdwpAttachTest failures (JDK-8253940).
> The failures are caused by network configuration changes during test execution ("global" IPv6 addresses disappears from interface).
> To minimize chances of intermittent failures like this java.net tests use only link-local addresses whenever possible.
> The fix does the same for JDI tests (Utils.getAddressesWithSymbolicAndNumericScopes  is used by JdwpListenTest and JdwpAttachTest)

Added serviceability and net as this is JDI tests, but the issue is networking-related

-------------

PR: https://git.openjdk.java.net/jdk/pull/2633
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8224775: test/jdk/com/sun/jdi/JdwpListenTest.java failed to attach

Serguei Spitsyn-2
In reply to this post by Alex Menkov-3
On Thu, 18 Feb 2021 21:43:00 GMT, Alex Menkov <[hidden email]> wrote:

> The fix also partially fixes JdwpAttachTest failures (JDK-8253940).
> The failures are caused by network configuration changes during test execution ("global" IPv6 addresses disappears from interface).
> To minimize chances of intermittent failures like this java.net tests use only link-local addresses whenever possible.
> The fix does the same for JDI tests (Utils.getAddressesWithSymbolicAndNumericScopes  is used by JdwpListenTest and JdwpAttachTest)

Looks good.
Thanks,
Serguei

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2633
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8224775: test/jdk/com/sun/jdi/JdwpListenTest.java failed to attach

Daniel Fuchs-2
In reply to this post by Alex Menkov-3
On Thu, 18 Feb 2021 21:43:00 GMT, Alex Menkov <[hidden email]> wrote:

> The fix also partially fixes JdwpAttachTest failures (JDK-8253940).
> The failures are caused by network configuration changes during test execution ("global" IPv6 addresses disappears from interface).
> To minimize chances of intermittent failures like this java.net tests use only link-local addresses whenever possible.
> The fix does the same for JDI tests (Utils.getAddressesWithSymbolicAndNumericScopes  is used by JdwpListenTest and JdwpAttachTest)

I don't see any specific issue with the proposed change but I don't know the JDWP tests enough to provide more feedback than that. Do you have special test cases for the IPv6 loopback? AFAIU this code here will filter it out?

-------------

PR: https://git.openjdk.java.net/jdk/pull/2633
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8224775: test/jdk/com/sun/jdi/JdwpListenTest.java failed to attach

Alex Menkov-3
On Mon, 22 Feb 2021 17:34:03 GMT, Daniel Fuchs <[hidden email]> wrote:

>
>
> I don't see any specific issue with the proposed change but I don't know the JDWP tests enough to provide more feedback than that. Do you have special test cases for the IPv6 loopback? AFAIU this code here will filter it out?

Good catch. IPv6 loopback addresses shouldn't be filtered out.
I'll update PR after re-testing

-------------

PR: https://git.openjdk.java.net/jdk/pull/2633
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8224775: test/jdk/com/sun/jdi/JdwpListenTest.java failed to attach [v2]

Alex Menkov-3
In reply to this post by Alex Menkov-3
> The fix also partially fixes JdwpAttachTest failures (JDK-8253940).
> The failures are caused by network configuration changes during test execution ("global" IPv6 addresses disappears from interface).
> To minimize chances of intermittent failures like this java.net tests use only link-local addresses whenever possible.
> The fix does the same for JDI tests (Utils.getAddressesWithSymbolicAndNumericScopes  is used by JdwpListenTest and JdwpAttachTest)

Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:

  include loopback addresses in testing

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/2633/files
  - new: https://git.openjdk.java.net/jdk/pull/2633/files/96176a61..4d59abf6

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2633&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2633&range=00-01

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2633.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2633/head:pull/2633

PR: https://git.openjdk.java.net/jdk/pull/2633
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8224775: test/jdk/com/sun/jdi/JdwpListenTest.java failed to attach [v2]

Daniel Fuchs-2
On Mon, 22 Feb 2021 21:36:52 GMT, Alex Menkov <[hidden email]> wrote:

>> The fix also partially fixes JdwpAttachTest failures (JDK-8253940).
>> The failures are caused by network configuration changes during test execution ("global" IPv6 addresses disappears from interface).
>> To minimize chances of intermittent failures like this java.net tests use only link-local addresses whenever possible.
>> The fix does the same for JDI tests (Utils.getAddressesWithSymbolicAndNumericScopes  is used by JdwpListenTest and JdwpAttachTest)
>
> Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:
>
>   include loopback addresses in testing

The last changes look good to me.

-------------

Marked as reviewed by dfuchs (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2633
Reply | Threaded
Open this post in threaded view
|

Integrated: 8224775: test/jdk/com/sun/jdi/JdwpListenTest.java failed to attach

Alex Menkov-3
In reply to this post by Alex Menkov-3
On Thu, 18 Feb 2021 21:43:00 GMT, Alex Menkov <[hidden email]> wrote:

> The fix also partially fixes JdwpAttachTest failures (JDK-8253940).
> The failures are caused by network configuration changes during test execution ("global" IPv6 addresses disappears from interface).
> To minimize chances of intermittent failures like this java.net tests use only link-local addresses whenever possible.
> The fix does the same for JDI tests (Utils.getAddressesWithSymbolicAndNumericScopes  is used by JdwpListenTest and JdwpAttachTest)

This pull request has now been integrated.

Changeset: 104a2628
Author:    Alex Menkov <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/104a2628
Stats:     14 lines in 1 file changed: 3 ins; 0 del; 11 mod

8224775: test/jdk/com/sun/jdi/JdwpListenTest.java failed to attach

Reviewed-by: sspitsyn, dfuchs

-------------

PR: https://git.openjdk.java.net/jdk/pull/2633