RFR: 8227815: Minimal VM: set_state is not a member of AttachListener

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8227815: Minimal VM: set_state is not a member of AttachListener

Yasumasa Suenaga-4
Hi all,

Please review this change:

   JBS: https://bugs.openjdk.java.net/browse/JDK-8227815
   webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8227815/webrev.00/

After JDK-8225690, minimal VM could not be built.
Minimal VM does not include Attach Listener implementation. So I exclude it in os.cpp with INCLUDE_SERVICES macro.


Thanks,

Yasumasa
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8227815: Minimal VM: set_state is not a member of AttachListener

Chris Plummer
Looks good.

Chris

On 7/17/19 7:37 AM, Yasumasa Suenaga wrote:

> Hi all,
>
> Please review this change:
>
>   JBS: https://bugs.openjdk.java.net/browse/JDK-8227815
>   webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8227815/webrev.00/
>
> After JDK-8225690, minimal VM could not be built.
> Minimal VM does not include Attach Listener implementation. So I
> exclude it in os.cpp with INCLUDE_SERVICES macro.
>
>
> Thanks,
>
> Yasumasa


Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8227815: Minimal VM: set_state is not a member of AttachListener

serguei.spitsyn@oracle.com
Hi Yasumasa,

+1

Thanks,
Serguei


On 7/17/19 09:11, Chris Plummer wrote:

> Looks good.
>
> Chris
>
> On 7/17/19 7:37 AM, Yasumasa Suenaga wrote:
>> Hi all,
>>
>> Please review this change:
>>
>>   JBS: https://bugs.openjdk.java.net/browse/JDK-8227815
>>   webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8227815/webrev.00/
>>
>> After JDK-8225690, minimal VM could not be built.
>> Minimal VM does not include Attach Listener implementation. So I
>> exclude it in os.cpp with INCLUDE_SERVICES macro.
>>
>>
>> Thanks,
>>
>> Yasumasa
>
>