RFR: 8228748: Remove GCLocker::_doing_gc

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8228748: Remove GCLocker::_doing_gc

Albert Mingkun Yang
Some refactoring in `GCLocker` and more comments in `jni_lock` on how the synchronization works there.

-------------

Commit messages:
 - lock

Changes: https://git.openjdk.java.net/jdk/pull/2602/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2602&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8228748
  Stats: 15 lines in 2 files changed: 4 ins; 5 del; 6 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2602.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2602/head:pull/2602

PR: https://git.openjdk.java.net/jdk/pull/2602
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8228748: Remove GCLocker::_doing_gc

Kim Barrett-2
On Wed, 17 Feb 2021 08:00:04 GMT, Albert Mingkun Yang <[hidden email]> wrote:

> Some refactoring in `GCLocker` and more comments in `jni_lock` on how the synchronization works there.

Looks good.  Copyright for gcLocker.hpp needs to be updated.

-------------

Marked as reviewed by kbarrett (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2602
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8228748: Remove GCLocker::_doing_gc [v2]

Albert Mingkun Yang
In reply to this post by Albert Mingkun Yang
> Some refactoring in `GCLocker` and more comments in `jni_lock` on how the synchronization works there.

Albert Mingkun Yang has updated the pull request incrementally with one additional commit since the last revision:

  review

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/2602/files
  - new: https://git.openjdk.java.net/jdk/pull/2602/files/17ff21e7..41081d99

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2602&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2602&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2602.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2602/head:pull/2602

PR: https://git.openjdk.java.net/jdk/pull/2602
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8228748: Remove GCLocker::_doing_gc [v2]

Ivan Walulya-2
On Sat, 20 Feb 2021 10:27:04 GMT, Albert Mingkun Yang <[hidden email]> wrote:

>> Some refactoring in `GCLocker` and more comments in `jni_lock` on how the synchronization works there.
>
> Albert Mingkun Yang has updated the pull request incrementally with one additional commit since the last revision:
>
>   review

Lgtm!

-------------

Marked as reviewed by iwalulya (Committer).

PR: https://git.openjdk.java.net/jdk/pull/2602
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8228748: Remove GCLocker::_doing_gc [v2]

Albert Mingkun Yang
On Sat, 20 Feb 2021 13:33:44 GMT, Ivan Walulya <[hidden email]> wrote:

>> Albert Mingkun Yang has updated the pull request incrementally with one additional commit since the last revision:
>>
>>   review
>
> Lgtm!

Thanks for the review.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2602
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8228748: Remove GCLocker::_doing_gc [v2]

Per Liden-2
In reply to this post by Albert Mingkun Yang
On Sat, 20 Feb 2021 10:27:04 GMT, Albert Mingkun Yang <[hidden email]> wrote:

>> Some refactoring in `GCLocker` and more comments in `jni_lock` on how the synchronization works there.
>
> Albert Mingkun Yang has updated the pull request incrementally with one additional commit since the last revision:
>
>   review

Looks good.

-------------

Marked as reviewed by pliden (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2602
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8228748: Remove GCLocker::_doing_gc [v2]

Thomas Schatzl-4
In reply to this post by Albert Mingkun Yang
On Sat, 20 Feb 2021 10:27:04 GMT, Albert Mingkun Yang <[hidden email]> wrote:

>> Some refactoring in `GCLocker` and more comments in `jni_lock` on how the synchronization works there.
>
> Albert Mingkun Yang has updated the pull request incrementally with one additional commit since the last revision:
>
>   review

Marked as reviewed by tschatzl (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2602
Reply | Threaded
Open this post in threaded view
|

Integrated: 8228748: Remove GCLocker::_doing_gc

Albert Mingkun Yang
In reply to this post by Albert Mingkun Yang
On Wed, 17 Feb 2021 08:00:04 GMT, Albert Mingkun Yang <[hidden email]> wrote:

> Some refactoring in `GCLocker` and more comments in `jni_lock` on how the synchronization works there.

This pull request has now been integrated.

Changeset: 6b7575bb
Author:    Albert Mingkun Yang <[hidden email]>
Committer: Thomas Schatzl <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/6b7575bb
Stats:     16 lines in 2 files changed: 4 ins; 5 del; 7 mod

8228748: Remove GCLocker::_doing_gc

Reviewed-by: kbarrett, iwalulya, pliden, tschatzl

-------------

PR: https://git.openjdk.java.net/jdk/pull/2602