RFR: 8236127: Use value of --icon CLI option to set icon for exe installers

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8236127: Use value of --icon CLI option to set icon for exe installers

Alexey Semenyuk-2
Use value of `--icon` jpackage CLI option to set icon for exe installers.

-------------

Commit messages:
 - 8236127: Use value of --icon CLI option to set icon for exe installers

Changes: https://git.openjdk.java.net/jdk/pull/3347/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3347&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8236127
  Stats: 205 lines in 2 files changed: 188 ins; 7 del; 10 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3347.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3347/head:pull/3347

PR: https://git.openjdk.java.net/jdk/pull/3347
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8236127: Use value of --icon CLI option to set icon for exe installers

Alexander Matveev
On Mon, 5 Apr 2021 19:46:43 GMT, Alexey Semenyuk <[hidden email]> wrote:

> Use value of `--icon` jpackage CLI option to set icon for exe installers.

Marked as reviewed by almatvee (Committer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/3347
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8236127: Use value of --icon CLI option to set icon for exe installers

Andy Herrick-2
In reply to this post by Alexey Semenyuk-2
On Mon, 5 Apr 2021 19:46:43 GMT, Alexey Semenyuk <[hidden email]> wrote:

> Use value of `--icon` jpackage CLI option to set icon for exe installers.

Marked as reviewed by herrick (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/3347
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8236127: Use value of --icon CLI option to set icon for exe installers

Andy Herrick-2
On Tue, 6 Apr 2021 14:39:07 GMT, Andy Herrick <[hidden email]> wrote:

>> Use value of `--icon` jpackage CLI option to set icon for exe installers.
>
> Marked as reviewed by herrick (Reviewer).

One question -
ICON is only a valid option for creating app launcher.  If creating an installer using --app-image option it would not be a vlid option.
Does this change imply we should change ValidOptions to change:
         options.put(CLIOptions.ICON.getId(), USE.LAUNCHER);
to
         options.put(CLIOptions.ICON.getId(), USE.ALL);

-------------

PR: https://git.openjdk.java.net/jdk/pull/3347
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8236127: Use value of --icon CLI option to set icon for exe installers

Alexey Semenyuk-2
On Tue, 6 Apr 2021 14:45:26 GMT, Andy Herrick <[hidden email]> wrote:

>> Marked as reviewed by herrick (Reviewer).
>
> One question -
> ICON is only a valid option for creating app launcher.  If creating an installer using --app-image option it would not be a vlid option.
> Does this change imply we should change ValidOptions to change:
>          options.put(CLIOptions.ICON.getId(), USE.LAUNCHER);
> to
>          options.put(CLIOptions.ICON.getId(), USE.ALL);

Good point! I'll add corresponding test case and update ValidOptions accordingly.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3347
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8236127: Use value of --icon CLI option to set icon for exe installers [v2]

Alexey Semenyuk-2
In reply to this post by Alexey Semenyuk-2
> Use value of `--icon` jpackage CLI option to set icon for exe installers.

Alexey Semenyuk has updated the pull request incrementally with one additional commit since the last revision:

  Make --icon option applicable in installer mode

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3347/files
  - new: https://git.openjdk.java.net/jdk/pull/3347/files/e88a1816..36ec66de

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3347&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3347&range=00-01

  Stats: 36 lines in 5 files changed: 21 ins; 11 del; 4 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3347.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3347/head:pull/3347

PR: https://git.openjdk.java.net/jdk/pull/3347
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8236127: Use value of --icon CLI option to set icon for exe installers [v2]

Andy Herrick-2
On Tue, 6 Apr 2021 18:01:02 GMT, Alexey Semenyuk <[hidden email]> wrote:

>> Use value of `--icon` jpackage CLI option to set icon for exe installers.
>
> Alexey Semenyuk has updated the pull request incrementally with one additional commit since the last revision:
>
>   Make --icon option applicable in installer mode

Marked as reviewed by herrick (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/3347
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8236127: Use value of --icon CLI option to set icon for exe installers [v3]

Alexey Semenyuk-2
In reply to this post by Alexey Semenyuk-2
> Use value of `--icon` jpackage CLI option to set icon for exe installers.

Alexey Semenyuk has updated the pull request incrementally with one additional commit since the last revision:

  Fix AppImagePackageTest.testEmpty(true) failure

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3347/files
  - new: https://git.openjdk.java.net/jdk/pull/3347/files/36ec66de..d05753c2

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3347&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3347&range=01-02

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3347.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3347/head:pull/3347

PR: https://git.openjdk.java.net/jdk/pull/3347
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8236127: Use value of --icon CLI option to set icon for exe installers [v3]

Andy Herrick-2
On Wed, 7 Apr 2021 00:22:14 GMT, Alexey Semenyuk <[hidden email]> wrote:

>> Use value of `--icon` jpackage CLI option to set icon for exe installers.
>
> Alexey Semenyuk has updated the pull request incrementally with one additional commit since the last revision:
>
>   Fix AppImagePackageTest.testEmpty(true) failure

Marked as reviewed by herrick (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/3347
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8236127: Use value of --icon CLI option to set icon for exe installers [v3]

Alexander Matveev
In reply to this post by Alexey Semenyuk-2
On Wed, 7 Apr 2021 00:22:14 GMT, Alexey Semenyuk <[hidden email]> wrote:

>> Use value of `--icon` jpackage CLI option to set icon for exe installers.
>
> Alexey Semenyuk has updated the pull request incrementally with one additional commit since the last revision:
>
>   Fix AppImagePackageTest.testEmpty(true) failure

Marked as reviewed by almatvee (Committer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/3347
Reply | Threaded
Open this post in threaded view
|

Integrated: 8236127: Use value of --icon CLI option to set icon for exe installers

Alexey Semenyuk-2
In reply to this post by Alexey Semenyuk-2
On Mon, 5 Apr 2021 19:46:43 GMT, Alexey Semenyuk <[hidden email]> wrote:

> Use value of `--icon` jpackage CLI option to set icon for exe installers.

This pull request has now been integrated.

Changeset: 5bd6c745
Author:    Alexey Semenyuk <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/5bd6c745
Stats:     243 lines in 8 files changed: 209 ins; 18 del; 16 mod

8236127: Use value of --icon CLI option to set icon for exe installers

Reviewed-by: almatvee, herrick

-------------

PR: https://git.openjdk.java.net/jdk/pull/3347