RFR: 8239596: PARAMETER annotation on receiver type does not cause error

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8239596: PARAMETER annotation on receiver type does not cause error

Guoxiong Li-2
Hi all,

`TypeAnnotationsValidator::visitMethodDef`  uses `checkForDeclarationAnnotations` incorrectly so that the check could not work as expected and some related errors are not reported. This patch fixes it and adds a corresponding test case.

Thank you for taking the time to review.

Best Regards.

-------------

Commit messages:
 - 8239596: PARAMETER annotation on receiver type does not cause error

Changes: https://git.openjdk.java.net/jdk/pull/1881/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1881&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8239596
  Stats: 89 lines in 2 files changed: 87 ins; 1 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1881.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1881/head:pull/1881

PR: https://git.openjdk.java.net/jdk/pull/1881
Reply | Threaded
Open this post in threaded view
|

Withdrawn: 8239596: PARAMETER annotation on receiver type does not cause error

duke
On Wed, 23 Dec 2020 17:05:51 GMT, Guoxiong Li <[hidden email]> wrote:

> Hi all,
>
> `TypeAnnotationsValidator::visitMethodDef`  uses `checkForDeclarationAnnotations` incorrectly so that the check could not work as expected and some related errors are not reported. This patch fixes it and adds a corresponding test case.
>
> Thank you for taking the time to review.
>
> Best Regards.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1881