RFR: 8248318: Examine the use of boxing in ObjectStreamClass

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8248318: Examine the use of boxing in ObjectStreamClass

Julia Boes-2
This change removes some instances of superfluous boxing in java.io.ObjectStreamClass.
Testing: tier 1-3 all clear.

-------------

Commit messages:
 - remove superfluous boxing

Changes: https://git.openjdk.java.net/jdk/pull/2641/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2641&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8248318
  Stats: 7 lines in 1 file changed: 0 ins; 0 del; 7 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2641.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2641/head:pull/2641

PR: https://git.openjdk.java.net/jdk/pull/2641
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8248318: Examine the use of boxing in ObjectStreamClass

Jim Laskey-3
On Fri, 19 Feb 2021 10:14:54 GMT, Julia Boes <[hidden email]> wrote:

> This change removes some instances of superfluous boxing in java.io.ObjectStreamClass.
> Testing: tier 1-3 all clear.

Marked as reviewed by jlaskey (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2641
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8248318: Examine the use of boxing in ObjectStreamClass

Vyom Mani Tewari
In reply to this post by Julia Boes-2
On Fri, 19 Feb 2021 10:14:54 GMT, Julia Boes <[hidden email]> wrote:

> This change removes some instances of superfluous boxing in java.io.ObjectStreamClass.
> Testing: tier 1-3 all clear.

Looks ok to me.

-------------

Marked as reviewed by [hidden email] (no known OpenJDK username).

PR: https://git.openjdk.java.net/jdk/pull/2641
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8248318: Examine the use of boxing in ObjectStreamClass

Daniel Fuchs-2
In reply to this post by Julia Boes-2
On Fri, 19 Feb 2021 10:14:54 GMT, Julia Boes <[hidden email]> wrote:

> This change removes some instances of superfluous boxing in java.io.ObjectStreamClass.
> Testing: tier 1-3 all clear.

LGTM. Please add a `noreg-cleanup` label to the JBS issue.

-------------

Marked as reviewed by dfuchs (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2641
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8248318: Examine the use of boxing in ObjectStreamClass

Roger Riggs-2
In reply to this post by Julia Boes-2
On Fri, 19 Feb 2021 10:14:54 GMT, Julia Boes <[hidden email]> wrote:

> This change removes some instances of superfluous boxing in java.io.ObjectStreamClass.
> Testing: tier 1-3 all clear.

Marked as reviewed by rriggs (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2641
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8248318: Examine the use of boxing in ObjectStreamClass

Chris Hegarty-2
In reply to this post by Julia Boes-2
On Fri, 19 Feb 2021 10:14:54 GMT, Julia Boes <[hidden email]> wrote:

> This change removes some instances of superfluous boxing in java.io.ObjectStreamClass.
> Testing: tier 1-3 all clear.

LGTM.

Optionally (and trivially), you could update the JIRA description, from "Examine" to "Remove superfluous use of ..." ( or some such )

-------------

Marked as reviewed by chegar (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2641
Reply | Threaded
Open this post in threaded view
|

Integrated: 8248318: Remove superfluous use of boxing in ObjectStreamClass

Julia Boes-2
In reply to this post by Julia Boes-2
On Fri, 19 Feb 2021 10:14:54 GMT, Julia Boes <[hidden email]> wrote:

> This change removes some instances of superfluous boxing in java.io.ObjectStreamClass.
> Testing: tier 1-3 all clear.

This pull request has now been integrated.

Changeset: e9d7c07b
Author:    Julia Boes <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/e9d7c07b
Stats:     7 lines in 1 file changed: 0 ins; 0 del; 7 mod

8248318: Remove superfluous use of boxing in ObjectStreamClass

Reviewed-by: jlaskey, dfuchs, rriggs, chegar

-------------

PR: https://git.openjdk.java.net/jdk/pull/2641