RFR: 8258855: Two tests sun/security/krb5/auto/ReplayCacheTestProc.java and ReplayCacheTestProcWithMD5.java failed on OL8.3

[Fernando Guallini-2]

Kerberos new replay cache format released in 1.18 (installed in OL8.3) is causing the tests failures:
`https://web.mit.edu/kerberos/www/krb5-latest/doc/formats/rcache_file_format.html`

New and old format are not compatible, that means they cannot share a rcache file. Since there is no interoperability between java GSS-API and native GSS-API new rcache format at the moment, this patch only enables the test scenarios that mimic AP-REQ replays with multiple processes using native GSS-API only (when available) and multiple processes using Java own implementation API only.

If there is a decision to support the new format in the future, tests will be revisited accordingly.

-------------

Commit messages:
 - java lib does not share rcache with native lib

Changes: https://git.openjdk.java.net/jdk/pull/2676/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2676&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8258855
  Stats: 50 lines in 3 files changed: 25 ins; 22 del; 3 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2676.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2676/head:pull/2676

PR: https://git.openjdk.java.net/jdk/pull/2676

[Weijun Wang-2]

On Mon, 22 Feb 2021 16:39:56 GMT, Fernando Guallini <[hidden email]> wrote:

> Kerberos new replay cache format released in 1.18 (installed in OL8.3) is causing the tests failures:
> `https://web.mit.edu/kerberos/www/krb5-latest/doc/formats/rcache_file_format.html`
>
> New and old format are not compatible, that means they cannot share a rcache file. Since there is no interoperability between java GSS-API and native GSS-API new rcache format at the moment, this patch only enables the test scenarios that mimic AP-REQ replays with multiple processes using native GSS-API only (when available) and multiple processes using Java own implementation API only.
>
> If there is a decision to support the new format in the future, tests will be revisited accordingly.

Only one nit.

test/jdk/sun/security/krb5/auto/ReplayCacheTestProcWithMD5.java line 40:

> 38:  *           -Djdk.net.hosts.file=TestHosts
> 39:  *           -Dtest.service=host
> 40:  *           -Dtest.libs=N ReplayCacheTestProc

No need to test native libs with MD5.

-------------

Marked as reviewed by weijun (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2676

[Fernando Guallini-2]

> Kerberos new replay cache format released in 1.18 (installed in OL8.3) is causing the tests failures:
> `https://web.mit.edu/kerberos/www/krb5-latest/doc/formats/rcache_file_format.html`
>
> New and old format are not compatible, that means they cannot share a rcache file. Since there is no interoperability between java GSS-API and native GSS-API new rcache format at the moment, this patch only enables the test scenarios that mimic AP-REQ replays with multiple processes using native GSS-API only (when available) and multiple processes using Java own implementation API only.
>
> If there is a decision to support the new format in the future, tests will be revisited accordingly.

Fernando Guallini has updated the pull request incrementally with one additional commit since the last revision:

  remove native lib test with MD5

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/2676/files
  - new: https://git.openjdk.java.net/jdk/pull/2676/files/abfa28ba..142b151b

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2676&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2676&range=00-01

  Stats: 5 lines in 1 file changed: 0 ins; 5 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2676.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2676/head:pull/2676

PR: https://git.openjdk.java.net/jdk/pull/2676

[Fernando Guallini-2]

On Tue, 23 Feb 2021 18:13:24 GMT, Weijun Wang <[hidden email]> wrote:

>> Fernando Guallini has updated the pull request incrementally with one additional commit since the last revision:
>>
>>   remove native lib test with MD5
>
> test/jdk/sun/security/krb5/auto/ReplayCacheTestProcWithMD5.java line 40:
>
>> 38:  *           -Djdk.net.hosts.file=TestHosts
>> 39:  *           -Dtest.service=host
>> 40:  *           -Dtest.libs=N ReplayCacheTestProc
>
> No need to test native libs with MD5.

Done

-------------

PR: https://git.openjdk.java.net/jdk/pull/2676

[Rajan Halade-2]

On Tue, 23 Feb 2021 18:56:03 GMT, Fernando Guallini <[hidden email]> wrote:

>> Kerberos new replay cache format released in 1.18 (installed in OL8.3) is causing the tests failures:
>> `https://web.mit.edu/kerberos/www/krb5-latest/doc/formats/rcache_file_format.html`
>>
>> New and old format are not compatible, that means they cannot share a rcache file. Since there is no interoperability between java GSS-API and native GSS-API new rcache format at the moment, this patch only enables the test scenarios that mimic AP-REQ replays with multiple processes using native GSS-API only (when available) and multiple processes using Java own implementation API only.
>>
>> If there is a decision to support the new format in the future, tests will be revisited accordingly.
>
> Fernando Guallini has updated the pull request incrementally with one additional commit since the last revision:
>
>   remove native lib test with MD5

test/jdk/sun/security/krb5/auto/ReplayCacheTestProc.java line 127:

> 125:             libs = userLibs.split(",");
> 126:             if (Arrays.asList(libs).contains("N") && !isNativeLibAvailable()) {
> 127:                 System.out.println("Native mode not available - skipped");

Can you please add a comment here with which scenarios are skipped?

-------------

PR: https://git.openjdk.java.net/jdk/pull/2676

[Fernando Guallini-2]

> Kerberos new replay cache format released in 1.18 (installed in OL8.3) is causing the tests failures:
> `https://web.mit.edu/kerberos/www/krb5-latest/doc/formats/rcache_file_format.html`
>
> New and old format are not compatible, that means they cannot share a rcache file. Since there is no interoperability between java GSS-API and native GSS-API new rcache format at the moment, this patch only enables the test scenarios that mimic AP-REQ replays with multiple processes using native GSS-API only (when available) and multiple processes using Java own implementation API only.
>
> If there is a decision to support the new format in the future, tests will be revisited accordingly.

Fernando Guallini has updated the pull request incrementally with one additional commit since the last revision:

  add comment when scenario is skipped

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/2676/files
  - new: https://git.openjdk.java.net/jdk/pull/2676/files/142b151b..d153db17

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2676&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2676&range=01-02

  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2676.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2676/head:pull/2676

PR: https://git.openjdk.java.net/jdk/pull/2676

[Fernando Guallini-2]

On Tue, 23 Feb 2021 22:43:09 GMT, Rajan Halade <[hidden email]> wrote:

>> Fernando Guallini has updated the pull request incrementally with one additional commit since the last revision:
>>
>>   remove native lib test with MD5
>
> test/jdk/sun/security/krb5/auto/ReplayCacheTestProc.java line 127:
>
>> 125:             libs = userLibs.split(",");
>> 126:             if (Arrays.asList(libs).contains("N") && !isNativeLibAvailable()) {
>> 127:                 System.out.println("Native mode not available - skipped");
>
> Can you please add a comment here with which scenarios are skipped?

Added an extra comment there.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2676

[Rajan Halade-2]

On Wed, 24 Feb 2021 12:34:16 GMT, Fernando Guallini <[hidden email]> wrote:

>> Kerberos new replay cache format released in 1.18 (installed in OL8.3) is causing the tests failures:
>> `https://web.mit.edu/kerberos/www/krb5-latest/doc/formats/rcache_file_format.html`
>>
>> New and old format are not compatible, that means they cannot share a rcache file. Since there is no interoperability between java GSS-API and native GSS-API new rcache format at the moment, this patch only enables the test scenarios that mimic AP-REQ replays with multiple processes using native GSS-API only (when available) and multiple processes using Java own implementation API only.
>>
>> If there is a decision to support the new format in the future, tests will be revisited accordingly.
>
> Fernando Guallini has updated the pull request incrementally with one additional commit since the last revision:
>
>   add comment when scenario is skipped

Marked as reviewed by rhalade (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2676

[Fernando Guallini-2]

On Mon, 22 Feb 2021 16:39:56 GMT, Fernando Guallini <[hidden email]> wrote:

> Kerberos new replay cache format released in 1.18 (installed in OL8.3) is causing the tests failures:
> `https://web.mit.edu/kerberos/www/krb5-latest/doc/formats/rcache_file_format.html`
>
> New and old format are not compatible, that means they cannot share a rcache file. Since there is no interoperability between java GSS-API and native GSS-API new rcache format at the moment, this patch only enables the test scenarios that mimic AP-REQ replays with multiple processes using native GSS-API only (when available) and multiple processes using Java own implementation API only.
>
> If there is a decision to support the new format in the future, tests will be revisited accordingly.

This pull request has now been integrated.

Changeset: d70fd7b3
Author:    Fernando Guallini <[hidden email]>
Committer: Weijun Wang <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/d70fd7b3
Stats:     46 lines in 3 files changed: 21 ins; 22 del; 3 mod

8258855: Two tests sun/security/krb5/auto/ReplayCacheTestProc.java and ReplayCacheTestProcWithMD5.java failed on OL8.3

Reviewed-by: weijun, rhalade

-------------

PR: https://git.openjdk.java.net/jdk/pull/2676