RFR: 8259800: timeout in tck test testForkJoin(ForkJoinPool8Test)

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8259800: timeout in tck test testForkJoin(ForkJoinPool8Test)

Doug Lea-2
This addresses interactions between parallelism-0 and new shutdown support in https://bugs.openjdk.java.net/browse/JDK-8259800

-------------

Commit messages:
 - JDK-8259800

Changes: https://git.openjdk.java.net/jdk/pull/2661/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2661&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8259800
  Stats: 347 lines in 2 files changed: 175 ins; 106 del; 66 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2661.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2661/head:pull/2661

PR: https://git.openjdk.java.net/jdk/pull/2661
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8259800: timeout in tck test testForkJoin(ForkJoinPool8Test)

Martin Buchholz-4
On Sat, 20 Feb 2021 14:17:16 GMT, Doug Lea <[hidden email]> wrote:

> This addresses interactions between parallelism-0 and new shutdown support in https://bugs.openjdk.java.net/browse/JDK-8259800

Marked as reviewed by martin (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2661
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8259800: timeout in tck test testForkJoin(ForkJoinPool8Test) [v2]

Doug Lea-2
In reply to this post by Doug Lea-2
> This addresses interactions between parallelism-0 and new shutdown support in https://bugs.openjdk.java.net/browse/JDK-8259800

Doug Lea has updated the pull request incrementally with one additional commit since the last revision:

  JDK-8259800

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/2661/files
  - new: https://git.openjdk.java.net/jdk/pull/2661/files/fa60b251..e0daa87a

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2661&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2661&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2661.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2661/head:pull/2661

PR: https://git.openjdk.java.net/jdk/pull/2661
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8259800: timeout in tck test testForkJoin(ForkJoinPool8Test) [v2]

David Holmes-2
On Sun, 21 Feb 2021 23:22:00 GMT, Doug Lea <[hidden email]> wrote:

>> This addresses interactions between parallelism-0 and new shutdown support in https://bugs.openjdk.java.net/browse/JDK-8259800
>
> Doug Lea has updated the pull request incrementally with one additional commit since the last revision:
>
>   JDK-8259800

Hi Doug,

This looked a little more involved from the version I tested so I re-ran it through the tests - still passed okay :)

Thanks for getting to the bottom of this one - remote debugging is not fun.

Cheers,
David

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2661
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8259800: timeout in tck test testForkJoin(ForkJoinPool8Test) [v2]

Doug Lea-2
On Mon, 22 Feb 2021 02:50:34 GMT, David Holmes <[hidden email]> wrote:

>> Doug Lea has updated the pull request incrementally with one additional commit since the last revision:
>>
>>   JDK-8259800
>
> Hi Doug,
>
> This looked a little more involved from the version I tested so I re-ran it through the tests - still passed okay :)
>
> Thanks for getting to the bottom of this one - remote debugging is not fun.
>
> Cheers,
> David

Thanks David and Martin for the help.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2661
Reply | Threaded
Open this post in threaded view
|

Integrated: 8259800: timeout in tck test testForkJoin(ForkJoinPool8Test)

Doug Lea-2
In reply to this post by Doug Lea-2
On Sat, 20 Feb 2021 14:17:16 GMT, Doug Lea <[hidden email]> wrote:

> This addresses interactions between parallelism-0 and new shutdown support in https://bugs.openjdk.java.net/browse/JDK-8259800

This pull request has now been integrated.

Changeset: 5b7b18c5
Author:    Doug Lea <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/5b7b18c5
Stats:     347 lines in 2 files changed: 175 ins; 106 del; 66 mod

8259800: timeout in tck test testForkJoin(ForkJoinPool8Test)

Reviewed-by: martin, dholmes

-------------

PR: https://git.openjdk.java.net/jdk/pull/2661