RFR: 8259942: Enable customizations in CompileJavaModules.gmk and Main.gmk

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8259942: Enable customizations in CompileJavaModules.gmk and Main.gmk

Adam Farley
Ensure make files look on the include path or in PHASE_MAKEDIRS for
customizations.

Change also adds a tidy-up that improves readability.

-------------

Commit messages:
 - 8259942: Enable customizations in CompileJavaModules.gmk and Main.gmk

Changes: https://git.openjdk.java.net/jdk/pull/2134/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2134&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8259942
  Stats: 5 lines in 3 files changed: 1 ins; 2 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2134.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2134/head:pull/2134

PR: https://git.openjdk.java.net/jdk/pull/2134
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8259942: Enable customizations in CompileJavaModules.gmk and Main.gmk

Erik Joelsson-2
On Mon, 18 Jan 2021 18:27:14 GMT, Adam Farley <[hidden email]> wrote:

> Ensure make files look on the include path or in PHASE_MAKEDIRS for
> customizations.
>
> Change also adds a tidy-up that improves readability.

Marked as reviewed by erikj (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2134
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8259942: Enable customizations in CompileJavaModules.gmk and Main.gmk

Magnus Ihse Bursie-3
In reply to this post by Adam Farley
On Mon, 18 Jan 2021 18:27:14 GMT, Adam Farley <[hidden email]> wrote:

> Ensure make files look on the include path or in PHASE_MAKEDIRS for
> customizations.
>
> Change also adds a tidy-up that improves readability.

Marked as reviewed by ihse (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2134
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8259942: Enable customizations in CompileJavaModules.gmk and Main.gmk

Adam Farley
On Fri, 22 Jan 2021 15:13:45 GMT, Magnus Ihse Bursie <[hidden email]> wrote:

>> Ensure make files look on the include path or in PHASE_MAKEDIRS for
>> customizations.
>>
>> Change also adds a tidy-up that improves readability.
>
> Marked as reviewed by ihse (Reviewer).

We have 2 positive reviews, and all we need now is a sponsor.

Will post a message on the build-dev mailing list.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2134
Reply | Threaded
Open this post in threaded view
|

Integrated: 8259942: Enable customizations in CompileJavaModules.gmk and Main.gmk

Adam Farley
In reply to this post by Adam Farley
On Mon, 18 Jan 2021 18:27:14 GMT, Adam Farley <[hidden email]> wrote:

> Ensure make files look on the include path or in PHASE_MAKEDIRS for
> customizations.
>
> Change also adds a tidy-up that improves readability.

This pull request has now been integrated.

Changeset: cf0019d9
Author:    Adam Farley <[hidden email]>
Committer: Erik Joelsson <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/cf0019d9
Stats:     5 lines in 3 files changed: 1 ins; 2 del; 2 mod

8259942: Enable customizations in CompileJavaModules.gmk and Main.gmk

Reviewed-by: erikj, ihse

-------------

PR: https://git.openjdk.java.net/jdk/pull/2134