RFR: 8261072: AArch64: Fix MacroAssembler::get_thread convention

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8261072: AArch64: Fix MacroAssembler::get_thread convention

Anton Kozlov-2
Please review a fix in a special calling convention for aarch64_get_thread_helper for non-Linux platforms (windows/aarch64 for now).

Preliminary review: https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2021-January/011239.html

-------------

Commit messages:
 - Fix MacroAssembler::get_thread convention

Changes: https://git.openjdk.java.net/jdk/pull/2451/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2451&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8261072
  Stats: 6 lines in 1 file changed: 4 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2451.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2451/head:pull/2451

PR: https://git.openjdk.java.net/jdk/pull/2451
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261072: AArch64: Fix MacroAssembler::get_thread convention

Bernhard Urban-Forster-2
On Mon, 8 Feb 2021 08:26:41 GMT, Anton Kozlov <[hidden email]> wrote:

> Please review a fix in a special calling convention for aarch64_get_thread_helper for non-Linux platforms (windows/aarch64 for now).
>
> Preliminary review: https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2021-January/011239.html

Marked as reviewed by burban (Author).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2451
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261072: AArch64: Fix MacroAssembler::get_thread convention

Vladimir Kempik-3
On Mon, 8 Feb 2021 10:25:19 GMT, Bernhard Urban-Forster <[hidden email]> wrote:

>> Please review a fix in a special calling convention for aarch64_get_thread_helper for non-Linux platforms (windows/aarch64 for now).
>>
>> Preliminary review: https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2021-January/011239.html
>
> Marked as reviewed by burban (Author).

Looks good, will make other non-linux platform work without the need to change this ever again

-------------

PR: https://git.openjdk.java.net/jdk/pull/2451
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261072: AArch64: Fix MacroAssembler::get_thread convention

Andrew Haley-2
In reply to this post by Anton Kozlov-2
On Mon, 8 Feb 2021 08:26:41 GMT, Anton Kozlov <[hidden email]> wrote:

> Please review a fix in a special calling convention for aarch64_get_thread_helper for non-Linux platforms (windows/aarch64 for now).
>
> Preliminary review: https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2021-January/011239.html

src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 5270:

> 5268: //
> 5269: // On Linux, aarch64_get_thread_helper() clobbers only r0, r1, and flags.
> 5270: // On Windows, the helper is a usual C function.

This should say "other systems", not "Windows". Otherwise OK.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2451
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261072: AArch64: Fix MacroAssembler::get_thread convention [v2]

Anton Kozlov-2
In reply to this post by Anton Kozlov-2
> Please review a fix in a special calling convention for aarch64_get_thread_helper for non-Linux platforms (windows/aarch64 for now).
>
> Preliminary review: https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2021-January/011239.html

Anton Kozlov has updated the pull request incrementally with one additional commit since the last revision:

  Change comment

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/2451/files
  - new: https://git.openjdk.java.net/jdk/pull/2451/files/217d3c23..3b111ae5

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2451&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2451&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2451.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2451/head:pull/2451

PR: https://git.openjdk.java.net/jdk/pull/2451
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261072: AArch64: Fix MacroAssembler::get_thread convention [v2]

Anton Kozlov-2
In reply to this post by Andrew Haley-2
On Fri, 12 Feb 2021 13:10:25 GMT, Andrew Haley <[hidden email]> wrote:

>> Anton Kozlov has updated the pull request incrementally with one additional commit since the last revision:
>>
>>   Change comment
>
> src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 5270:
>
>> 5268: //
>> 5269: // On Linux, aarch64_get_thread_helper() clobbers only r0, r1, and flags.
>> 5270: // On Windows, the helper is a usual C function.
>
> This should say "other systems", not "Windows". Otherwise OK.

Thanks, fixed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2451
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261072: AArch64: Fix MacroAssembler::get_thread convention [v2]

Andrew Haley-2
In reply to this post by Anton Kozlov-2
On Fri, 12 Feb 2021 13:19:54 GMT, Anton Kozlov <[hidden email]> wrote:

>> Please review a fix in a special calling convention for aarch64_get_thread_helper for non-Linux platforms (windows/aarch64 for now).
>>
>> Preliminary review: https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2021-January/011239.html
>
> Anton Kozlov has updated the pull request incrementally with one additional commit since the last revision:
>
>   Change comment

Marked as reviewed by aph (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2451
Reply | Threaded
Open this post in threaded view
|

Integrated: 8261072: AArch64: Fix MacroAssembler::get_thread convention

Anton Kozlov-2
In reply to this post by Anton Kozlov-2
On Mon, 8 Feb 2021 08:26:41 GMT, Anton Kozlov <[hidden email]> wrote:

> Please review a fix in a special calling convention for aarch64_get_thread_helper for non-Linux platforms (windows/aarch64 for now).
>
> Preliminary review: https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2021-January/011239.html

This pull request has now been integrated.

Changeset: b670efd8
Author:    Anton Kozlov <[hidden email]>
Committer: Vladimir Kempik <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/b670efd8
Stats:     6 lines in 1 file changed: 4 ins; 0 del; 2 mod

8261072: AArch64: Fix MacroAssembler::get_thread convention

Reviewed-by: burban, aph

-------------

PR: https://git.openjdk.java.net/jdk/pull/2451