RFR: 8261106: Reduce inclusion of jniHandles.hpp

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8261106: Reduce inclusion of jniHandles.hpp

Ioi Lam-2
niHandles.hpp is included by about 800 out of 1000 HotSpot .o files. Most of these are transitively included from these header files, which don't actually need to include jniHandles.hpp.

- ci/ciBaseObject.hpp
- ci/ciMetadata.hpp
- ci/ciObject.hpp
- classfile/moduleEntry.hpp
- gc/shared/gcVMOperations.hpp
- jvmci/jvmciJavaClasses.hpp
- runtime/thread.hpp
- services/threadService.hpp

Fixing these headers reduces the number of .o files that include jniHandles.hpp to 145.

Note: 43 files were changed in this PR. Most of them were using jniHandles.hpp but were not including it directly.

Tested with mach5: tier1, builds-tier2, builds-tier3, builds-tier4 and builds-tier5. Also locally: aarch64, arm, ppc64, s390, x86, and zero.

-------------

Commit messages:
 - 8261106: Reduce inclusion of jniHandles.hpp

Changes: https://git.openjdk.java.net/jdk/pull/2393/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2393&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8261106
  Stats: 44 lines in 43 files changed: 36 ins; 8 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2393.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2393/head:pull/2393

PR: https://git.openjdk.java.net/jdk/pull/2393
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261106: Reduce inclusion of jniHandles.hpp

Coleen Phillimore-3
On Thu, 4 Feb 2021 01:31:39 GMT, Ioi Lam <[hidden email]> wrote:

> niHandles.hpp is included by about 800 out of 1000 HotSpot .o files. Most of these are transitively included from these header files, which don't actually need to include jniHandles.hpp.
>
> - ci/ciBaseObject.hpp
> - ci/ciMetadata.hpp
> - ci/ciObject.hpp
> - classfile/moduleEntry.hpp
> - gc/shared/gcVMOperations.hpp
> - jvmci/jvmciJavaClasses.hpp
> - runtime/thread.hpp
> - services/threadService.hpp
>
> Fixing these headers reduces the number of .o files that include jniHandles.hpp to 145.
>
> Note: 43 files were changed in this PR. Most of them were using jniHandles.hpp but were not including it directly.
>
> Tested with mach5: tier1, builds-tier2, builds-tier3, builds-tier4 and builds-tier5. Also locally: aarch64, arm, ppc64, s390, x86, and zero.

Ok!  Seems trivial since I assume you've built this everywhere.

-------------

Marked as reviewed by coleenp (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2393
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261106: Reduce inclusion of jniHandles.hpp

Harold Seigel-2
In reply to this post by Ioi Lam-2
On Thu, 4 Feb 2021 01:31:39 GMT, Ioi Lam <[hidden email]> wrote:

> niHandles.hpp is included by about 800 out of 1000 HotSpot .o files. Most of these are transitively included from these header files, which don't actually need to include jniHandles.hpp.
>
> - ci/ciBaseObject.hpp
> - ci/ciMetadata.hpp
> - ci/ciObject.hpp
> - classfile/moduleEntry.hpp
> - gc/shared/gcVMOperations.hpp
> - jvmci/jvmciJavaClasses.hpp
> - runtime/thread.hpp
> - services/threadService.hpp
>
> Fixing these headers reduces the number of .o files that include jniHandles.hpp to 145.
>
> Note: 43 files were changed in this PR. Most of them were using jniHandles.hpp but were not including it directly.
>
> Tested with mach5: tier1, builds-tier2, builds-tier3, builds-tier4 and builds-tier5. Also locally: aarch64, arm, ppc64, s390, x86, and zero.

LGTM!
Harold

-------------

Marked as reviewed by hseigel (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2393
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261106: Reduce inclusion of jniHandles.hpp [v2]

Ioi Lam-2
In reply to this post by Ioi Lam-2
> niHandles.hpp is included by about 800 out of 1000 HotSpot .o files. Most of these are transitively included from these header files, which don't actually need to include jniHandles.hpp.
>
> - ci/ciBaseObject.hpp
> - ci/ciMetadata.hpp
> - ci/ciObject.hpp
> - classfile/moduleEntry.hpp
> - gc/shared/gcVMOperations.hpp
> - jvmci/jvmciJavaClasses.hpp
> - runtime/thread.hpp
> - services/threadService.hpp
>
> Fixing these headers reduces the number of .o files that include jniHandles.hpp to 145.
>
> Note: 43 files were changed in this PR. Most of them were using jniHandles.hpp but were not including it directly.
>
> Tested with mach5: tier1, builds-tier2, builds-tier3, builds-tier4 and builds-tier5. Also locally: aarch64, arm, ppc64, s390, x86, and zero.

Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:

 - Merge branch 'master' into 8261106-reduce-jniHandles-hpp
 - 8261106: Reduce inclusion of jniHandles.hpp

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/2393/files
  - new: https://git.openjdk.java.net/jdk/pull/2393/files/e7f2d097..6e77fbea

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2393&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2393&range=00-01

  Stats: 7440 lines in 439 files changed: 4576 ins; 1518 del; 1346 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2393.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2393/head:pull/2393

PR: https://git.openjdk.java.net/jdk/pull/2393
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261106: Reduce inclusion of jniHandles.hpp [v2]

Ioi Lam-2
In reply to this post by Coleen Phillimore-3
On Thu, 4 Feb 2021 13:24:24 GMT, Coleen Phillimore <[hidden email]> wrote:

>> Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>>
>>  - Merge branch 'master' into 8261106-reduce-jniHandles-hpp
>>  - 8261106: Reduce inclusion of jniHandles.hpp
>
> Ok!  Seems trivial since I assume you've built this everywhere.

Thanks @coleenp and @hseigel for the review.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2393
Reply | Threaded
Open this post in threaded view
|

Integrated: 8261106: Reduce inclusion of jniHandles.hpp

Ioi Lam-2
In reply to this post by Ioi Lam-2
On Thu, 4 Feb 2021 01:31:39 GMT, Ioi Lam <[hidden email]> wrote:

> niHandles.hpp is included by about 800 out of 1000 HotSpot .o files. Most of these are transitively included from these header files, which don't actually need to include jniHandles.hpp.
>
> - ci/ciBaseObject.hpp
> - ci/ciMetadata.hpp
> - ci/ciObject.hpp
> - classfile/moduleEntry.hpp
> - gc/shared/gcVMOperations.hpp
> - jvmci/jvmciJavaClasses.hpp
> - runtime/thread.hpp
> - services/threadService.hpp
>
> Fixing these headers reduces the number of .o files that include jniHandles.hpp to 145.
>
> Note: 43 files were changed in this PR. Most of them were using jniHandles.hpp but were not including it directly.
>
> Tested with mach5: tier1, builds-tier2, builds-tier3, builds-tier4 and builds-tier5. Also locally: aarch64, arm, ppc64, s390, x86, and zero.

This pull request has now been integrated.

Changeset: c59e4b66
Author:    Ioi Lam <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/c59e4b66
Stats:     44 lines in 43 files changed: 36 ins; 8 del; 0 mod

8261106: Reduce inclusion of jniHandles.hpp

Reviewed-by: coleenp, hseigel

-------------

PR: https://git.openjdk.java.net/jdk/pull/2393