RFR: 8261190: restore original Alibaba copyright line in two files

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8261190: restore original Alibaba copyright line in two files

Daniel D.Daugherty
A trivial fix to restore original Alibaba copyright line in two files.

-------------

Commit messages:
 - 8261190: restore original Alibaba copyright line in two files

Changes: https://git.openjdk.java.net/jdk/pull/2417/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2417&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8261190
  Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2417.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2417/head:pull/2417

PR: https://git.openjdk.java.net/jdk/pull/2417
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261190: restore original Alibaba copyright line in two files

David Holmes-2
On Thu, 4 Feb 2021 22:56:16 GMT, Daniel D. Daugherty <[hidden email]> wrote:

> A trivial fix to restore original Alibaba copyright line in two files.

Looks good and trivial.

Thanks,
David

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2417
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261190: restore original Alibaba copyright line in two files

Daniel D.Daugherty
On Thu, 4 Feb 2021 23:00:46 GMT, David Holmes <[hidden email]> wrote:

>> A trivial fix to restore original Alibaba copyright line in two files.
>
> Looks good and trivial.
>
> Thanks,
> David

@dholmes-ora - Thanks for the fast review.
@egahlin and @D-D-H - please chime in to confirm that you've seen this thread.
@D-D-H - please read my comments in:
    JDK-8261190: restore original Alibaba copyright line in two files
so that you know what had to change with your original copyright headers.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2417
Reply | Threaded
Open this post in threaded view
|

Integrated: 8261190: restore original Alibaba copyright line in two files

Daniel D.Daugherty
In reply to this post by Daniel D.Daugherty
On Thu, 4 Feb 2021 22:56:16 GMT, Daniel D. Daugherty <[hidden email]> wrote:

> A trivial fix to restore original Alibaba copyright line in two files.

This pull request has now been integrated.

Changeset: 08f7454f
Author:    Daniel D. Daugherty <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/08f7454f
Stats:     2 lines in 2 files changed: 0 ins; 0 del; 2 mod

8261190: restore original Alibaba copyright line in two files

Reviewed-by: dholmes

-------------

PR: https://git.openjdk.java.net/jdk/pull/2417
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261190: restore original Alibaba copyright line in two files

Denghui Dong-2
In reply to this post by David Holmes-2
On Thu, 4 Feb 2021 23:00:46 GMT, David Holmes <[hidden email]> wrote:

>> A trivial fix to restore original Alibaba copyright line in two files.
>
> Looks good and trivial.
>
> Thanks,
> David

> @dholmes-ora - Thanks for the fast review.
> @egahlin and @D-D-H - please chime in to confirm that you've seen this thread.
> @D-D-H - please read my comments in:
> JDK-8261190: restore original Alibaba copyright line in two files
> so that you know what had to change with your original copyright headers.

There is a problem with the copyright format we used before, thank you for your correction.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2417