RFR: 8261309: Remove remaining StoreLoad barrier with UseCondCardMark for Serial/Parallel GC

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8261309: Remove remaining StoreLoad barrier with UseCondCardMark for Serial/Parallel GC

Thomas Schatzl-4
Hi all,

  can I have reviews for this (tiny) change that removes the last (unconditional) StoreLoad memory barrier for Serial/Parallel GC that has apparently been forgotten to be made conditional on `CardTable::scanned_concurrently()` just removed in [JDK-8260941](https://bugs.openjdk.java.net/browse/JDK-8260941) ?

Thanks,
  Thomas

Testing: automatic compilation via github actions, but this is a quite straightforward removal of a single line...

-------------

Commit messages:
 - Initial commit

Changes: https://git.openjdk.java.net/jdk/pull/2541/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2541&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8261309
  Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2541.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2541/head:pull/2541

PR: https://git.openjdk.java.net/jdk/pull/2541
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261309: Remove remaining StoreLoad barrier with UseCondCardMark for Serial/Parallel GC

Aleksey Shipilev-5
On Fri, 12 Feb 2021 08:55:40 GMT, Thomas Schatzl <[hidden email]> wrote:

> Hi all,
>
>   can I have reviews for this (tiny) change that removes the last (unconditional) StoreLoad memory barrier for Serial/Parallel GC that has apparently been forgotten to be made conditional on `CardTable::scanned_concurrently()` just removed in [JDK-8260941](https://bugs.openjdk.java.net/browse/JDK-8260941) ?
>
> Thanks,
>   Thomas
>
> Testing: automatic compilation via github actions, but this is a quite straightforward removal of a single line...

Looks good.

-------------

Marked as reviewed by shade (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2541
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261309: Remove remaining StoreLoad barrier with UseCondCardMark for Serial/Parallel GC

Albert Mingkun Yang
In reply to this post by Thomas Schatzl-4
On Fri, 12 Feb 2021 08:55:40 GMT, Thomas Schatzl <[hidden email]> wrote:

> Hi all,
>
>   can I have reviews for this (tiny) change that removes the last (unconditional) StoreLoad memory barrier for Serial/Parallel GC that has apparently been forgotten to be made conditional on `CardTable::scanned_concurrently()` just removed in [JDK-8260941](https://bugs.openjdk.java.net/browse/JDK-8260941) ?
>
> Thanks,
>   Thomas
>
> Testing: automatic compilation via github actions, but this is a quite straightforward removal of a single line...

Marked as reviewed by ayang (Author).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2541
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261309: Remove remaining StoreLoad barrier with UseCondCardMark for Serial/Parallel GC

Stefan Johansson
In reply to this post by Thomas Schatzl-4
On Fri, 12 Feb 2021 08:55:40 GMT, Thomas Schatzl <[hidden email]> wrote:

> Hi all,
>
>   can I have reviews for this (tiny) change that removes the last (unconditional) StoreLoad memory barrier for Serial/Parallel GC that has apparently been forgotten to be made conditional on `CardTable::scanned_concurrently()` just removed in [JDK-8260941](https://bugs.openjdk.java.net/browse/JDK-8260941) ?
>
> Thanks,
>   Thomas
>
> Testing: automatic compilation via github actions, but this is a quite straightforward removal of a single line...

Looks good.

-------------

Marked as reviewed by sjohanss (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2541
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261309: Remove remaining StoreLoad barrier with UseCondCardMark for Serial/Parallel GC

Thomas Schatzl-4
In reply to this post by Aleksey Shipilev-5
On Mon, 15 Feb 2021 08:37:24 GMT, Aleksey Shipilev <[hidden email]> wrote:

>> Hi all,
>>
>>   can I have reviews for this (tiny) change that removes the last (unconditional) StoreLoad memory barrier for Serial/Parallel GC that has apparently been forgotten to be made conditional on `CardTable::scanned_concurrently()` just removed in [JDK-8260941](https://bugs.openjdk.java.net/browse/JDK-8260941) ?
>>
>> Thanks,
>>   Thomas
>>
>> Testing: automatic compilation via github actions, but this is a quite straightforward removal of a single line...
>
> Looks good.

Thanks @shipilev , @albertnetymk , @kstefanj  for your reviews.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2541
Reply | Threaded
Open this post in threaded view
|

Integrated: 8261309: Remove remaining StoreLoad barrier with UseCondCardMark for Serial/Parallel GC

Thomas Schatzl-4
In reply to this post by Thomas Schatzl-4
On Fri, 12 Feb 2021 08:55:40 GMT, Thomas Schatzl <[hidden email]> wrote:

> Hi all,
>
>   can I have reviews for this (tiny) change that removes the last (unconditional) StoreLoad memory barrier for Serial/Parallel GC that has apparently been forgotten to be made conditional on `CardTable::scanned_concurrently()` just removed in [JDK-8260941](https://bugs.openjdk.java.net/browse/JDK-8260941) ?
>
> Thanks,
>   Thomas
>
> Testing: automatic compilation via github actions, but this is a quite straightforward removal of a single line...

This pull request has now been integrated.

Changeset: a9308705
Author:    Thomas Schatzl <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/a9308705
Stats:     1 line in 1 file changed: 0 ins; 1 del; 0 mod

8261309: Remove remaining StoreLoad barrier with UseCondCardMark for Serial/Parallel GC

Reviewed-by: shade, ayang, sjohanss

-------------

PR: https://git.openjdk.java.net/jdk/pull/2541