RFR: 8261444: Remove unused fields in Lower

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8261444: Remove unused fields in Lower

Claes Redestad-2
A small code cleanup in Lower, removing a few unused fields.

Last usage of classDollar was removed by JDK-8175191, and dollarCloseResource was removed by JDK-8194978

Testing: tier1-2

-------------

Commit messages:
 - Remove unused fields in Lower

Changes: https://git.openjdk.java.net/jdk/pull/2482/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2482&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8261444
  Stats: 8 lines in 1 file changed: 0 ins; 8 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2482.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2482/head:pull/2482

PR: https://git.openjdk.java.net/jdk/pull/2482
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261444: Remove unused fields in Lower

Vicente Romero-3
On Tue, 9 Feb 2021 13:46:47 GMT, Claes Redestad <[hidden email]> wrote:

> A small code cleanup in Lower, removing a few unused fields.
>
> Last usage of classDollar was removed by JDK-8175191, and dollarCloseResource was removed by JDK-8194978
>
> Testing: tier1-2

looks good

-------------

Marked as reviewed by vromero (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2482
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261444: Remove unused fields in Lower

Claes Redestad-2
On Tue, 9 Feb 2021 14:19:56 GMT, Vicente Romero <[hidden email]> wrote:

>> A small code cleanup in Lower, removing a few unused fields.
>>
>> Last usage of classDollar was removed by JDK-8175191, and dollarCloseResource was removed by JDK-8194978
>>
>> Testing: tier1-2
>
> looks good

Thanks Vicente!

-------------

PR: https://git.openjdk.java.net/jdk/pull/2482
Reply | Threaded
Open this post in threaded view
|

Integrated: 8261444: Remove unused fields in Lower

Claes Redestad-2
In reply to this post by Claes Redestad-2
On Tue, 9 Feb 2021 13:46:47 GMT, Claes Redestad <[hidden email]> wrote:

> A small code cleanup in Lower, removing a few unused fields.
>
> Last usage of classDollar was removed by JDK-8175191, and dollarCloseResource was removed by JDK-8194978
>
> Testing: tier1-2

This pull request has now been integrated.

Changeset: 5e1b8092
Author:    Claes Redestad <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/5e1b8092
Stats:     8 lines in 1 file changed: 0 ins; 8 del; 0 mod

8261444: Remove unused fields in Lower

Reviewed-by: vromero

-------------

PR: https://git.openjdk.java.net/jdk/pull/2482