RFR: 8261457: test/langtools/tools/javac/T8187978 can fail if ArrayList class is modified

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8261457: test/langtools/tools/javac/T8187978 can fail if ArrayList class is modified

Adam Sotona-2
Please review this simple test fix that removes coupling between this test and "live" library code by testing on provided nested classes as suggested in the bug comment.

Thank you,
Adam

-------------

Commit messages:
 - 8261457: test/langtools/tools/javac/T8187978 can fail if ArrayList class is modified

Changes: https://git.openjdk.java.net/jdk/pull/2723/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2723&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8261457
  Stats: 45 lines in 2 files changed: 41 ins; 2 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2723.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2723/head:pull/2723

PR: https://git.openjdk.java.net/jdk/pull/2723
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261457: test/langtools/tools/javac/T8187978 can fail if ArrayList class is modified

Vicente Romero-3
On Thu, 25 Feb 2021 10:40:30 GMT, Adam Sotona <[hidden email]> wrote:

> Please review this simple test fix that removes coupling between this test and "live" library code by testing on provided nested classes as suggested in the bug comment.
>
> Thank you,
> Adam

looks good

-------------

Marked as reviewed by vromero (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2723
Reply | Threaded
Open this post in threaded view
|

Integrated: 8261457: test/langtools/tools/javac/T8187978 can fail if ArrayList class is modified

Adam Sotona-2
In reply to this post by Adam Sotona-2
On Thu, 25 Feb 2021 10:40:30 GMT, Adam Sotona <[hidden email]> wrote:

> Please review this simple test fix that removes coupling between this test and "live" library code by testing on provided nested classes as suggested in the bug comment.
>
> Thank you,
> Adam

This pull request has now been integrated.

Changeset: 2eca17d1
Author:    Adam Sotona <[hidden email]>
Committer: Vicente Romero <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/2eca17d1
Stats:     45 lines in 2 files changed: 41 ins; 2 del; 2 mod

8261457: test/langtools/tools/javac/T8187978 can fail if ArrayList class is modified

Reviewed-by: vromero

-------------

PR: https://git.openjdk.java.net/jdk/pull/2723