RFR: 8261509: Move per-thread StackWatermark from Thread to JavaThread class

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8261509: Move per-thread StackWatermark from Thread to JavaThread class

Zhengyu Gu-3
Per-thread StackWatermark only applies to JavaThread, so it should belong to there.

-------------

Commit messages:
 - 8261509: Move per-thread StackWatermark from Thread to JavaThread class

Changes: https://git.openjdk.java.net/jdk/pull/2513/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2513&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8261509
  Stats: 11 lines in 1 file changed: 5 ins; 6 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2513.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2513/head:pull/2513

PR: https://git.openjdk.java.net/jdk/pull/2513
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261509: Move per-thread StackWatermark from Thread to JavaThread class

Erik Österlund-3
On Wed, 10 Feb 2021 16:35:08 GMT, Zhengyu Gu <[hidden email]> wrote:

> Per-thread StackWatermark only applies to JavaThread, so it should belong to there.

Marked as reviewed by eosterlund (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2513
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261509: Move per-thread StackWatermark from Thread to JavaThread class

Zhengyu Gu-3
On Wed, 10 Feb 2021 22:08:22 GMT, Erik Österlund <[hidden email]> wrote:

>> Per-thread StackWatermark only applies to JavaThread, so it should belong to there.
>
> Marked as reviewed by eosterlund (Reviewer).

Thanks, @fisk

-------------

PR: https://git.openjdk.java.net/jdk/pull/2513
Reply | Threaded
Open this post in threaded view
|

Integrated: 8261509: Move per-thread StackWatermark from Thread to JavaThread class

Zhengyu Gu-3
In reply to this post by Zhengyu Gu-3
On Wed, 10 Feb 2021 16:35:08 GMT, Zhengyu Gu <[hidden email]> wrote:

> Per-thread StackWatermark only applies to JavaThread, so it should belong to there.

This pull request has now been integrated.

Changeset: 4a72cea0
Author:    Zhengyu Gu <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/4a72cea0
Stats:     11 lines in 1 file changed: 5 ins; 6 del; 0 mod

8261509: Move per-thread StackWatermark from Thread to JavaThread class

Reviewed-by: eosterlund

-------------

PR: https://git.openjdk.java.net/jdk/pull/2513
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261509: Move per-thread StackWatermark from Thread to JavaThread class

Daniel D.Daugherty
In reply to this post by Zhengyu Gu-3
On Thu, 11 Feb 2021 14:01:45 GMT, Zhengyu Gu <[hidden email]> wrote:

>> Marked as reviewed by eosterlund (Reviewer).
>
> Thanks, @fisk

@zhengyu123 - This appears to be a trivial change so a single reviewer is fine.
For future PRs, please make it clear that you are proposing the change as trivial
and make sure that your single reviewer agrees before you integrate under the
trivial change rules.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2513
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261509: Move per-thread StackWatermark from Thread to JavaThread class

Zhengyu Gu-3
In reply to this post by Zhengyu Gu-3
On Thu, 11 Feb 2021 14:01:45 GMT, Zhengyu Gu <[hidden email]> wrote:

>> Marked as reviewed by eosterlund (Reviewer).
>
> Thanks, @fisk

> @zhengyu123 - This appears to be a trivial change so a single reviewer is fine.
> For future PRs, please make it clear that you are proposing the change as trivial
> and make sure that your single reviewer agrees before you integrate under the
> trivial change rules.

@dcubed-ojdk Sorry about that, will do.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2513