RFR: 8261657: [PPC64] Cleanup StoreCM nodes after CMS removal

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8261657: [PPC64] Cleanup StoreCM nodes after CMS removal

Martin Doerr
We only need one StoreCM node after CMS removal. CMS StoreStore barriers were already removed at other places.

-------------

Commit messages:
 - 8261657: [PPC64] Cleanup StoreCM nodes after CMS removal

Changes: https://git.openjdk.java.net/jdk/pull/2554/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2554&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8261657
  Stats: 55 lines in 1 file changed: 0 ins; 52 del; 3 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2554.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2554/head:pull/2554

PR: https://git.openjdk.java.net/jdk/pull/2554
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261657: [PPC64] Cleanup StoreCM nodes after CMS removal

Lutz Schmidt
On Fri, 12 Feb 2021 16:29:36 GMT, Martin Doerr <[hidden email]> wrote:

> We only need one StoreCM node after CMS removal. CMS StoreStore barriers were already removed at other places.

Changes look good to me.
Thanks for cleaning up!

-------------

Marked as reviewed by lucy (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2554
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261657: [PPC64] Cleanup StoreCM nodes after CMS removal

Martin Doerr
On Mon, 15 Feb 2021 17:45:02 GMT, Lutz Schmidt <[hidden email]> wrote:

>> We only need one StoreCM node after CMS removal. CMS StoreStore barriers were already removed at other places.
>
> Changes look good to me.
> Thanks for cleaning up!

Thanks for the review!
I guess this can be considered as trivial because we basically remove dead code.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2554
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261657: [PPC64] Cleanup StoreCM nodes after CMS removal

Goetz Lindenmaier
In reply to this post by Martin Doerr
On Fri, 12 Feb 2021 16:29:36 GMT, Martin Doerr <[hidden email]> wrote:

> We only need one StoreCM node after CMS removal. CMS StoreStore barriers were already removed at other places.

Marked as reviewed by goetz (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2554
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261657: [PPC64] Cleanup StoreCM nodes after CMS removal

Goetz Lindenmaier
On Wed, 17 Feb 2021 13:07:19 GMT, Goetz Lindenmaier <[hidden email]> wrote:

>> We only need one StoreCM node after CMS removal. CMS StoreStore barriers were already removed at other places.
>
> Marked as reviewed by goetz (Reviewer).

LGTM

-------------

PR: https://git.openjdk.java.net/jdk/pull/2554
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261657: [PPC64] Cleanup StoreCM nodes after CMS removal

Martin Doerr
On Wed, 17 Feb 2021 13:07:43 GMT, Goetz Lindenmaier <[hidden email]> wrote:

>> Marked as reviewed by goetz (Reviewer).
>
> LGTM

Thanks for the review!

-------------

PR: https://git.openjdk.java.net/jdk/pull/2554
Reply | Threaded
Open this post in threaded view
|

Integrated: 8261657: [PPC64] Cleanup StoreCM nodes after CMS removal

Martin Doerr
In reply to this post by Martin Doerr
On Fri, 12 Feb 2021 16:29:36 GMT, Martin Doerr <[hidden email]> wrote:

> We only need one StoreCM node after CMS removal. CMS StoreStore barriers were already removed at other places.

This pull request has now been integrated.

Changeset: 9ba2b71a
Author:    Martin Doerr <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/9ba2b71a
Stats:     55 lines in 1 file changed: 0 ins; 52 del; 3 mod

8261657: [PPC64] Cleanup StoreCM nodes after CMS removal

Reviewed-by: lucy, goetz

-------------

PR: https://git.openjdk.java.net/jdk/pull/2554