RFR: 8261661: gc/stress/TestReclaimStringsLeaksMemory.java fails because Reserved memory size is too big

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8261661: gc/stress/TestReclaimStringsLeaksMemory.java fails because Reserved memory size is too big

Daniel D.Daugherty
A trivial fix to adjust a test to work with the fix from:

https://bugs.openjdk.java.net/browse/JDK-8261297 NMT: Final report should use scale 1

The idea for the fix came from @albertnetymk. Thanks!
The failure reproduces on my local MBP13 and does not reproduce
with this fix in place.

-------------

Commit messages:
 - 8261661: gc/stress/TestReclaimStringsLeaksMemory.java fails because Reserved memory size is too big

Changes: https://git.openjdk.java.net/jdk/pull/2557/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2557&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8261661
  Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2557.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2557/head:pull/2557

PR: https://git.openjdk.java.net/jdk/pull/2557
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261661: gc/stress/TestReclaimStringsLeaksMemory.java fails because Reserved memory size is too big

Daniel D.Daugherty
On Fri, 12 Feb 2021 19:53:23 GMT, Daniel D. Daugherty <[hidden email]> wrote:

> A trivial fix to adjust a test to work with the fix from:
>
> https://bugs.openjdk.java.net/browse/JDK-8261297 NMT: Final report should use scale 1
>
> The idea for the fix came from @albertnetymk. Thanks!
> The failure reproduces on my local MBP13 and does not reproduce
> with this fix in place.

@tstuefe and @zhengyu123 - Please check out this test adjustment that was needed
due to the fix for:
https://bugs.openjdk.java.net/browse/JDK-8261297 NMT: Final report should use scale 1

-------------

PR: https://git.openjdk.java.net/jdk/pull/2557
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261661: gc/stress/TestReclaimStringsLeaksMemory.java fails because Reserved memory size is too big

Daniel D.Daugherty
On Fri, 12 Feb 2021 19:56:37 GMT, Daniel D. Daugherty <[hidden email]> wrote:

>> A trivial fix to adjust a test to work with the fix from:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8261297 NMT: Final report should use scale 1
>>
>> The idea for the fix came from @albertnetymk. Thanks!
>> The failure reproduces on my local MBP13 and does not reproduce
>> with this fix in place.
>
> @tstuefe and @zhengyu123 - Please check out this test adjustment that was needed
> due to the fix for:
> https://bugs.openjdk.java.net/browse/JDK-8261297 NMT: Final report should use scale 1

The reason I'm pursuing this fix is to reduce the noise in the JDK17 CI for the weekend.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2557
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261661: gc/stress/TestReclaimStringsLeaksMemory.java fails because Reserved memory size is too big

Albert Mingkun Yang
In reply to this post by Daniel D.Daugherty
On Fri, 12 Feb 2021 19:53:23 GMT, Daniel D. Daugherty <[hidden email]> wrote:

> A trivial fix to adjust a test to work with the fix from:
>
> https://bugs.openjdk.java.net/browse/JDK-8261297 NMT: Final report should use scale 1
>
> The idea for the fix came from @albertnetymk. Thanks!
> The failure reproduces on my local MBP13 and does not reproduce
> with this fix in place.

Marked as reviewed by ayang (Author).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2557
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261661: gc/stress/TestReclaimStringsLeaksMemory.java fails because Reserved memory size is too big

Daniel D.Daugherty
On Fri, 12 Feb 2021 20:18:41 GMT, Albert Mingkun Yang <[hidden email]> wrote:

>> A trivial fix to adjust a test to work with the fix from:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8261297 NMT: Final report should use scale 1
>>
>> The idea for the fix came from @albertnetymk. Thanks!
>> The failure reproduces on my local MBP13 and does not reproduce
>> with this fix in place.
>
> Marked as reviewed by ayang (Author).

@albertnetymk - Thanks for the fast review!

-------------

PR: https://git.openjdk.java.net/jdk/pull/2557
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261661: gc/stress/TestReclaimStringsLeaksMemory.java fails because Reserved memory size is too big

Kim Barrett-2
In reply to this post by Daniel D.Daugherty
On Fri, 12 Feb 2021 19:53:23 GMT, Daniel D. Daugherty <[hidden email]> wrote:

> A trivial fix to adjust a test to work with the fix from:
>
> https://bugs.openjdk.java.net/browse/JDK-8261297 NMT: Final report should use scale 1
>
> The idea for the fix came from @albertnetymk. Thanks!
> The failure reproduces on my local MBP13 and does not reproduce
> with this fix in place.

Looks good.

-------------

Marked as reviewed by kbarrett (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2557
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261661: gc/stress/TestReclaimStringsLeaksMemory.java fails because Reserved memory size is too big

Daniel D.Daugherty
On Fri, 12 Feb 2021 21:48:28 GMT, Kim Barrett <[hidden email]> wrote:

>> A trivial fix to adjust a test to work with the fix from:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8261297 NMT: Final report should use scale 1
>>
>> The idea for the fix came from @albertnetymk. Thanks!
>> The failure reproduces on my local MBP13 and does not reproduce
>> with this fix in place.
>
> Looks good.

@kimbarrett - Thanks for the review!

Do you think we need to wait for a Runtime/NMT reviewer?

-------------

PR: https://git.openjdk.java.net/jdk/pull/2557
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261661: gc/stress/TestReclaimStringsLeaksMemory.java fails because Reserved memory size is too big

Daniel D.Daugherty
In reply to this post by Kim Barrett-2
On Fri, 12 Feb 2021 21:48:28 GMT, Kim Barrett <[hidden email]> wrote:

>> A trivial fix to adjust a test to work with the fix from:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8261297 NMT: Final report should use scale 1
>>
>> The idea for the fix came from @albertnetymk. Thanks!
>> The failure reproduces on my local MBP13 and does not reproduce
>> with this fix in place.
>
> Looks good.

@kimbarrett and @coleenp just told me that I don't really need to wait for a Runtime/NMT review.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2557
Reply | Threaded
Open this post in threaded view
|

Integrated: 8261661: gc/stress/TestReclaimStringsLeaksMemory.java fails because Reserved memory size is too big

Daniel D.Daugherty
In reply to this post by Daniel D.Daugherty
On Fri, 12 Feb 2021 19:53:23 GMT, Daniel D. Daugherty <[hidden email]> wrote:

> A trivial fix to adjust a test to work with the fix from:
>
> https://bugs.openjdk.java.net/browse/JDK-8261297 NMT: Final report should use scale 1
>
> The idea for the fix came from @albertnetymk. Thanks!
> The failure reproduces on my local MBP13 and does not reproduce
> with this fix in place.

This pull request has now been integrated.

Changeset: 735757f1
Author:    Daniel D. Daugherty <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/735757f1
Stats:     4 lines in 1 file changed: 0 ins; 0 del; 4 mod

8261661: gc/stress/TestReclaimStringsLeaksMemory.java fails because Reserved memory size is too big

Co-authored-by: Albert Mingkun Yang <[hidden email]>
Reviewed-by: ayang, kbarrett

-------------

PR: https://git.openjdk.java.net/jdk/pull/2557
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261661: gc/stress/TestReclaimStringsLeaksMemory.java fails because Reserved memory size is too big

Thomas Stuefe
In reply to this post by Daniel D.Daugherty
On Fri, 12 Feb 2021 22:40:17 GMT, Daniel D. Daugherty <[hidden email]> wrote:

>> Looks good.
>
> @kimbarrett and @coleenp just told me that I don't really need to wait for a Runtime/NMT review.

This looks good. Sorry for the trouble.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2557