RFR: 8261711: Clhsdb "versioncheck true" throws NPE every time

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8261711: Clhsdb "versioncheck true" throws NPE every time

Chris Plummer-2
See CR for details. There's no test for `versioncheck`, and I don't think it's worth adding, especially for this trivial fix. Here's how I tested:
hsdb> versioncheck
versioncheck is true
hsdb> versioncheck false
hsdb> versioncheck
versioncheck is false
hsdb> versioncheck true
hsdb> versioncheck
versioncheck is true

-------------

Commit messages:
 - Use System.clearProperty rather than trying to set the property to null.

Changes: https://git.openjdk.java.net/jdk/pull/2566/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2566&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8261711
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2566.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2566/head:pull/2566

PR: https://git.openjdk.java.net/jdk/pull/2566
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261711: Clhsdb "versioncheck true" throws NPE every time

Alex Menkov-3
On Sun, 14 Feb 2021 09:14:43 GMT, Chris Plummer <[hidden email]> wrote:

> See CR for details. There's no test for `versioncheck`, and I don't think it's worth adding, especially for this trivial fix. Here's how I tested:
> hsdb> versioncheck
> versioncheck is true
> hsdb> versioncheck false
> hsdb> versioncheck
> versioncheck is false
> hsdb> versioncheck true
> hsdb> versioncheck
> versioncheck is true

Marked as reviewed by amenkov (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2566
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261711: Clhsdb "versioncheck true" throws NPE every time

Serguei Spitsyn-2
In reply to this post by Chris Plummer-2
On Sun, 14 Feb 2021 09:14:43 GMT, Chris Plummer <[hidden email]> wrote:

> See CR for details. There's no test for `versioncheck`, and I don't think it's worth adding, especially for this trivial fix. Here's how I tested:
> hsdb> versioncheck
> versioncheck is true
> hsdb> versioncheck false
> hsdb> versioncheck
> versioncheck is false
> hsdb> versioncheck true
> hsdb> versioncheck
> versioncheck is true

Looks good.

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2566
Reply | Threaded
Open this post in threaded view
|

Integrated: 8261711: Clhsdb "versioncheck true" throws NPE every time

Chris Plummer-2
In reply to this post by Chris Plummer-2
On Sun, 14 Feb 2021 09:14:43 GMT, Chris Plummer <[hidden email]> wrote:

> See CR for details. There's no test for `versioncheck`, and I don't think it's worth adding, especially for this trivial fix. Here's how I tested:
> hsdb> versioncheck
> versioncheck is true
> hsdb> versioncheck false
> hsdb> versioncheck
> versioncheck is false
> hsdb> versioncheck true
> hsdb> versioncheck
> versioncheck is true

This pull request has now been integrated.

Changeset: e7e20d4e
Author:    Chris Plummer <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/e7e20d4e
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

8261711: Clhsdb "versioncheck true" throws NPE every time

Reviewed-by: amenkov, sspitsyn

-------------

PR: https://git.openjdk.java.net/jdk/pull/2566