RFR: 8261752: Multiple GC test are missing memory requirements

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8261752: Multiple GC test are missing memory requirements

Christoph Göttschkes-2
I used systemd to figure out which memory requirement makes sense for which test:

$ systemd-run --user --scope -p MemoryMax=768M -p MemorySwapMax=0 /usr/bin/make TEST="..." test

Tests succeeding with `768M` of MemoryMax got a requirement of 1G, all others got 2G and succeeded with a MemoryMax of 1536M.

-------------

Commit messages:
 - Adds memory requirements.

Changes: https://git.openjdk.java.net/jdk/pull/2575/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2575&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8261752
  Stats: 7 lines in 7 files changed: 2 ins; 0 del; 5 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2575.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2575/head:pull/2575

PR: https://git.openjdk.java.net/jdk/pull/2575
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261752: Multiple GC test are missing memory requirements

Thomas Schatzl-4
On Mon, 15 Feb 2021 13:24:57 GMT, Christoph Göttschkes <[hidden email]> wrote:

> I used systemd to figure out which memory requirement makes sense for which test:
>
> $ systemd-run --user --scope -p MemoryMax=768M -p MemorySwapMax=0 /usr/bin/make TEST="..." test
>
> Tests succeeding with `768M` of MemoryMax got a requirement of 1G, all others got 2G and succeeded with a MemoryMax of 1536M.

Thanks. Lgtm.

-------------

Marked as reviewed by tschatzl (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2575
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261752: Multiple GC test are missing memory requirements

Christoph Göttschkes-2
On Tue, 16 Feb 2021 08:53:21 GMT, Thomas Schatzl <[hidden email]> wrote:

>> I used systemd to figure out which memory requirement makes sense for which test:
>>
>> $ systemd-run --user --scope -p MemoryMax=768M -p MemorySwapMax=0 /usr/bin/make TEST="..." test
>>
>> Tests succeeding with `768M` of MemoryMax got a requirement of 1G, all others got 2G and succeeded with a MemoryMax of 1536M.
>
> Thanks. Lgtm.

Thanks for the review.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2575
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261752: Multiple GC test are missing memory requirements

Stefan Johansson
In reply to this post by Christoph Göttschkes-2
On Mon, 15 Feb 2021 13:24:57 GMT, Christoph Göttschkes <[hidden email]> wrote:

> I used systemd to figure out which memory requirement makes sense for which test:
>
> $ systemd-run --user --scope -p MemoryMax=768M -p MemorySwapMax=0 /usr/bin/make TEST="..." test
>
> Tests succeeding with `768M` of MemoryMax got a requirement of 1G, all others got 2G and succeeded with a MemoryMax of 1536M.

Looks good.

-------------

Marked as reviewed by sjohanss (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2575
Reply | Threaded
Open this post in threaded view
|

Integrated: 8261752: Multiple GC test are missing memory requirements

Christoph Göttschkes-2
In reply to this post by Christoph Göttschkes-2
On Mon, 15 Feb 2021 13:24:57 GMT, Christoph Göttschkes <[hidden email]> wrote:

> I used systemd to figure out which memory requirement makes sense for which test:
>
> $ systemd-run --user --scope -p MemoryMax=768M -p MemorySwapMax=0 /usr/bin/make TEST="..." test
>
> Tests succeeding with `768M` of MemoryMax got a requirement of 1G, all others got 2G and succeeded with a MemoryMax of 1536M.

This pull request has now been integrated.

Changeset: 2e18b52a
Author:    Christoph Göttschkes <[hidden email]>
Committer: Thomas Schatzl <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/2e18b52a
Stats:     7 lines in 7 files changed: 2 ins; 0 del; 5 mod

8261752: Multiple GC test are missing memory requirements

Reviewed-by: tschatzl, sjohanss

-------------

PR: https://git.openjdk.java.net/jdk/pull/2575