RFR: 8261758: [TESTBUG] gc/g1/TestGCLogMessages.java fails if ergonomics detect too small InitialHeapSize

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8261758: [TESTBUG] gc/g1/TestGCLogMessages.java fails if ergonomics detect too small InitialHeapSize

Christoph Göttschkes-2
Adds an explicit -Xms to one part of the test case, to not rely on ergonomics to detect the correct InitialHeapSize.

It looks like one part of the whole test case implicitly relied on the fact, that `InitialHeapSize` == `MaxHeapSize`. Since the `MaxHeapSize` is very small (32M), this is almost always true. But if the test device has less than 2G of memory, the ergonomics configure the `InitialHeapSize` to be smaller than the `MaxHeapSize`.

-------------

Commit messages:
 - Fixes indention.
 - Adds -Xms = -Xmx to not rely on ergonomics.

Changes: https://git.openjdk.java.net/jdk/pull/2577/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2577&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8261758
  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2577.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2577/head:pull/2577

PR: https://git.openjdk.java.net/jdk/pull/2577
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261758: [TESTBUG] gc/g1/TestGCLogMessages.java fails if ergonomics detect too small InitialHeapSize

Thomas Schatzl-4
On Mon, 15 Feb 2021 15:20:56 GMT, Christoph Göttschkes <[hidden email]> wrote:

> Adds an explicit -Xms to one part of the test case, to not rely on ergonomics to detect the correct InitialHeapSize.
>
> It looks like one part of the whole test case implicitly relied on the fact, that `InitialHeapSize` == `MaxHeapSize`. Since the `MaxHeapSize` is very small (32M), this is almost always true. But if the test device has less than 2G of memory, the ergonomics configure the `InitialHeapSize` to be smaller than the `MaxHeapSize`.

Marked as reviewed by tschatzl (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2577
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261758: [TESTBUG] gc/g1/TestGCLogMessages.java fails if ergonomics detect too small InitialHeapSize

Christoph Göttschkes-2
On Tue, 16 Feb 2021 08:50:48 GMT, Thomas Schatzl <[hidden email]> wrote:

>> Adds an explicit -Xms to one part of the test case, to not rely on ergonomics to detect the correct InitialHeapSize.
>>
>> It looks like one part of the whole test case implicitly relied on the fact, that `InitialHeapSize` == `MaxHeapSize`. Since the `MaxHeapSize` is very small (32M), this is almost always true. But if the test device has less than 2G of memory, the ergonomics configure the `InitialHeapSize` to be smaller than the `MaxHeapSize`.
>
> Marked as reviewed by tschatzl (Reviewer).

Thanks for the review.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2577
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261758: [TESTBUG] gc/g1/TestGCLogMessages.java fails if ergonomics detect too small InitialHeapSize

Stefan Johansson
In reply to this post by Christoph Göttschkes-2
On Mon, 15 Feb 2021 15:20:56 GMT, Christoph Göttschkes <[hidden email]> wrote:

> Adds an explicit -Xms to one part of the test case, to not rely on ergonomics to detect the correct InitialHeapSize.
>
> It looks like one part of the whole test case implicitly relied on the fact, that `InitialHeapSize` == `MaxHeapSize`. Since the `MaxHeapSize` is very small (32M), this is almost always true. But if the test device has less than 2G of memory, the ergonomics configure the `InitialHeapSize` to be smaller than the `MaxHeapSize`.

Marked as reviewed by sjohanss (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2577
Reply | Threaded
Open this post in threaded view
|

Integrated: 8261758: [TESTBUG] gc/g1/TestGCLogMessages.java fails if ergonomics detect too small InitialHeapSize

Christoph Göttschkes-2
In reply to this post by Christoph Göttschkes-2
On Mon, 15 Feb 2021 15:20:56 GMT, Christoph Göttschkes <[hidden email]> wrote:

> Adds an explicit -Xms to one part of the test case, to not rely on ergonomics to detect the correct InitialHeapSize.
>
> It looks like one part of the whole test case implicitly relied on the fact, that `InitialHeapSize` == `MaxHeapSize`. Since the `MaxHeapSize` is very small (32M), this is almost always true. But if the test device has less than 2G of memory, the ergonomics configure the `InitialHeapSize` to be smaller than the `MaxHeapSize`.

This pull request has now been integrated.

Changeset: c7885eb1
Author:    Christoph Göttschkes <[hidden email]>
Committer: Thomas Schatzl <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/c7885eb1
Stats:     1 line in 1 file changed: 1 ins; 0 del; 0 mod

8261758: [TESTBUG] gc/g1/TestGCLogMessages.java fails if ergonomics detect too small InitialHeapSize

Reviewed-by: tschatzl, sjohanss

-------------

PR: https://git.openjdk.java.net/jdk/pull/2577