RFR: 8261860: Crash caused by lambda proxy class loaded in Shutdown hook

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8261860: Crash caused by lambda proxy class loaded in Shutdown hook

Calvin Cheung
A simple fix to check if the nest host is in the "linked" state before including its lambda proxy classes in the archive during CDS dynamic dump.

Testing: tier1, hs-tiers 2,3,4.

-------------

Commit messages:
 - 8261860: Crash caused by lambda proxy class loaded in Shutdown hook

Changes: https://git.openjdk.java.net/jdk/pull/2634/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2634&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8261860
  Stats: 138 lines in 3 files changed: 137 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2634.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2634/head:pull/2634

PR: https://git.openjdk.java.net/jdk/pull/2634
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261860: Crash caused by lambda proxy class loaded in Shutdown hook

Ioi Lam-2
On Thu, 18 Feb 2021 23:51:08 GMT, Calvin Cheung <[hidden email]> wrote:

> A simple fix to check if the nest host is in the "linked" state before including its lambda proxy classes in the archive during CDS dynamic dump.
>
> Testing: tier1, hs-tiers 2,3,4.

LGTM

-------------

Marked as reviewed by iklam (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2634
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261860: Crash caused by lambda proxy class loaded in Shutdown hook

Yumin Qi-3
In reply to this post by Calvin Cheung
On Thu, 18 Feb 2021 23:51:08 GMT, Calvin Cheung <[hidden email]> wrote:

> A simple fix to check if the nest host is in the "linked" state before including its lambda proxy classes in the archive during CDS dynamic dump.
>
> Testing: tier1, hs-tiers 2,3,4.

LGTM.

-------------

Marked as reviewed by minqi (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2634
Reply | Threaded
Open this post in threaded view
|

Integrated: 8261860: Crash caused by lambda proxy class loaded in Shutdown hook

Calvin Cheung
In reply to this post by Calvin Cheung
On Thu, 18 Feb 2021 23:51:08 GMT, Calvin Cheung <[hidden email]> wrote:

> A simple fix to check if the nest host is in the "linked" state before including its lambda proxy classes in the archive during CDS dynamic dump.
>
> Testing: tier1, hs-tiers 2,3,4.

This pull request has now been integrated.

Changeset: 78cde648
Author:    Calvin Cheung <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/78cde648
Stats:     138 lines in 3 files changed: 137 ins; 0 del; 1 mod

8261860: Crash caused by lambda proxy class loaded in Shutdown hook

Reviewed-by: iklam, minqi

-------------

PR: https://git.openjdk.java.net/jdk/pull/2634