RFR: 8261905: Move implementation of OopStorage num_dead related functions

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8261905: Move implementation of OopStorage num_dead related functions

Kim Barrett-2
Please review this trivial change which just moves several functions to a
different location in the same file.  The old location is in the middle of
some unrelated functionality.

Testing:
mach5 tier1

-------------

Commit messages:
 - move num_dead functions

Changes: https://git.openjdk.java.net/jdk/pull/2608/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2608&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8261905
  Stats: 30 lines in 1 file changed: 15 ins; 15 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2608.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2608/head:pull/2608

PR: https://git.openjdk.java.net/jdk/pull/2608
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261905: Move implementation of OopStorage num_dead related functions

Albert Mingkun Yang
On Wed, 17 Feb 2021 15:18:40 GMT, Kim Barrett <[hidden email]> wrote:

> Please review this trivial change which just moves several functions to a
> different location in the same file.  The old location is in the middle of
> some unrelated functionality.
>
> Testing:
> mach5 tier1

Marked as reviewed by ayang (Author).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2608
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261905: Move implementation of OopStorage num_dead related functions

Thomas Schatzl-4
In reply to this post by Kim Barrett-2
On Wed, 17 Feb 2021 15:18:40 GMT, Kim Barrett <[hidden email]> wrote:

> Please review this trivial change which just moves several functions to a
> different location in the same file.  The old location is in the middle of
> some unrelated functionality.
>
> Testing:
> mach5 tier1

Marked as reviewed by tschatzl (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2608
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261905: Move implementation of OopStorage num_dead related functions [v2]

Kim Barrett-2
In reply to this post by Kim Barrett-2
> Please review this trivial change which just moves several functions to a
> different location in the same file.  The old location is in the middle of
> some unrelated functionality.
>
> Testing:
> mach5 tier1

Kim Barrett has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:

 - Merge branch 'master' into move_num_dead
 - move num_dead functions

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/2608/files
  - new: https://git.openjdk.java.net/jdk/pull/2608/files/baa9f5d2..578009f4

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2608&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2608&range=00-01

  Stats: 947 lines in 49 files changed: 661 ins; 155 del; 131 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2608.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2608/head:pull/2608

PR: https://git.openjdk.java.net/jdk/pull/2608
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261905: Move implementation of OopStorage num_dead related functions [v2]

Kim Barrett-2
In reply to this post by Albert Mingkun Yang
On Wed, 17 Feb 2021 15:39:02 GMT, Albert Mingkun Yang <[hidden email]> wrote:

>> Kim Barrett has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>>
>>  - Merge branch 'master' into move_num_dead
>>  - move num_dead functions
>
> Marked as reviewed by ayang (Author).

Thanks @albertnetymk and @tschatzl for reviews.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2608
Reply | Threaded
Open this post in threaded view
|

Integrated: 8261905: Move implementation of OopStorage num_dead related functions

Kim Barrett-2
In reply to this post by Kim Barrett-2
On Wed, 17 Feb 2021 15:18:40 GMT, Kim Barrett <[hidden email]> wrote:

> Please review this trivial change which just moves several functions to a
> different location in the same file.  The old location is in the middle of
> some unrelated functionality.
>
> Testing:
> mach5 tier1

This pull request has now been integrated.

Changeset: 7e78c777
Author:    Kim Barrett <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/7e78c777
Stats:     30 lines in 1 file changed: 15 ins; 15 del; 0 mod

8261905: Move implementation of OopStorage num_dead related functions

Reviewed-by: ayang, tschatzl

-------------

PR: https://git.openjdk.java.net/jdk/pull/2608